Received: by 2002:a05:7412:8d1c:b0:fa:4c10:6cad with SMTP id bj28csp305684rdb; Wed, 17 Jan 2024 02:30:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IFgfFIZjSZ35G7CIxu1rZN6V8ecQU8EeD167tHI7K8X0h1kH9VEBco86ot6DRjBQLMI4hxM X-Received: by 2002:a9d:6856:0:b0:6dc:f8:7913 with SMTP id c22-20020a9d6856000000b006dc00f87913mr9373826oto.20.1705487454821; Wed, 17 Jan 2024 02:30:54 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705487454; cv=pass; d=google.com; s=arc-20160816; b=fOyDnexHpdNUd1nsY5sF2EGb8NlveWv1RYBabRZZovH1IjoQ2AL6Y+9ikmr0Cg82xq /w+gTyOJJWIOPARgJFzGl44atPPuheiOF/E5GuqD7FeUolnIxQYMZWQmaOfg0w/k3ram 8Q+R03kATeF9SCCVmYMpVUAOEbuYDKMQ/8c+X7RZHdArGTv6da4HElEdlQ7arBkU5Gt8 4qqlPU7ilfOU5WA9+ZyGf+sn6Ys56wk3fqHcU4qpAtIS/g3Ulad6TneIAMrHP8gD9aj2 tLlfZfnXLL51jbn5aXdpuPzKLbg7XbrLj0pM0K4734Mst55NK8ReokdZirkmRhdrjbEA JBtg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=ehY7MTwLJceulhBYYQjUSWYeXY0wgMcqskl/4hnkdS0=; fh=c4SWefwPnDBL/h4hfmTNJ3/EdZgKZx+7X7D6BlF0Dbw=; b=cL7GtPToh00rLDXP0XUanPfVGN9Es0n5JDA+F+WAkgwvx/f3W2Tcy9kMRY/uSlOjTM aiHueSZf3X8w4uNSt0fDg+lbOw5XwthxOX/UxAy4QYXRp97AOrhRbMAAhVQ5FGB9fLbY mlb/TU5biNute5wzRMpY0krKPnc5omB1MVFi945XqED1b+D3JZo2elQLys5rP7OcBLrD 4Hux0a+HkVTgo4cZLFJOIjkURVVy1kuKlvEqjerBc8LtWNSNkMTz9pnYTq11LL6FGnOT StRnZWWAYamJiiafyz4hbN+qecMGMQraNnwbIufBdx4+oS8SWw7maVl7zlDurVbar1UB xdBg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@arinc9.com header.s=gm1 header.b=GRL4GvMd; arc=pass (i=1 spf=pass spfdomain=arinc9.com dkim=pass dkdomain=arinc9.com dmarc=pass fromdomain=arinc9.com); spf=pass (google.com: domain of linux-kernel+bounces-28836-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-28836-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=arinc9.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id ca13-20020a056a02068d00b005cd87069a84si13946726pgb.764.2024.01.17.02.30.54 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jan 2024 02:30:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-28836-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@arinc9.com header.s=gm1 header.b=GRL4GvMd; arc=pass (i=1 spf=pass spfdomain=arinc9.com dkim=pass dkdomain=arinc9.com dmarc=pass fromdomain=arinc9.com); spf=pass (google.com: domain of linux-kernel+bounces-28836-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-28836-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=arinc9.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 9216AB22C2D for ; Wed, 17 Jan 2024 10:29:45 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0B5411BC55; Wed, 17 Jan 2024 10:29:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=arinc9.com header.i=@arinc9.com header.b="GRL4GvMd" Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D2CF1DA36; Wed, 17 Jan 2024 10:29:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.194 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705487343; cv=none; b=DzinMI/EJq8WVWnQX10VoI+BzbLuEPS/yK+GaYkwjddp5yj//+ghZybufXYrRRPuV7qugZJGcQ5U7hMR06HqFNnOZB+lWNUn5KysX80ZK2gF68ZhQIZR0fXRkK/NRBoyTjRnQPq2FlBmYht5KlpqBPTTrhTR1d7SRZedxuVZeHY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705487343; c=relaxed/simple; bh=yAcYLNg55z41pL27utNBHpuUvxkDcfdOEgiC8Jx3dCc=; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-Id: X-Mailer:In-Reply-To:References:MIME-Version:Content-Type: Content-Transfer-Encoding:X-GND-Sasl; b=iYgilAdZ9PkcAQBGod5icLwGE+k6ByjqmQ4X/4gDOsmRXiFu1aucmcz8n+f6A3PjO1mseTszHQMBGy+jeBmGn7RKVdfx4AP5wHvZZhmKywK6mFCPXMMpoLlmB77titA80EFUpYSRaGGb0B8QebmeFa8pbHsEh5pnnh8NOTbaW/w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arinc9.com; spf=pass smtp.mailfrom=arinc9.com; dkim=pass (2048-bit key) header.d=arinc9.com header.i=@arinc9.com header.b=GRL4GvMd; arc=none smtp.client-ip=217.70.183.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arinc9.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arinc9.com Received: by mail.gandi.net (Postfix) with ESMTPSA id 804D54000D; Wed, 17 Jan 2024 10:28:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arinc9.com; s=gm1; t=1705487339; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ehY7MTwLJceulhBYYQjUSWYeXY0wgMcqskl/4hnkdS0=; b=GRL4GvMdUAHexlp4cQzFR/2dJ5u3H7CqQ8MdYH3FW78qc5G2tQwAIZ3+ZhbVPOyKJvaxUS 1dvwq6OfKDKgmUOqbbKdqC5pzGo/sO5UcZJ0pzPQaFvYnt+UNGm1vNp0qCTF2wvWIjRG1j XC9zqm69mcl/gfIANIxxGaXH8mK+qhEj6bLgUcTJ5VhP5HfGsh+MWStONR+1ao+PgH/ahT 7TNxXtDSs7tx3d+dRbc+S46hLoJkdBE79U/T6vG2C6rBClf8pQ6WikwcAZOscJuxuwPfhv PvbvrJGnwOj7SKLRrlxpySfzotYA080yQgTzB3xJQqF/EYDnzFo7/nDfXSAuuw== From: =?UTF-8?q?Ar=C4=B1n=C3=A7=20=C3=9CNAL?= To: Daniel Golle , Landen Chao , DENG Qingfang , Sean Wang , Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Russell King Cc: =?UTF-8?q?Ar=C4=B1n=C3=A7=20=C3=9CNAL?= , mithat.guner@xeront.com, erkin.bozoglu@xeront.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [RFC PATCH net-next 2/8] net: dsa: mt7530: set interrupt register only for MT7530 Date: Wed, 17 Jan 2024 13:28:32 +0300 Message-Id: <20240117102838.57445-3-arinc.unal@arinc9.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20240117102838.57445-1-arinc.unal@arinc9.com> References: <20240117102838.57445-1-arinc.unal@arinc9.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Sasl: arinc.unal@arinc9.com Setting this register related to interrupts is only needed for the MT7530 switch. Make an exclusive check to ensure this. Signed-off-by: Arınç ÜNAL Acked-by: Daniel Golle Tested-by: Daniel Golle --- drivers/net/dsa/mt7530.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c index c55edbda32bd..d2e861361191 100644 --- a/drivers/net/dsa/mt7530.c +++ b/drivers/net/dsa/mt7530.c @@ -2054,7 +2054,7 @@ mt7530_setup_irq(struct mt7530_priv *priv) } /* This register must be set for MT7530 to properly fire interrupts */ - if (priv->id != ID_MT7531) + if (priv->id == ID_MT7530 || priv->id == ID_MT7621) mt7530_set(priv, MT7530_TOP_SIG_CTRL, TOP_SIG_CTRL_NORMAL); ret = request_threaded_irq(priv->irq, NULL, mt7530_irq_thread_fn, -- 2.40.1