Received: by 2002:a05:7412:8d1c:b0:fa:4c10:6cad with SMTP id bj28csp313556rdb; Wed, 17 Jan 2024 02:52:15 -0800 (PST) X-Google-Smtp-Source: AGHT+IHsT1n4XUoaI4YQKFO/ZdS1kTqFBKybOpRbYTS7LBq22XWIX5XvOaDc5XJ809IPlwDpYBp6 X-Received: by 2002:a05:620a:34c:b0:783:2c7d:ec23 with SMTP id t12-20020a05620a034c00b007832c7dec23mr8350599qkm.37.1705488735489; Wed, 17 Jan 2024 02:52:15 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705488735; cv=pass; d=google.com; s=arc-20160816; b=jijJuJRDefECfH5AFRPpwqwgh2ysQ4D1ElhR0lsFvCC6ybQNyrSSoTIFsqmfll2Inj KE/i8CJ/1ic0aAW/3IlqzyNCQp4A0VcbjDr3KOTx1jZpFxPPBI/Nt9ABWb50BuUEgXDY E4QEAmjVsZ2zFI4BlV9vkox29Pa2rPeC8MEyaYnGNgM+B43jdvZUd8LNdjVNtCFU4lF9 ePPiP8bKvBgOpcadZtB3WBsYJjkx3qMuiH/c/MhugO5CCS+1RpuZTq5D7OSxttEV5lsw i5oW2MVGFgoemmaGYXJInuj6BxIlRuHxEi/bNrZsRrLOE5hc3GgQIhXTBz4M/kMFpF8+ Fl5w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date; bh=0bYqceHdGGpInX0WBWZXogzsVZYi7MFAqnHvYeSP6BA=; fh=02goHv1gf6IZnl+8PZbgYXgaPEv5CNyC0dSuav09zS8=; b=X76VIjNpe+BtCJwPtJJ7cio4f6gssN3rf+f3BRuTH4aappog+vQ8q4f7k1bIQQ2EGR AncEXSSqm8jRPy0VaMXlfOt95vvGoMZhG4GHT+OKZQF7H85s2/cFa9vfeEm9VkC3YDYi MLzBeEQjJYA/t9uMrGlzHoXUSAbcdtk9mDKYRgAMsAZVP63G2zFOwrv4xBHAFLpqKBXA rrd84aNLduhAEUSoqdw278nTVGRPThiGrQMaMR6fjfb9K3fXg+g5GFf3krrPJgwl4dCA eUptbVUoKJUQbspiwgI37ebhNpm2N7NujN6X8mvaddKmTh+TmpM2r1mnOM8C4jsOf/4V A52A== ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=pengutronix.de); spf=pass (google.com: domain of linux-kernel+bounces-28865-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-28865-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id c2-20020a37e102000000b00783223599f2si11556104qkm.133.2024.01.17.02.52.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jan 2024 02:52:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-28865-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=pengutronix.de); spf=pass (google.com: domain of linux-kernel+bounces-28865-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-28865-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 2F5811C23D26 for ; Wed, 17 Jan 2024 10:52:15 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 55A261C6B4; Wed, 17 Jan 2024 10:52:08 +0000 (UTC) Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28C6C1B81B for ; Wed, 17 Jan 2024 10:52:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705488727; cv=none; b=f80nzWtVG1AeCSbPkIRcEUUbP0WwTLPkJaxeDMfhf6vQoA+koRaEtYutISL/bxAiw/dVyII9slCneMxBxP1cUSm3a2FiNqXGO+Mrkubw95Q4PDuT8I7uIAAPv6iKhjz6zZ22D0xAFKOVJg6AAvkRlA5hqV5C3RSBvX6/02T59Lw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705488727; c=relaxed/simple; bh=wxx/RVt1Ce8dhvHdZDzLvR+TT/ZDvDGUMmcgCbwsodA=; h=Received:Received:Received:Date:From:To:Cc:Subject:Message-ID: References:MIME-Version:Content-Type:Content-Disposition: In-Reply-To:X-SA-Exim-Connect-IP:X-SA-Exim-Mail-From: X-SA-Exim-Scanned:X-PTX-Original-Recipient; b=Cbn6x+iBrqL1aqJD2DEFIJBtmbodMjFoBAKcv2Cvhe+C7WXDHIicJgp/e3Uu1IuYGrk4pjWkbXJOVC9nE6VJnEC5dcQqjZI2d/K1+ZOhfAwS7fVYtmbVX9nbRXYbQPGlB5JqIjKLbageBvtwcL7YsFhT4r+1pIpLm5dsJsRWwtw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rQ3WT-0000Z4-Vr; Wed, 17 Jan 2024 11:51:53 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rQ3WS-000RZ9-OT; Wed, 17 Jan 2024 11:51:52 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rQ3WS-001dbj-28; Wed, 17 Jan 2024 11:51:52 +0100 Date: Wed, 17 Jan 2024 11:51:52 +0100 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Jerome Brunet Cc: Thierry Reding , Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kevin Hilman , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-pwm@vger.kernel.org, JunYi Zhao Subject: Re: [PATCH v4 2/6] dt-bindings: pwm: amlogic: add new compatible for meson8 pwm type Message-ID: References: <20231222111658.832167-1-jbrunet@baylibre.com> <20231222111658.832167-3-jbrunet@baylibre.com> <4rdb2be2bfzak3s4uaizthcdcdwdrxnx4kr2sgn527hvsie3pb@gfqciim7yryz> <1jfrywxnu5.fsf@starbuckisacylon.baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="3bhlfpvugwaqjoz5" Content-Disposition: inline In-Reply-To: <1jfrywxnu5.fsf@starbuckisacylon.baylibre.com> X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org --3bhlfpvugwaqjoz5 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello Jerome, On Wed, Jan 17, 2024 at 11:16:31AM +0100, Jerome Brunet wrote: > On Wed 17 Jan 2024 at 10:58, Uwe Kleine-K=F6nig wrote: > > [[PGP Signed Part:Undecided]] > > Hello, > > > > On Fri, Dec 22, 2023 at 12:16:50PM +0100, Jerome Brunet wrote: > >> diff --git a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml b/= Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml > >> index a1d382aacb82..eece390114a3 100644 > >> --- a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml > >> +++ b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml > >> @@ -21,23 +21,35 @@ properties: > >> - amlogic,meson-g12a-ee-pwm > >> - amlogic,meson-g12a-ao-pwm-ab > >> - amlogic,meson-g12a-ao-pwm-cd > >> - - amlogic,meson-s4-pwm Either I still didn't grasp all the details of this change, or removing amlogic,meson-s4-pwm in this commit is wrong. > >> + deprecated: true > >> - items: > >> - const: amlogic,meson-gx-pwm > >> - const: amlogic,meson-gxbb-pwm > >> + deprecated: true > >> - items: > >> - const: amlogic,meson-gx-ao-pwm > >> - const: amlogic,meson-gxbb-ao-pwm > >> + deprecated: true > >> - items: > >> - const: amlogic,meson8-pwm > >> - const: amlogic,meson8b-pwm > >> + deprecated: true > > > > I think deprecating the old binding and adding a new compatible should > > be done in two commits. >=20 > Hi Uwe, >=20 > There was the same comment on v3 and Krzysztof said it should be done > like this: >=20 > https://lore.kernel.org/linux-pwm/e127dcef-3149-443a-9a8c-d24ef4054f09@li= naro.org >=20 > I tend to agree with Krzysztof on this but, as I previously said, > I don't really mind one way or the other. Just have to pick one. Ah, so the machines that used amlogic,meson-g12a-ee-pwm before are supposed to use amlogic,meson-g12-pwm-v2 now. With that understood I agree to you and Krzysztof. I wonder if me not understanding that is a sign that the commit log isn't optimal (or if it's only that I didn't properly read it :-). Now that I understood the change better, the commit log is understandable, but maybe still make it a bit more explicit that it introduces a new way to formalize already supported hardware. Something like: dt-bindings: pwm: amlogic: Add a new binding for meson8 pwm types The binding that is used up to now describe which input the PWM channel multiplexer should pick among its possible parents, which are hardcoded in the driver. This isn't a good binding in the sense that it should describe hardware but not usage. Add a new binding deprecating the old one that uses clocks in a better way and how clocks are usually used today: The list of clocks describe the inputs of the PWM block as they are realised in hardware. So deprecate the old bindings and introduce a compatible per SoC family to replace these. I think I'd understand that better, but that might be because I wrote it and it's subjective? Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --3bhlfpvugwaqjoz5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmWnsUcACgkQj4D7WH0S /k5jBgf+K4/2nlwNuhl98wP3lhKs9noKvnoecmlxEqzV+HowMVaRvasoTYxpWZst F0kE3hWQF654JB/Whvdb9NVMJHUIfvuok6egBVBC7VKtGKR8sUUUD1vc0CnxV1OE tosScnl0r/zPXyFWU6xYPzFHVrnndxBwjvneScCkA8W1hx8eLG3B8pFHFTjsxvOg gQtlS46eDfnJ9llQDl1N2iZHdOdfAXqFegZB2RCHmIorS1z86x53Wci/tFvYLH6F e6Jn0Nwrf6EPHzQK2FCQZOa9BwFJDZ6NiivNXMSzp4RgCSmNEySOlc4XVBoF4Sh7 hbnETJ5us1luELfbF4oSg2Y3H8c3Vw== =iYzS -----END PGP SIGNATURE----- --3bhlfpvugwaqjoz5--