Received: by 2002:a05:7412:8d1c:b0:fa:4c10:6cad with SMTP id bj28csp360002rdb; Wed, 17 Jan 2024 04:25:41 -0800 (PST) X-Google-Smtp-Source: AGHT+IHzu4eYE64Ll2G8Tjeh2jq/tfPvk6MnBs3vxLiZRH7QpKu3PROLI78/jRaRBi15Mcawxhqk X-Received: by 2002:a05:6a20:9194:b0:199:b434:aa95 with SMTP id v20-20020a056a20919400b00199b434aa95mr9008939pzd.114.1705494341473; Wed, 17 Jan 2024 04:25:41 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705494341; cv=pass; d=google.com; s=arc-20160816; b=p5acfgeisWJQ1S155Z23Fz7VJH1DLgrrR0TKs5bZr3I5jmN1iJ13iZMiyanzVibjD3 2V6RzL+m45uvKPASxPN9YtgeFHIWHSyjk48daT6Z7c/qL13mmYyEG0DFe23ne7HZEQoN dB05GrzqIOnsrdhlcjZnB0wHnmT9MFzw6GxLq2nQO6e23ep4DsFF9SN2GrmPtx8HbYTK TDB4RlELL96b7GRRJ7s3cXDnr1MUn6vVblatJhG1fGlFw7Z1ZW7L0Yce8g28g4VXBMY7 pPPTCUHdm4JfaATNKaOiMHWrhLmITEBSadLovp+kNKNMRj/5Gs4jlLcKjoX1rFu+zLfV hn0g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :dkim-signature; bh=tqn31a8Q43TcX43OmGCB3MQCcwEGW2dYHZPltYe4F0o=; fh=ItUeAjDAZciUEVbryFon+rPqrDyFBpcbDeblKpp9XEE=; b=FGO4+nAyMvzdn+6/nc21iqCkDLOUuT5vgqHhvYo+TvsX0yE5aEk3Nn+l5jvAX1qR5O xiwcSBLlRxF5o/erH74Xmq0LFJX82jel7j07XnUtop0qriUGt9XulB+bg6sYoH/Z3uVT ZckkCWHN07T1gStpsiXf9xPkYy9wvj40HExbVyVNr7XT1hfQQrXeXEWJqRK4yVwNP5pY pEB8tzvBZ0Jgvdtsk/A3Y5cBFKhs/DVMedm0SId/7FLboWWHriyFqd6vexb47Q+J2qUo 74s5vFGHjcXJ+pPfiqoYAr+gvsckbw1rC5uUjQgaz+KNXfb9HK0T5zatdmoHWqSC/JsE 0gHg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ndoVtZu2; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-28949-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-28949-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id z26-20020a056a001d9a00b006cb852928ffsi1602826pfw.66.2024.01.17.04.25.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jan 2024 04:25:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-28949-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ndoVtZu2; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-28949-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-28949-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 78E53289A79 for ; Wed, 17 Jan 2024 12:18:04 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B3C5B1DFEF; Wed, 17 Jan 2024 12:17:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ndoVtZu2" Received: from mail-yw1-f177.google.com (mail-yw1-f177.google.com [209.85.128.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C11191EA6F for ; Wed, 17 Jan 2024 12:17:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705493874; cv=none; b=rc6CTsZN2qo9EuEJf18dRcP4IUoJAUZKN7TxS32ufHN6M22aj1aYfaIED+9JsqGe425bNvktaTmRna2HIhalI5PmBHqvuO0YeVdNw6c5LiERn1gJWTvUyWhTelfXN8aZ6Ui/ohCxSjJFtmoSsj6FvUHCS7yzQQj5XVTCMJGdkkA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705493874; c=relaxed/simple; bh=OFihm6yOSdyrIX3TVPPEgVNi0cjH0fyFN/STG0Fxcuo=; h=Received:DKIM-Signature:X-Google-DKIM-Signature: X-Gm-Message-State:X-Google-Smtp-Source:X-Received:MIME-Version: References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc: Content-Type; b=uSUzTKEwlApqr//Dg3dY2UBSBpgVyVj/GQX9Sfa0KGtbzcqg29g+CeMMfeQDZSopA62W04+WUwYIUWoXdvBvDnTxLubZ0GB2giIP6HtXRUsIBLsAqyIrfgNGHhd75y+lkgMxtMkTiUWFSrFyyKouaRODeBppbRwK34dmsli05J8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ndoVtZu2; arc=none smtp.client-ip=209.85.128.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-yw1-f177.google.com with SMTP id 00721157ae682-5edfcba97e3so115811727b3.2 for ; Wed, 17 Jan 2024 04:17:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1705493872; x=1706098672; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=tqn31a8Q43TcX43OmGCB3MQCcwEGW2dYHZPltYe4F0o=; b=ndoVtZu2kFu0MEO1J/zCXgpPJ6zKpbg5yHfQF+FM0aTdLs4Y1r5W4enpH6RzYR/dWw LpyA/b8ryl/qPxAshlv7LgYALNCg5sBzAaA8sM5Y3/dd1XX7X26jhf0xnnMKlxdSWYxM uad68sFf/xkB+o+LnncFagHMVW5NU/LAsuQS33RO90uIxeweKKil5lY/dY+LAFlsYebm nOw97WJ7v+W28SlxRsrZEGkS0Y0unz6bmUl27SmMrr9gCMrtU1ZftGqu50fzwNR9qasf 3Z1NVG8XYMCF7pVd2+Z1BISmqztOFg3ZFWqrF8huinxQJrE/XbOVCIohh42o3g8IEfsu Muyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705493872; x=1706098672; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tqn31a8Q43TcX43OmGCB3MQCcwEGW2dYHZPltYe4F0o=; b=S8jJRGqUNib/P39+Z80O+QgWzd3l77/0d3O3HzRcIkJaFPph7hOuBW0uW/RR6QPSAu weiqLSFYMiL3Nv03zMkKTRA2aakc2ygg8Lg5Gfn3GR7FwCA9K9Pt9JRHiC/fmLImjigw EjjjwPDYT4wH34bampwVomjxegatMz4QWN614PXi6LGxsk7CC6w9ffDIG4r976TCnC5J 27torCNAeMCSQIf4oQt7UfI6IBFWksHsd0H4lBpml8DhHWQoi360rAz2w+5IY7kjrrUX gS9ROu2zbe5EwzHrvOSiseEwA7rtm2iqsbr/Ysl7njdVO6gZ131/hMP1rzWdisZu3Bfq /Ccw== X-Gm-Message-State: AOJu0YwcutukN//zfApP76nOuIl7elV1wRHXe1XhNyNsPrvlZHMTPR3n 63t4xGsVtUXB+KP0qQrs45cwuCS038Cu/m9b50tgw+BxsJziVw== X-Received: by 2002:a81:b656:0:b0:5ff:64d6:ee49 with SMTP id h22-20020a81b656000000b005ff64d6ee49mr833182ywk.64.1705493871659; Wed, 17 Jan 2024 04:17:51 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240116194225.250921-1-sashal@kernel.org> <20240116194225.250921-44-sashal@kernel.org> In-Reply-To: From: Dmitry Baryshkov Date: Wed, 17 Jan 2024 14:17:40 +0200 Message-ID: Subject: Re: [PATCH AUTOSEL 6.7 044/108] usb: typec: ucsi: fix UCSI on buggy Qualcomm devices To: Johan Hovold Cc: Sasha Levin , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Heikki Krogerus , Neil Armstrong , Bjorn Andersson , gregkh@linuxfoundation.org, hdegoede@redhat.com, fabrice.gasnier@foss.st.com, quic_jackp@quicinc.com, saranya.gopal@intel.com, quic_linyyuan@quicinc.com, andriy.shevchenko@linux.intel.com, minhuadotchen@gmail.com, johan+linaro@kernel.org, robh@kernel.org, linux-usb@vger.kernel.org Content-Type: text/plain; charset="UTF-8" On Wed, 17 Jan 2024 at 10:03, Johan Hovold wrote: > > On Tue, Jan 16, 2024 at 02:39:10PM -0500, Sasha Levin wrote: > > From: Dmitry Baryshkov > > > > [ Upstream commit 1d103d6af241dbfc7e11eb9a46dff65db257a37f ] > > > > On sevral Qualcomm platforms (SC8180X, SM8350, SC8280XP) a call to > > UCSI_GET_PDOS for non-PD partners will cause a firmware crash with no > > easy way to recover from it. Since we have no easy way to determine > > whether the partner really has PD support, shortcut UCSI_GET_PDOS on > > such platforms. This allows us to enable UCSI support on such devices. > > > > Signed-off-by: Dmitry Baryshkov > > Acked-by: Heikki Krogerus > > Reviewed-by: Neil Armstrong > > Link: https://lore.kernel.org/r/20231025115620.905538-2-dmitry.baryshkov@linaro.org > > Signed-off-by: Bjorn Andersson > > Signed-off-by: Sasha Levin > > Correct me if I'm wrong Dmitry, but while the commit message makes this > sound like a fix, it is not needed unless you backport follow-on patches > that enable UCSI on these platforms. > > So this one can be dropped from all stable queues (unless you're > backporting patches that enable new features and that depend on this > one). Exactly. It didn't have the Fixes: tag. So I'm completely unsure why it ended up in the autosel queue at all. -- With best wishes Dmitry