Received-SPF: pass (google.com: domain of linux-kernel+bounces-28969-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20240110090107.26323-1-ppbuk5246@gmail.com> <21e77238-4884-40ca-bc01-b7e4774b9239@arm.com>
 <29a13c04-f669-a6c3-4693-af7e44469ad2@arm.com>
In-Reply-To: <29a13c04-f669-a6c3-4693-af7e44469ad2@arm.com>
From: Yun Levi <ppbuk5246@gmail.com>
Date: Wed, 17 Jan 2024 12:34:54 +0000
Message-ID: <CAM7-yPRSY7rz-GCWAS1yY75kD1FUjJTF=_AdCd0LtEhQa9dssg@mail.gmail.com>
Subject: Re: [PATCH] firmware/arm_sdei: Fix invalid argument to unregister
 private events.
To: James Morse <james.morse@arm.com>
Cc: Pierre Gondois <pierre.gondois@arm.com>, linux-arm-kernel@lists.infradead.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"

Hi James, Pierre.


> > I think you can also add:
> > Fixes: d2c48b2387eb ("firmware: arm_sdei: Fix sleep from invalid context BUG")

Thanks, I'll add this fix tag.

> >> diff --git a/drivers/firmware/arm_sdei.c b/drivers/firmware/arm_sdei.c
> >> index 285fe7ad490d..3e8051fe8296 100644
> >> --- a/drivers/firmware/arm_sdei.c
> >> +++ b/drivers/firmware/arm_sdei.c
> >> @@ -763,7 +763,7 @@ static int sdei_device_freeze(struct device *dev)
> >>       int err;
> >>         /* unregister private events */
> >> -    cpuhp_remove_state(sdei_entry_point);
> >> +    cpuhp_remove_state(sdei_hp_state);
> >
> > Maybe it would also be worth resetting 'sdei_hp_state':
> >   sdei_hp_state = 0;
>
> The next call should always be 'thaw', which doesn't check this, but it's good to cleanup
> stale values.
>
But, I think it should be checked on sdei_reboot_notifier.
otherwise, In the situation sdei device was freezed, when
sdei_reboot_notifier is called,
It would fail on cpuhp_cb_check too.

Should I add a sanity check on sdei_reboot_notifier in the next patch?

Many thanks!