Received-SPF: pass (google.com: domain of linux-kernel+bounces-28970-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <510441c7-5a64-aaee-cafc-69bef2570da5@quicinc.com>
Date: Wed, 17 Jan 2024 18:05:58 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v7 06/12] soc: qcom: Add Qualcomm APSS minidump kernel
 driver
To: Randy Dunlap <rdunlap@infradead.org>, <corbet@lwn.net>,
        <andersson@kernel.org>, <konrad.dybcio@linaro.org>,
        <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
        <conor+dt@kernel.org>, <keescook@chromium.org>, <tony.luck@intel.com>,
        <gpiccoli@igalia.com>, <mathieu.poirier@linaro.org>, <vigneshr@ti.com>,
        <nm@ti.com>, <matthias.bgg@gmail.com>, <kgene@kernel.org>,
        <alim.akhtar@samsung.com>, <bmasney@redhat.com>
CC: <linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20240109153200.12848-1-quic_mojha@quicinc.com>
 <20240109153200.12848-7-quic_mojha@quicinc.com>
 <63d9d1b9-6c2a-4d8a-9bf6-9973d76ae97d@infradead.org>
Content-Language: en-US
From: Mukesh Ojha <quic_mojha@quicinc.com>
In-Reply-To: <63d9d1b9-6c2a-4d8a-9bf6-9973d76ae97d@infradead.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit

Thanks for review.

On 1/10/2024 3:48 AM, Randy Dunlap wrote:
> Hi--
> 
> On 1/9/24 07:31, Mukesh Ojha wrote:
>> diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
>> index 1f81746131fc..56bc0c8a19f9 100644
>> --- a/drivers/soc/qcom/Kconfig
>> +++ b/drivers/soc/qcom/Kconfig
>> @@ -278,4 +278,17 @@ config QCOM_RPROC_MINIDUMP
>>   	  query predefined minidump segments associated with the remote processor
>>   	  and check its validity and end up collecting the dump on remote processor
>>   	  crash during its recovery.
>> +
>> +config QCOM_MINIDUMP
>> +	tristate "QCOM APSS Minidump driver"
>> +	depends on ARCH_QCOM || COMPILE_TEST
>> +	depends on QCOM_SMEM
>> +	help
>> +	  This config enables linux core infrastructure for Application
> 
> 	                      Linux
> same as 2 lines below.
> 
>> +	  processor subsystem (APSS) minidump collection i.e, it enables
> 
> 	                                      collection, i.e., it enables
> 
>> +	  Linux clients drivers to register their internal data structures
> 
> 	        client drivers
> 
>> +	  and debug messages as part of the apss minidump table and when
> 
> 	                                    APSS
> as above and in Subject.
> 
>> +	  the SoC is crashed, these selective regions will be dumped
> 
> 	          has
> 
>> +	  instead of the entire DDR dump. This saves significant amount
> 
> 	                                  This saves a significant amount
> 
> Does it have to be DDR?

Noted, all the above points, Yes DDR, I should perhaps use RAM like i
did it in the Doc.

-Mukesh

> 
> 
>> +	  of time and/or storage space.
>>   endmenu
>