Received: by 2002:a05:7412:8d1c:b0:fa:4c10:6cad with SMTP id bj28csp369895rdb; Wed, 17 Jan 2024 04:44:42 -0800 (PST) X-Google-Smtp-Source: AGHT+IHWon+79Gs8D8VSMcq8hVar3bDPrnp6a5WI0jryD5UZZz0x/a6PQl8xZ2gxiMRTSL3eJda0 X-Received: by 2002:a05:6402:2c5:b0:559:c43d:4196 with SMTP id b5-20020a05640202c500b00559c43d4196mr558349edx.76.1705495482362; Wed, 17 Jan 2024 04:44:42 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705495482; cv=pass; d=google.com; s=arc-20160816; b=X3dvUeyHV5Og4nhMHUd1zjetWrD6PB4NTsCx2B7dUkPaVq7MuXmY+02SmPiuM35i2o wFq9x9T0MkVybMq+9/yAM3Dv4GcWDYONIGJHfbjAOa/YxqcfgB4zSGDZsBkjmGyyNSsQ VDCBMjE9vLuI99Wvse7a7kZl89yzzGypkbA/H2XUD7h2sVEykOzB1+Woj6rMF8+OqnoH ExokPAweezh+Fcxs/TfW16yqb23AjtqOcscxwJvViWYStFT0JhVsC5zTvqIEN5nrIvac qHMpu8i2A3pIrBeCndFs1N2aw25Yqpgyitf6OEzHNAjQaLbyIp0LyxGzINBauJyUAVyy dwEg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date; bh=zZ6EAiL8jaMOUcXq73OQtvSnFs8bFLHvA5M45PiKxOs=; fh=rExBEuJGaHxgGUfSdpqfCcyL6VBYFv2Yor5YsJeCjZg=; b=rdr4JztVF/nXwWiLLqrR+9E47MWeQx81lJ2NML9VSozmtn/GnN+Ew8t32hWgSgWaki HU0Z8gr2r+ButgfNmmSFvgsAmm8EJ+4Ewvp3U9+NieRLuzIO3TCYvFzZUSI5Aq2Iblxs a7LQzR+SsI3IXhPsgmAsPkI1IbmmHJBKgQXgoCGLJN1l/Vm8uw/hohQ+H/S6fIufzuBP GuzJXl5WtBNU+L4pTaJhi1Da//HLAVnlhC+unWDPwVPN+PwaZXlfCiM4naqtPJECQfmr 7qx2SrSvS8urUl7FVSHbk7XPck3/9W+9Mh+DUi99T3v0qb17N97P97oad3kzAkMXNJuq tMig== ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=gnumonks.org); spf=pass (google.com: domain of linux-kernel+bounces-28977-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-28977-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id x71-20020a50bacd000000b00559bf5b2852si1108142ede.493.2024.01.17.04.44.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jan 2024 04:44:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-28977-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=gnumonks.org); spf=pass (google.com: domain of linux-kernel+bounces-28977-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-28977-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id DC9401F26261 for ; Wed, 17 Jan 2024 12:44:41 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1D4371EA7A; Wed, 17 Jan 2024 12:44:28 +0000 (UTC) Received: from ganesha.gnumonks.org (ganesha.gnumonks.org [213.95.27.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC6BE637; Wed, 17 Jan 2024 12:44:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.27.120 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705495467; cv=none; b=IV1tg02pN3ipAL6wHmPthXvUDYxKd3wuIUQb92VRn8ikdhBt4HhUaXTTQfIDVk92N7oTrfi3MsY2wdYdecElqbRbseSA8nkYm89HupfaUw8LGQ/Ou12oaAFY/nX9KdBLiuGGqmaz3KW9Y4C59uvzZsAhPU5z5tIouTuqSIvygM4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705495467; c=relaxed/simple; bh=KoXalv3CDMgZHjdkgvPU6xGKSYFCIOANzZIRheAObrg=; h=Received:Date:From:To:Cc:Subject:Message-ID:References: MIME-Version:Content-Type:Content-Disposition:In-Reply-To: X-Spam-Score; b=HX73OBww9I13jMvEnUf/t1T6wKe8wVAzQzGXQCJbm570rB9yHNA6Tinxz6/owf8/iT+Q0kCT9F1BDp76qoVmawHdd4FU/rJZRwxZDw7Y8eRNWJTyArwmEQkFvXtonZV3k4wUmhtesOxKv3JQwSQXWtAnwTZryMhcMtYpEoidxE4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=netfilter.org; spf=pass smtp.mailfrom=gnumonks.org; arc=none smtp.client-ip=213.95.27.120 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=netfilter.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gnumonks.org Received: from [78.30.41.52] (port=34296 helo=gnumonks.org) by ganesha.gnumonks.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rQ5HH-00DsEM-LJ; Wed, 17 Jan 2024 13:44:21 +0100 Date: Wed, 17 Jan 2024 13:44:18 +0100 From: Pablo Neira Ayuso To: Fedor Pchelkin Cc: Simon Horman , Julian Anastasov , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Dwip Banerjee , netdev@vger.kernel.org, lvs-devel@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, linux-kernel@vger.kernel.org, Alexey Khoroshilov , lvc-project@linuxtesting.org Subject: Re: [PATCH net] net: ipvs: avoid stat macros calls from preemptible context Message-ID: References: <20240115143923.31243-1-pchelkin@ispras.ru> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240115143923.31243-1-pchelkin@ispras.ru> X-Spam-Score: -1.9 (-) On Mon, Jan 15, 2024 at 05:39:22PM +0300, Fedor Pchelkin wrote: > Inside decrement_ttl() upon discovering that the packet ttl has exceeded, > __IP_INC_STATS and __IP6_INC_STATS macros can be called from preemptible > context having the following backtrace: > > check_preemption_disabled: 48 callbacks suppressed > BUG: using __this_cpu_add() in preemptible [00000000] code: curl/1177 > caller is decrement_ttl+0x217/0x830 Applied to nf.git, thanks