Received-SPF: pass (google.com: domain of linux-kernel+bounces-29083-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240117014541.8887-1-yaolu@kylinos.cn>
In-Reply-To: <20240117014541.8887-1-yaolu@kylinos.cn>
From: Paul Moore <paul@paul-moore.com>
Date: Wed, 17 Jan 2024 09:32:33 -0500
Message-ID: <CAHC9VhSs6bxXFCAhw7i5cN=iZtuG3-E8xDBRjyGsop=BrhbmSw@mail.gmail.com>
Subject: Re: [PATCH] lsm: Resolve compiling 'security.c' error
To: Lu Yao <yaolu@kylinos.cn>, linux-hardening@vger.kernel.org
Cc: jmorris@namei.org, serge@hallyn.com, linux-security-module@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Jan 16, 2024 at 8:46=E2=80=AFPM Lu Yao <yaolu@kylinos.cn> wrote:
>
> The following error log is displayed during the current compilation
>   > 'security/security.c:810:2: error: =E2=80=98memcpy=E2=80=99 offset 32=
 is
>   > out of the bounds [0, 0] [-Werror=3Darray-bounds]'
>
> GCC version is '10.3.0 (Ubuntu 10.3.0-1ubuntu1~18.04~1)'
>
> Signed-off-by: Lu Yao <yaolu@kylinos.cn>
> ---
>  security/security.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

I'm adding the linux-hardening folks to the to To: line as this has
now come up multiple times and my best guess is that this is an issue
with the struct_size() macro, compiler annotations, or something
similar and I suspect they are the experts in that area.  My
understanding is that using the struct_size() macro is preferable to
open coding the math, as this patch does, but if we have to do
something like this to silence the warnings, that's okay with me.

So linux-hardening folks, what do you say?

> diff --git a/security/security.c b/security/security.c
> index 0144a98d3712..37168f6bee25 100644
> --- a/security/security.c
> +++ b/security/security.c
> @@ -792,7 +792,7 @@ int lsm_fill_user_ctx(struct lsm_ctx __user *uctx, si=
ze_t *uctx_len,
>         size_t nctx_len;
>         int rc =3D 0;
>
> -       nctx_len =3D ALIGN(struct_size(nctx, ctx, val_len), sizeof(void *=
));
> +       nctx_len =3D ALIGN(sizeof(struct lsm_ctx) + val_len, sizeof(void =
*));
>         if (nctx_len > *uctx_len) {
>                 rc =3D -E2BIG;
>                 goto out;
> --
> 2.25.1

--=20
paul-moore.com