Received: by 2002:a05:7412:8d1c:b0:fa:4c10:6cad with SMTP id bj28csp437237rdb; Wed, 17 Jan 2024 06:40:29 -0800 (PST) X-Google-Smtp-Source: AGHT+IHkrg9eEodwKhfI9+Z/physZs4VhffZDErVMLqQqwtijoo90lZz050AHVz4x5EGkmKOBRqH X-Received: by 2002:a05:6214:f26:b0:680:d4c2:a5d1 with SMTP id iw6-20020a0562140f2600b00680d4c2a5d1mr12701868qvb.66.1705502429000; Wed, 17 Jan 2024 06:40:29 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705502428; cv=pass; d=google.com; s=arc-20160816; b=TNYY9gPCkD9nkjmzM+o5Iw0Y6E2VvSolsvvoyA/+G3CPzCMkPBXenRuamqs6zR7JGo I3arjkSvxWT1jw0qw+xNFK5xnHwdbZEeULgbV9SHIKMY43t9Rl9u52qIuFJelGwKWcnF 5FvBKR6hjNCB/sbYfS6K4PeK/ycwkaXVl4ecU7aciMxnejEawAGV+wiSOMaEj/3goKH+ 8u/OkvojfPWw+4AaoFvloTi4bz9lOqpFN5GExA1+KY+mW0AmdXLbNlbn/hF0XAVbHTCW U4VgqDVzp3+dQHuOw6p9LIeyJ+HyEF1l+ZMIBfPb7DsddWLOcOGPhN3kaXccKu5hLuJh 5GQg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date; bh=bTVdI825Tkl/OlYsGpiZED35R2B24kkizDdJnyf/b34=; fh=vNR81Wz4W85bFG6ProzQwDpiMICzG9eXe9CXy86Al6M=; b=FQ1X9PBH8kFW5Ng20pvYXt8Lv9rz5eS+aTH4ttAvKxyGqsWKww219Cqf6xpcDVX2dI yK7qHMUa/Bog52FyWCj41PTzd++etWwQIGEKqxRxB86M+wpR/CAd0SG4+W1LZqfFG4J9 4KKBGalOsDmIE8S/quaoeFne+hg7HEhOeHMiv1tL8kJPpoE8rjEYpiWRuo9K1C15mxcY oJW/rkB6XORZp+wBc6GzPM4Cg0rmfNjoOS76+N3nsUDXxomYaKoDHkOU+n2SGI2cU/RG pDquE4ARXnjcg/MoGc9zesVxU0oVffb5QrEIr5CLTShAZmvG9CDf7BEdSP8h6KWlyE/X MZLA== ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=lst.de); spf=pass (google.com: domain of linux-kernel+bounces-29088-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-29088-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id d10-20020a05621421ca00b00681807a9d23si739932qvh.124.2024.01.17.06.40.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jan 2024 06:40:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-29088-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=lst.de); spf=pass (google.com: domain of linux-kernel+bounces-29088-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-29088-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 47AB51C219D6 for ; Wed, 17 Jan 2024 14:40:12 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6C3E7208C8; Wed, 17 Jan 2024 14:40:07 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7579220334 for ; Wed, 17 Jan 2024 14:40:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705502407; cv=none; b=SCrynLLhcLoBez5tU9Vmu/zmy+ZBO1qjCSMOoSjOYR+Ow25Oa/T4dwQnXQ7+Deqnp3F5ejqocjpVnkecZE/u8ihKnoYpdvp+/orYDX3sbz2rVajkoIF9pJEHx7Yv4jwvWl0honr3F4twKTCZiJTu2HGN7ZvvHoB6iMgQzFzAGYw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705502407; c=relaxed/simple; bh=bTVdI825Tkl/OlYsGpiZED35R2B24kkizDdJnyf/b34=; h=Received:Date:From:To:Cc:Subject:Message-ID:References: MIME-Version:Content-Type:Content-Disposition:In-Reply-To: User-Agent; b=vEiXgLNFb6LThJaxfzFjR2Wr/CeqyPNHY9EGSUxur2JUMjwIb0fAYm8owNn5z+p0eIEGrFvbGbDvmGlATcs2YSBx2by7pH0IYHrUe0Vu9UY37uyPzRjrrMCUnLOS2onwiOlYOb5mP09r9p3DSMT/2hBPdS/l+da8nNh0Wu/zIPM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 36CD268CFE; Wed, 17 Jan 2024 15:39:52 +0100 (CET) Date: Wed, 17 Jan 2024 15:39:52 +0100 From: Christoph Hellwig To: Sagi Grimberg Cc: mengfanhui , kbusch@kernel.org, axboe@kernel.dk, hch@lst.de, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org Subject: Re: [PATCH] nvme-multipath: fix bogus request queue reference put Message-ID: <20240117143952.GA27918@lst.de> References: <20240117065043.79192-1-mengfanhui@kylinos.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) On Wed, Jan 17, 2024 at 04:04:12PM +0200, Sagi Grimberg wrote: > How did you see this? disk->queue is allocated in blk_alloc_disk called > in nvme_mpath_alloc_disk... I don't understand how you saw the same > dereference that was addressed by this commit. This looks like a backport of an old patch of yours to a geriatric kernel to me..