Received-SPF: pass (google.com: domain of linux-kernel+bounces-29141-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Wed, 17 Jan 2024 15:14:04 +0000
From: Conor Dooley <conor@kernel.org>
To: Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Lucas Stach <l.stach@pengutronix.de>, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] dt-bindings: interrupt-controller: fsl, irqsteer:
 Add power-domains
Message-ID: <20240117-deceptive-knapsack-ba9885f7b35e@spud>
References: <20240110094338.472304-1-alexander.stein@ew.tq-group.com>
 <9230083.CDJkKcVGEf@steina-w>
 <20240111-dullness-blooper-37644405c825@spud>
 <13433324.uLZWGnKmhe@steina-w>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="T3KERiiprjwKtIAN"
Content-Disposition: inline
In-Reply-To: <13433324.uLZWGnKmhe@steina-w>


--T3KERiiprjwKtIAN
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jan 17, 2024 at 08:31:26AM +0100, Alexander Stein wrote:
> Hi Conor,
>=20
> Am Donnerstag, 11. Januar 2024, 17:49:03 CET schrieb Conor Dooley:
> > On Thu, Jan 11, 2024 at 09:59:54AM +0100, Alexander Stein wrote:
> > > Hi Conor,
> > >=20
> > > Am Mittwoch, 10. Januar 2024, 17:09:07 CET schrieb Conor Dooley:
> > > > On Wed, Jan 10, 2024 at 10:43:38AM +0100, Alexander Stein wrote:
> > > > > Some SoC like i.MX8QXP use a power-domain for this IP add it to t=
he
> > > > > supported proerties. Fixes the dtbs_check warning:
> > > > > freescale/imx8qxp-tqma8xqp-mba8xx.dtb: irqsteer@56000000:
> > > > > 'power-domains'
> > > > >=20
> > > > >  does not match any of the regexes: 'pinctrl-[0-9]+'
> > > > >=20
> > > > > from schema $id:
> > > > > http://devicetree.org/schemas/interrupt-controller/fsl,irqsteer.y=
aml#
> > > > >=20
> > > > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > > > > ---
> > > > >=20
> > > > > Notes:
> > > > >     Please note that both the board dts and the DT node for irqst=
eer
> > > > >     being
> > > > >     used, are still work-in-progress.
> > > >=20
> > > > The binding doesn't even support the imx8qxp's irqsteer yet, I think
> > > > this should be added alongside support for that SoC. Am I missing
> > > > something?
> > >=20
> > > I'm not sure if any additional SoC support is actually needed. 'fsl,i=
mx-
> > > irqsteer' is available and that's what I use in my WiP. Also imx8mp a=
lso
> > > just uses the generic compatible. Only imx8mq uses 'fsl,imx8m-irqstee=
r'.
> > Why doesn't it used "imx8mq-irqsteer"? Should it not have its own
> > soc-specific compatible?
>=20
> I would assume that "fsl,imx8m-irqsteer" is for the whole i.MX8M family. =
I=20
> don't think a soc-specific compatible is needed at all. On top I can't se=
e any=20
> difference between i.MX8M and i.MX8/i.MX8X.
> If a soc-specific compatible is preferred, fine by me. But I don't expect=
 any=20
> difference despite imx8qxp/imx8qm requiring a power-domain.

Specific imx8mq compatibles exist for a wide range of peripherals, I'm
not sure why the irqsteer would be an exception.

Cheers,
Conor.

--T3KERiiprjwKtIAN
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZafuvAAKCRB4tDGHoIJi
0ulnAP0fdOE5875N8QKNp6ri57q+vfJtAe+TtOeYTqrY+JryVAD+JzfzSt8WyMx4
KJ1I3FC2Gdujite2qjcvvK5du14d0w0=
=Efw8
-----END PGP SIGNATURE-----

--T3KERiiprjwKtIAN--