Received-SPF: pass (google.com: domain of linux-kernel+bounces-29170-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: Petlozu Pravareshwar <petlozup@nvidia.com>
To: Rob Herring <robh@kernel.org>
CC: "thierry.reding@gmail.com" <thierry.reding@gmail.com>, Jonathan Hunter
	<jonathanh@nvidia.com>, "krzysztof.kozlowski+dt@linaro.org"
	<krzysztof.kozlowski+dt@linaro.org>, "conor+dt@kernel.org"
	<conor+dt@kernel.org>, "p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
	"dmitry.osipenko@collabora.com" <dmitry.osipenko@collabora.com>,
	"ulf.hansson@linaro.org" <ulf.hansson@linaro.org>, Kartik Rajput
	<kkartik@nvidia.com>, "cai.huoqing@linux.dev" <cai.huoqing@linux.dev>,
	Sandipan Patra <spatra@nvidia.com>, "linux-tegra@vger.kernel.org"
	<linux-tegra@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "devicetree@vger.kernel.org"
	<devicetree@vger.kernel.org>
Subject: RE: [PATCH 2/3] dt-bindings: tegra: pmc: Update scratch as an
 optional aperture
Thread-Topic: [PATCH 2/3] dt-bindings: tegra: pmc: Update scratch as an
 optional aperture
Thread-Index: AQHaQHVXi8lSHewdikO4T3WqC1nA87DQWU+AgA3dKoA=
Date: Wed, 17 Jan 2024 15:46:13 +0000
Message-ID:
 <IA0PR12MB8906AD9357DBB41BEDC08FA5B5722@IA0PR12MB8906.namprd12.prod.outlook.com>
References: <20240106075134.3933491-1-petlozup@nvidia.com>
 <20240106075134.3933491-2-petlozup@nvidia.com>
 <20240108195857.GA1959040-robh@kernel.org>
In-Reply-To: <20240108195857.GA1959040-robh@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?EqfdjmWEWVPDRTeaPdxyRW6xoa9LnAvke/D27i7WJt67ny1Wt7xBVj+RyDUr?=
 =?us-ascii?Q?LCNIoLsPMkB4GjBKnc9vQfFqEI33QjpB3W1Ocj8pqqT6aHCq6zJoAYG2k5kk?=
 =?us-ascii?Q?H3zg7oScLb94WCmjkI+C56itd8mnegpbNzxgOIHp+FAwbT6jjBdh80DQM9e/?=
 =?us-ascii?Q?Zrxpw3PJ5KFT3xMZENpU4mvsNgRhh1stEtRp3N1b5ueZ/+bZZtanlm8Uz/QH?=
 =?us-ascii?Q?B/GBuhSc9JxTLcxHLc3oM1LQol64LBmy2N7u1WCOgTSagPW/Gj16p6K8FRd6?=
 =?us-ascii?Q?BIeZUzVfmWYtWwGR+/jCoeJMnGQzoZalBQnVpucztDiUQrQA8Zr4Y10VKafr?=
 =?us-ascii?Q?uWtxypKnzlzAmWxGstGtj8A+f+YvTcdj5P3cBk5FnP1vySUbLb0RcnlemDsT?=
 =?us-ascii?Q?+5DVRwX8JCuV5Un4WqMxX8i+qt4eJjJb2CbyvyP3cY9KFvmdFiymSTSqAFZ7?=
 =?us-ascii?Q?Sj+cRsrCyfgNqg3d9NknL8DyTKEhXPkzkx+vgo1zNE5FN3gZORSrkg9s5ffd?=
 =?us-ascii?Q?gdC1XI2cueZSFmt8CAzQBg67SSQ1XMDdliX+Zzz7XJmK6NM2vbzAO+bCs7Jc?=
 =?us-ascii?Q?SCvhw8azGkt0buRr2LmdNVy3Wk00YnDx4GZMOKx5x1l3Gd4tjV3g5dAbToFl?=
 =?us-ascii?Q?YRfkbsAobRzXYa5IEoDlhKHkJXU3p2ujHqetZLhZgaL+0LeBIFZ1n5ftxc0g?=
 =?us-ascii?Q?EKzONcQNTF+n/EuIgaLXRZR1jsrbvj375u8wxzAhOBi9Raxwfzc+hD8p4UOQ?=
 =?us-ascii?Q?SlgQEwR1e+f4hIyTQuZXTd3Mgls672GROVEVGQ5bKAdttDzSN7/EflTA2vZi?=
 =?us-ascii?Q?YN4A6sNMbilbY36mxUiMkOhfzSim/gc8f3qVotz7R0ocNxhsJfkIXsm2N7aV?=
 =?us-ascii?Q?xNKvFh8BquJOTVTFyecdrKAUSg90cQaEt0lBtRD8nK4kBLlCsK9xvuLG6yC9?=
 =?us-ascii?Q?h0hILCW28/GUGIin77q/GYPepOI1c0roYHBdjRI1Zuas3AOxEoRkwS2YE+s5?=
 =?us-ascii?Q?rGSEYJZhjK59HhUST1buGGTmAHqeuLVlSqSIy/pO8VNNylVFrH2l27T/RZ7j?=
 =?us-ascii?Q?PWKrNCELl7BmqXJhmWzRKwAbcR+26PBMBDUpy9pWPx0//FOT84bYOELmwGKh?=
 =?us-ascii?Q?0tIEaULMH+7w0PeKNS0KRqR5M5NMM+tk6XRuedozYNs8chJCosg8DCBLfeVR?=
 =?us-ascii?Q?6o1xitHsUdoNfAafZie7SBj4q0nWxmEt1Dy2DpfsEBsUhRIOjCqOWhT25jze?=
 =?us-ascii?Q?pWo8KYTgz8rYvICH7LspWF03Qt8zqhhWzYWkcw6zAtgXtp7EcuKFp0BP/UqM?=
 =?us-ascii?Q?GnGvfAgZHVzX4GdODBSNGWQ1GVvS1MMmcYR1rXJiA+7QcBdj5rTh7ar0oPFl?=
 =?us-ascii?Q?wbCwhd6+KGNSfBUyyHgOpFuxqTpk24//Xip4Vr2rS9T1hcfKCkjax0fxzt09?=
 =?us-ascii?Q?zQydvjSLgL2WLgWqNzMYs2xd7yqdzuuWMFqV7e9xGNmES2Oq/zGshovXYyyb?=
 =?us-ascii?Q?f9ZBjEBlTFEvFT58otw9n8xXDD6LZIM2BSLxMlJOCwbEmHeHI5+R4qExhdmy?=
 =?us-ascii?Q?1n09D6+xCznERFO/HE1UHJhhq3khFN3meFzBexx7?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: IA0PR12MB8906.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 40fa9d2a-5c7b-4465-a9e4-08dc17736f6f
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jan 2024 15:46:13.7683
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: RXlD5+lz1zI/uCgnOlEN1qtPeiLb4pjPjTXu0FInS8IlMJQdgrsBCa0R87SGFEQvd2vkVsZBnPZH7mzJ6JwWpQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7198

> On Sat, Jan 06, 2024 at 07:51:33AM +0000, Petlozu Pravareshwar wrote:
> > Scratch address space register is used to store reboot reason. For
> > some Tegra234 systems, the scratch space is not available to store the
> > reboot reason. This is because scratch region on these systems is not
> > accessible by the kernel as restricted by the Hypervisor.
> > Such systems would delist scratch aperture from PMC DT node.
> >
> > Accordingly, this change makes "scratch" as an optional aperture for
> > Tegra234 in PMC dt-binding document.
> >
> > Signed-off-by: Petlozu Pravareshwar <petlozup@nvidia.com>
> > ---
> >  .../arm/tegra/nvidia,tegra186-pmc.yaml        | 83 +++++++++++++------
> >  1 file changed, 58 insertions(+), 25 deletions(-)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra186-
> pmc.yaml
> > b/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra186-
> pmc.yaml
> > index 0faa403f68c8..2716610a1a02 100644
> > ---
> > a/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra186-
> pmc.yaml
> > +++ b/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra186-
> pmc.
> > +++ yaml
> > @@ -23,12 +23,7 @@ properties:
> >
> >    reg-names:
> >      minItems: 4
> > -    items:
> > -      - const: pmc
> > -      - const: wake
> > -      - const: aotag
> > -      - const: scratch
> > -      - const: misc
> > +    maxItems: 5
>=20
> You can just make the 4th entry: enum: [ scratch, misc ]

Agree. I would address this in the next patch.
Thanks.

>=20
> >
> >    interrupt-controller: true
> >
> > @@ -41,25 +36,63 @@ properties:
> >      description: If present, inverts the PMU interrupt signal.
> >      $ref: /schemas/types.yaml#/definitions/flag
> >
> > -if:
> > -  properties:
> > -    compatible:
> > -      contains:
> > -        const: nvidia,tegra186-pmc
> > -then:
> > -  properties:
> > -    reg:
> > -      maxItems: 4
> > -
> > -    reg-names:
> > -      maxItems: 4
> > -else:
> > -  properties:
> > -    reg:
> > -      minItems: 5
> > -
> > -    reg-names:
> > -      minItems: 5
> > +allOf:
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            const: nvidia,tegra186-pmc
> > +    then:
> > +      properties:
> > +        reg:
> > +          maxItems: 4
> > +        reg-names:
> > +          items:
> > +            - const: pmc
> > +            - const: wake
> > +            - const: aotag
> > +            - const: scratch
> > +
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            const: nvidia,tegra194-pmc
> > +    then:
> > +      properties:
> > +        reg:
> > +          minItems: 5
> > +        reg-names:
> > +          items:
> > +            - const: pmc
> > +            - const: wake
> > +            - const: aotag
> > +            - const: scratch
> > +            - const: misc
> > +
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            const: nvidia,tegra234-pmc
> > +    then:
> > +      properties:
> > +        reg:
> > +          minItems: 4
> > +          maxItems: 5
> > +        reg-names:
> > +          anyOf:
> > +           - items:
> > +               - const: pmc
> > +               - const: wake
> > +               - const: aotag
> > +               - const: misc
> > +           - items:
> > +               - const: pmc
> > +               - const: wake
> > +               - const: aotag
> > +               - const: scratch
> > +               - const: misc
> >
> >  patternProperties:
> >    "^[a-z0-9]+-[a-z0-9]+$":
> > --
> > 2.17.1
> >