Received: by 2002:a05:7412:8d1c:b0:fa:4c10:6cad with SMTP id bj28csp502104rdb; Wed, 17 Jan 2024 08:22:48 -0800 (PST) X-Google-Smtp-Source: AGHT+IG4IzguVQf7t8+0m7UMMhqIg0G42ArNZF6kWnXvUDTFWDlCIuAJx/sgI36wu64QD892WZHN X-Received: by 2002:ac8:5846:0:b0:429:c771:5bd4 with SMTP id h6-20020ac85846000000b00429c7715bd4mr12655486qth.96.1705508568436; Wed, 17 Jan 2024 08:22:48 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705508568; cv=pass; d=google.com; s=arc-20160816; b=r8/aP+hNU2kpTcyXTwltZy+LCwmpcC3WyQE0tUGQ0aem0FyHsfduHvsU4DC7iotacB avtab5dEtpxnlJSi+DDN8saqvKKfOds6RxJLG3JveL0ox8tlq0OLoWELqEZAD4Kr0wZJ V1VsvO8iIwmBtzdl5GlpwbUbUPc17temEM8QJmRtp8n1Apc1tQxqy6aK6xtW5JS05jKM rArJDG9UNevJciBApEE1VP68dDf8bZk3upknWb5IX5+PzA2bzoZcVndA5EbauAM7lLYm WVjUdKSbkcfLceXlPBFPN5JTL2Qtme18f/2INDUW/PzwHx8MSFiwMmpDRDw1dAU4osQs kuVA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:date:content-transfer-encoding:content-id:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:subject:cc :references:in-reply-to:from:organization:dkim-signature; bh=flbXHwDCTp+j6stWsTGEWwJGNNEZkTEfymW8XvfG8QU=; fh=GrC4xzsotA313FtOnqfHkaXsCmIzDG4GZsCGJMnXrJM=; b=NCgoSlf/4A9HewMPWObCyo0qu8tLKEj72CrJAIzw+zS0m7kW50Gx6EXF+zS9Oo7D2q On0gfp9Zvop3D8WJ8dWsh9MIzdp5bVEAMK3dG49Kj+tdLC7iRndx5RhKwEVKPxZZyTu6 js/2D5CPkiO5j0E/Ba3fP+cMKWmpdPgIpjnaidSuhgGeFzijQ43sawySkerDVtJWLslN cuJCbh62fVDKVfvKKJlV8zDzXF6XkxAtWK9sB4kpqnxulDny68DripjDbGBj7c111Pam 8uxvjWDaGxpAAmO1FgpFlEdo7EMmM9h7j0oNj8EUr3XjaW4SztgpskwnvCAJcViZlIZr 4IxA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=KbkJjw+O; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-29207-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-29207-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id f6-20020ac85d06000000b004298a42d1fesi12690467qtx.661.2024.01.17.08.22.48 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jan 2024 08:22:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-29207-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=KbkJjw+O; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-29207-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-29207-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 356531C26835 for ; Wed, 17 Jan 2024 16:21:15 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6D43F2232D; Wed, 17 Jan 2024 16:21:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="KbkJjw+O" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47FB721114 for ; Wed, 17 Jan 2024 16:21:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705508468; cv=none; b=R/rnyrg4YykpVrlVMn8fQza+6UDquC3K/GKnLoMi4fyg/iv4FZYvoDgX+5VsOmg7hEDFj8OAoQjvhgAkX84HuNCaWw21TfrnABaOwIcnB6YXBUpuIqcFm7jMAXz3QqgopbI7M4IuvcTUTgEDJIhuUdgZ3Fs0Uj/m6ZJdLlrMtUw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705508468; c=relaxed/simple; bh=flbXHwDCTp+j6stWsTGEWwJGNNEZkTEfymW8XvfG8QU=; h=DKIM-Signature:Received:X-MC-Unique:Received:Received: Organization:From:In-Reply-To:References:Cc:Subject:MIME-Version: Content-Type:Content-ID:Content-Transfer-Encoding:Date:Message-ID: X-Scanned-By; b=TAtfX+yyUO+YwHvz4NaC7eM7wCtW7OU0Db1RgTqefENBoXnWZhnpIcLb4T7HO9VGc7nc7DTpkNlq88vp8Khf3+ToINRlmEZ+wsB2G8o4+ttACarXKMb7NAZBy5FfitLWULTv4EJb1Tr8SOg3xlo9+Hha+kHrT4Hrscv9oV81MRo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=KbkJjw+O; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1705508466; h=from:from:reply-to:subject:subject:date:date:message-id:message-id:to: cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=flbXHwDCTp+j6stWsTGEWwJGNNEZkTEfymW8XvfG8QU=; b=KbkJjw+O9NUpd2Y+fzNf47ID31HSoVyH8vNl4EQg7pw2ZBT/N35EDbGfJL3tzSH7DYdk0z PXwxhFLD9uXCRf6IPWC0Z0nlqIn327UQvF8kEMsChPgYrJIM53nom2fUnUFZe19xqVfEhH YvHYC8fl7KLmCT66qUCB0nfyIk31TsI= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-324-qCUP_KtoMCmRpnD6WO-2jA-1; Wed, 17 Jan 2024 11:21:04 -0500 X-MC-Unique: qCUP_KtoMCmRpnD6WO-2jA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C5AF038149AF; Wed, 17 Jan 2024 16:21:03 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.67]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2B2EF2026D6F; Wed, 17 Jan 2024 16:21:03 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <2929034.1705508082@warthog.procyon.org.uk> References: <2929034.1705508082@warthog.procyon.org.uk> Cc: dhowells@redhat.com, Marc Dionne , linux-afs@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] afs: Fix missing/incorrect unlocking of RCU read lock Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2929562.1705508462.1@warthog.procyon.org.uk> Content-Transfer-Encoding: quoted-printable Date: Wed, 17 Jan 2024 16:21:02 +0000 Message-ID: <2929563.1705508462@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 David Howells wrote: > In afs_proc_addr_prefs_show(), we need to unlock the RCU read lock in bo= th > places before returning (and not lock it again). > = > Fixes: f94f70d39cc2 ("afs: Provide a way to configure address priorities= ") > Reported-by: Marc Dionne Actually: Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-lkp/202401172243.cd53d5f6-oliver.sang@i= ntel.com > Signed-off-by: David Howells > cc: linux-afs@lists.infradead.org > cc: linux-fsdevel@vger.kernel.org David