Received-SPF: pass (google.com: domain of linux-kernel+bounces-29289-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <be06e4cf-2e36-4884-bcd0-5d5eb5f191cd@web.de>
Date: Wed, 17 Jan 2024 18:41:47 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: [PATCH 1/2] clk: versatile: clk-icst: Return directly after a failed
 kasprintf() call in of_syscon_icst_setup()
Content-Language: en-GB
From: Markus Elfring <Markus.Elfring@web.de>
To: linux-clk@vger.kernel.org, kernel-janitors@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org,
 Linus Walleij <linus.walleij@linaro.org>,
 Michael Turquette <mturquette@baylibre.com>, Rob Herring <robh@kernel.org>,
 Stephen Boyd <sboyd@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Kunwu Chan <chentao@kylinos.cn>
References: <061aef8b-a41f-4346-af6e-560c7594b27b@web.de>
In-Reply-To: <061aef8b-a41f-4346-af6e-560c7594b27b@web.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:MCdEgOisQlc=;2Ltz+7VFKKV6wYLiurTJ4Xz7xWp
 XO9AJ7SsFd+9QkXTVpbK8mq3fuepOOKScZduUT15kSykmD8mMVxZMdFtuozlKrhXaP+qcFsyJ
 SFF+IBo84eckhnSn3S0dwFiWh3apBdBNr/6e7zeDlUDZZY9hefWETc7h5kDaX3Is6yrbzOk0I
 bkmOzuSoRgxsZ6a/m1IIBR40/F9Pc81pAmrlQaJ2SUV+RLdaK7l8UIReGgN/+IUlk4P+gAPei
 rvm83OAjqA6Q7SvYb/iYD20Sl1x2z06FJe0ntHXth7tEUXB0Ozg8KOCGQcSeX6eEbzijwARSx
 z87SBGzgQXrJgmQj4y9rqahJIi2/IfHXQYnTQqrSH3YuHykxWks7vY13OEHhFvD8vGPPZacSl
 0vh4/BxR+h3Rg2NezAONCzdzD2h76e/POFYQxCL5rw7uefwZN/Q1nhHbx1+riCV3XhCT/IgSs
 z3Hf0qc5eLve/51Oxl9nyxnggaP4dLN9SArkHl3i7wybj7aMTlxpOaojQCxLGs2BH20fu5D/G
 eAKtq9EFkRWuoBjZQ+bbDoFgEhT8OiNnqv0p9ejUWGPpC7U8Dh58pNrpLJiLur4UA5id/Mw7T
 oKP7Mf/Vt93TN7hTMXKUDchonhdM+3mugMAQDLpS6N9w3gqQ8eeHYb2pLDXtTxo6xvmGx9GqU
 sPcpntjDKZEM/KvbCl1glNpHpLMl3MzRI+qVnWIgTQQTQnXnBAVvpFJyRVWc0RMM140CZ646H
 Ce/6bRuU9HGf6Aj8pAImgC5DA0+G07Zq2omhPrK9IfBeYAghvxUU2Ao782KBJgs0kKGCF6/U/
 jEo5EFT1Y/fM/BjCS8ejFX6yiC6eTnZNdxRq0Xf4ub07t7ptNgye90jItGqhLGZgA5lolXrSD
 PSJA2XzZF42SI6LXSJDoTW8pIAtqGrriVJmS5xjMp29Ftm0e1j70v0egG8CV+3DHnFJ7nFrC1
 dXVEtQ==

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 17 Jan 2024 18:06:55 +0100

The result from a call of the function =E2=80=9Ckasprintf=E2=80=9D was pas=
sed to
a subsequent function call without checking for a null pointer before
(according to a memory allocation failure).
This issue was detected by using the Coccinelle software.

Thus return directly after a failed kasprintf() call.

Fixes: 1b2189f3aa50b ("clk: versatile: clk-icst: Ensure clock names are un=
ique")
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
=2D--
 drivers/clk/versatile/clk-icst.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/versatile/clk-icst.c b/drivers/clk/versatile/clk-=
icst.c
index d5cb372f0901..c4cf50a48972 100644
=2D-- a/drivers/clk/versatile/clk-icst.c
+++ b/drivers/clk/versatile/clk-icst.c
@@ -537,10 +537,12 @@ static void __init of_syscon_icst_setup(struct devic=
e_node *np)
 		return;
 	}

-	/* Parent clock name is not the same as node parent */
-	parent_name =3D of_clk_get_parent_name(np, 0);
 	name =3D kasprintf(GFP_KERNEL, "%pOFP", np);
+	if (!name)
+		return;

+	/* Parent clock name is not the same as node parent */
+	parent_name =3D of_clk_get_parent_name(np, 0);
 	regclk =3D icst_clk_setup(NULL, &icst_desc, name, parent_name, map, ctyp=
e);
 	if (IS_ERR(regclk)) {
 		pr_err("error setting up syscon ICST clock %s\n", name);
=2D-
2.43.0