Received-SPF: pass (google.com: domain of linux-kernel+bounces-29301-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20240117141405.3063506-1-amitsinght@marvell.com> <20240117141405.3063506-14-amitsinght@marvell.com>
In-Reply-To: <20240117141405.3063506-14-amitsinght@marvell.com>
From: Peter Newman <peternewman@google.com>
Date: Wed, 17 Jan 2024 10:03:00 -0800
Message-ID: <CALPaoCjf_A5SOr8L+0WMePW02Pzj9nnPT0JLZ_+232vvfEzGCQ@mail.gmail.com>
Subject: Re: [PATCH v1 13/14] arm_mpam: Handle resource instances mapped to
 different controls
To: Amit Singh Tomar <amitsinght@marvell.com>
Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, 
	fenghua.yu@intel.com, reinette.chatre@intel.com, james.morse@arm.com, 
	gcherian@marvell.com, robh@kernel.org, dfustini@baylibre.com, 
	jonathan.cameron@huawei.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Amit,

On Wed, Jan 17, 2024 at 6:15=E2=80=AFAM Amit Singh Tomar <amitsinght@marvel=
l.com> wrote:

>
> +/* Club different resource properties under a class that resctrl uses,
> + * for instance, L3 cache that supports both CPOR, and DSPRI need to hav=
e
> + * knowledge of both cpbm_wd and dspri_wd. This is needed when two contr=
ols
> + * are enumerated under differnt RIS Index.
> + */
> +static void mpam_enable_club_class_features(struct mpam_class *class,
> +                                           struct mpam_msc_ris *ris)

It looks like "club" is used as a synonym to "class" here to evade the
bigger issue that mpam_classes are not defined correctly as DSPRI
resources should not be in the same mpam_class as the L3 CPOR and CSU
features.

This hardware makes it clear that the definition of mpam_class as all
resources in a (level x {memory,cache}) needs to be revised.

-Peter