Received-SPF: pass (google.com: domain of linux-kernel+bounces-29334-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <fad02d57-318c-4d66-92c9-3c8ceec6a743@intel.com>
Date: Wed, 17 Jan 2024 10:48:53 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 3/4] selftests/resctrl: Split
 validate_resctrl_feature_request()
Content-Language: en-US
To: =?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?= <maciej.wieczor-retman@intel.com>
CC: Fenghua Yu <fenghua.yu@intel.com>, Shuah Khan <shuah@kernel.org>,
	<ilpo.jarvinen@linux.intel.com>, <linux-kernel@vger.kernel.org>,
	<linux-kselftest@vger.kernel.org>
References: <cover.1702392177.git.maciej.wieczor-retman@intel.com>
 <d6442103165be849d32585e861fc2850f7c4e8ea.1702392177.git.maciej.wieczor-retman@intel.com>
 <64b6767a-201b-4c61-98e9-f01aa271dd33@intel.com>
 <2o7adr2cos6qcikcu7oop4ss7vib2n6ue33djgfeds3v6gj53f@uu45lomrp5qv>
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <2o7adr2cos6qcikcu7oop4ss7vib2n6ue33djgfeds3v6gj53f@uu45lomrp5qv>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?alNKaHA4YStUb09nbnJuWktnaU1tajdKL2k2MkRKc2xDRStGVThFSVJPRkVw?=
 =?utf-8?B?aTB3aEZZNURCMFNtQlhuSXFYZmpVdG94MVJBVTdCbkpJZ2U0ejJwTmZIOE9S?=
 =?utf-8?B?QlBScU04dlZ6VTZkdm1DdERkYnZ2Y2Y3ZzQwVzhpK1RXNVpic1d4SitpL3N6?=
 =?utf-8?B?bmpKSnVlZ1d4STMwblBaREpzREc4T1RwbEF6cGJMckJFcjZ5amVSOVIzOTRO?=
 =?utf-8?B?YnpxL2hsVlYvVmN4Y2FuRkZUSER1T3VENGZ3bzl3MXFxeGhhZjZDT2VKZkZP?=
 =?utf-8?B?ODVOM1RBV1NwWVM1bzJYMGNUZUE2ZGcrN25nblRQdlJIWHJVYjZ6dVBmOFhq?=
 =?utf-8?B?ZXNEM21pVzIwdWtCekEvdEVoK2hOcFU3TTA4QTNteFRvdmFHRGtUeDVnOVZy?=
 =?utf-8?B?bHh0OWVuaXRsc2VUYkZ5N2hxTHNHU1c0QmJaaU10VXM4a3RrUDFkOEhyUXJi?=
 =?utf-8?B?ZFAvUExTWEkyeWJQaXFlaWJ2NE1ndlpkak12Q1FibWJJWjArb3lzM0VydGEx?=
 =?utf-8?B?Y0wzUG9xQkprV3h2bEFFWW8zOUZKSnlIbDZ0UThOTVB6OFVDa2cyWHoxSTVr?=
 =?utf-8?B?RUR6NmhrRkszVitCWDJDRG5vWFdTTUpyV09oQWNqVHBsZmpNVWh1bHE1eWpK?=
 =?utf-8?B?U0oyQ2kybjRycWZlVDZMWkh4N1IwaG1VcGNJcGl2UVJvb1B6MjhOTjYvMHVW?=
 =?utf-8?B?ZnF2cFp5UGppOXlOajdid3VrU2RUdkQvMk4xRStPZU90bzJmcWhtUEVPVW52?=
 =?utf-8?B?dHBDVE4vOWhadVJDK3BLbGhWVVNBeEN4ZktrTmV6RVZLeXVabjNIRFVPWXJo?=
 =?utf-8?B?dnI1U3I0S2tHWW0waWlsRkYwZFYyZlg1YWJ1dnFmL2VYTnk3cmhCTnNMVWFX?=
 =?utf-8?B?MFlna2kvdHFjanJFVHBIeFc2T3VRQTdHaGp6OXdQVmFhcnBJK2dneVBLVzRS?=
 =?utf-8?B?NkRzNUs3bzlIRTFxU0J1di8xbWpUQitGb3czU0lKRHRNWWZYZE5wcnBkdjMv?=
 =?utf-8?B?SGJJTW41T0pGUi9LU0FTVE9YZnRRUFYrZ1RHZFFKZTZ0b3dlWXFOUWthUUJH?=
 =?utf-8?B?bFkxY2Z1ZzErcTUyNWF6cnZIZng4MHV4TTc1cnVwZk9Cd250KzB5di9MOEc5?=
 =?utf-8?B?OWlLTFdWeXVvSW4yMm9ZM0c1VGF1dnlJMXUrbUkyWnNETmViVlNwS0Zqemw1?=
 =?utf-8?B?RTExMWFDS081MnlwRjA1TzY4QVBVT1M4RnRlSTVvenlMMmJldDhpcjFmcVlq?=
 =?utf-8?B?a0gyTm9ldWZJZUQ5RkJCMTYzbWN6YVpWVS9oUXRXZ2JXK3lsbGd4TitSTFN0?=
 =?utf-8?B?Snhmd2JUVW9jRWxycjBpdzA1WUpkUnR1aDFOUDRJd0NoK2xMYW51WTJxVHcv?=
 =?utf-8?B?d0grRnVMSWN6d2lsQ1RsbVVuRnVoVS9pU0svbDFPU0t4SmMxM253UW5HeGZC?=
 =?utf-8?B?RlF5elpueVRvUU5IWWFLVG51ZHlmSSs0VWxnamVrZEVGbkZKT2h1Z2ZyTkhx?=
 =?utf-8?B?U2FXTWhHMm92djB6OUVMWERZZ0dLcUo3WER4VTNvM25hVFZWUXNPS256T2xC?=
 =?utf-8?B?UE83bTUzenowMHFpY1ZOYWxsVHgxWlBHN2d2SW5KdFdOeVl4Uy9tZnJLUHh3?=
 =?utf-8?B?a2V5Tlp6MWdxMnozZml3NVJXOEZtMlE3SVNrM0Jwek81RUIxa1UycmtyL3lx?=
 =?utf-8?B?eGlBS3Y4SjJGK0pCR1RGNGY3eWFKbEFHRnQ4TVBycSt0NkNhaEJuenZ5Rmc3?=
 =?utf-8?B?YXFaTkRSWlRzVHBCVmRNRlludTNjYkdxVGVBM2IxNWhMMFduS1RJcjN4V3Bi?=
 =?utf-8?B?K05EWkkreWE1MEREOTlER3MxY0ErSUd4b0VIUUVoSmYwWktnN2hvT3FybkFp?=
 =?utf-8?B?ck1DNGdMWEVsRC9DN2lmekwrdmZZa0k3OENOZ1FwUmNiVU1hYjZiTTlQL0xX?=
 =?utf-8?B?cU5MT2VISlZ3K1I4VXJ0dzEwZXJLNjlhQ2tKaW5KTG9tSExRWUdMQU41eW8y?=
 =?utf-8?B?R0VVcE5hSVJjZHhjS3Fua1d5YWtvSEpVZFJBQVNmdlFZUFc5YzF1QS8vVity?=
 =?utf-8?B?VjFUbEQ1YmlMcVNnend5ejBQNm5HMmoxTzF1Z1p2bUxRZSs4bzF6c3RzNm5E?=
 =?utf-8?B?eTVyVHIvR3NyNC9kU3FqdVBxOENXU1l2S1I3NlpMZzRlVVVuT3lsVmdjY0NQ?=
 =?utf-8?B?cEE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 09edf0d7-c482-4e43-9a95-08dc178cf4c6
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jan 2024 18:48:55.0862
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1dQ011wVoPap/PEwoiH4+YUwSKfmGkh6xVcc+pWxG3Gn795tysIutpbsrVAh/swSy0aJ+LPy4slyodjlPaI2mvn1aWtqWooBlRgh5JXBuTM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6994
X-OriginatorOrg: intel.com

Hi Maciej,

On 1/17/2024 1:49 AM, Maciej Wieczór-Retman wrote:
> On 2024-01-08 at 14:38:45 -0800, Reinette Chatre wrote:
>> On 12/12/2023 6:52 AM, Maciej Wieczor-Retman wrote:


>>> +
>>> +	snprintf(res_path, sizeof(res_path), "%s/%s/%s", INFO_PATH, resource,
>>> +		 feature);
>>> +
>>> +	if (stat(res_path, &statbuf))
>>> +		return false;
>>
>> I think it will be more robust to look at statbuf to learn if the file type
>> is correct and the file is actually readable.
> 
> Could that file be unreadable or of wrong type?

It should be readable and the correct type when all goes well. Hence the term
"more robust".

> 
> Also I thought that since read_info_res_file() opens and reads that file any
> errors should be handled there. Shouldn't this part of the test only return
> whether the file is there or not since that indicates if something is supported
> in the kernel?

ok.


Reinette