Received-SPF: pass (google.com: domain of linux-kernel+bounces-29337-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <9e390783-05c5-47fc-a0c6-b95e249fe691@web.de>
Date: Wed, 17 Jan 2024 19:50:36 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: Kunwu Chan <chentao@kylinos.cn>, freedreno@lists.freedesktop.org,
 dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
 kernel-janitors@vger.kernel.org, Abhinav Kumar <quic_abhinavk@quicinc.com>,
 Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
 Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@gmail.com>,
 Marijn Suijten <marijn.suijten@somainline.org>,
 Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>
Cc: LKML <linux-kernel@vger.kernel.org>
References: <20240116032732.65262-1-chentao@kylinos.cn>
Subject: Re: [PATCH] drm/msm/adreno: Add a null pointer check in
 zap_shader_load_mdt()
Content-Language: en-GB
From: Markus Elfring <Markus.Elfring@web.de>
In-Reply-To: <20240116032732.65262-1-chentao@kylinos.cn>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:Q1U7tOoGFmc=;2qAZd1fwJ89oCNw5xB+ACGuHRN9
 OlKyRbV/lW8xNgPDwaGaaxGOq1xyBe69U/YdbBszFpCd3SNB9TqgA/eRUInsblCqA244SAUwt
 XPNu/4Xx5qHdunhEctjDVNdVJA/19AYCGlFXQfFiiJZXkB1z5OAXgl5Q0HfKubuhiVBWhL5A3
 +h8/JrGtj5aC0e7GXiXugiNJb6dWDYhaQQt1sJli1cItKY+kxxTaW7ToMzAba4+Hil7A6+cfz
 D3sYWSMde3F/uwa9X7YTHqqOFPzPzueWYJAVr3JnEd0h5yZh8QbdJemPvDxTXUUosrMuZENl1
 c1SxV9ztyPweI/zHprQ3rmZkXe9XjmrpvBYjMXhTxmLy2C0rGqA8ZAY+SrkEGuHxX/fR3pn7a
 Xk5QeesXmU0HgARQW7tsmJDstjvsJk2drLqeevRvX/Vx3Nrwf0Naq7rFR9CKIePee5qNVcieA
 h0xRtXgNKoMHNDmdYMTSp1bgZ6q/u3A1qR4+Edb8+et5vnAaHJhZEYxWKhwuAIlwcPAofi1D+
 rMkWsMW9nGd0U5Es3VGKeareSOnaM4GFHxQ/vzBsqVJUEsHEIHLKPU7K56BAnuojyUuyHCAtx
 KudzjxGpnS7Q+DJucVZKTokP52rozOXWY5SnWzH8GvC7cX1rwL7gBwyLSALGENnk4wTIsWya/
 cw+RG1/ZfLFYab8y+IgTWliHeMYDZfAcktCopcAUileHyE6PDJAIYYccTPxtx3r89YqLnAwrc
 yoeasqhXoAHRUGf1/xa4LcYacHEE7Wv8A+zkleHpfMJEHanb9hkDHMx5Un8XcXtRk19iaSUhZ
 QwERQcA7O8I2ol5pYwVRdBDhLungdrRqD3+ZNwW8iT13Nb8SWthxRRCr82wbIxrqwEZ2qlX+9
 GwcNwQUDOQO5k5ZTZapRo02I9RttueCCWvSGF8U6XM5I5fzRFwo3aZZ9k3u4NWJus9NYgQspw
 PABCvw==

> kasprintf() returns a pointer to dynamically allocated memory
> which can be NULL upon failure. Ensure the allocation was successful
> by checking the pointer validity.
=E2=80=A6
> +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c
> @@ -144,6 +144,10 @@ static int zap_shader_load_mdt(struct msm_gpu *gpu,=
 const char *fwname,
>  		char *newname;
>
>  		newname =3D kasprintf(GFP_KERNEL, "qcom/%s", fwname);
> +		if (!newname) {
> +			ret =3D -ENOMEM;
> +			goto out;
> +		}
=E2=80=A6

How do you think about to avoid the repetition of the pointer check
for the variable =E2=80=9Cmem_region=E2=80=9D?
Can the usage of other labels become more appropriate?

Regards,
Markus