Received-SPF: pass (google.com: domain of linux-kernel+bounces-29375-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
To: Su Hui <suhui@nfschina.com>
Cc: artur.paszkiewicz@intel.com, jejb@linux.ibm.com,
        martin.petersen@oracle.com, nathan@kernel.org, ndesaulniers@google.com,
        morbo@google.com, justinstitt@google.com, dan.j.williams@intel.com,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        llvm@lists.linux.dev, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] scsi: isci: request: Fix an error code problem in
 isci_io_request_build
From: "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1cytz3fuu.fsf@ca-mkp.ca.oracle.com>
References: <20240112041926.3924315-1-suhui@nfschina.com>
Date: Wed, 17 Jan 2024 14:44:41 -0500
In-Reply-To: <20240112041926.3924315-1-suhui@nfschina.com> (Su Hui's message
	of "Fri, 12 Jan 2024 12:19:27 +0800")
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?0Ax9kTIiHLWBsLjIj20qeQTXi7JF43jsnTT/srPtZBvvUJ+t7Bz+ee9mHmPd?=
 =?us-ascii?Q?V94Jh3r1UHMZ1JCtzBIEGgmEjRbgzGNijIQVgYA9MlHt9/UqU7gSj8SGAHfW?=
 =?us-ascii?Q?0ev7dd8sPEk7h945+sk89rdsKsVKF2poZp02Jxfk6Sro5vOuXb85M9lxGUkk?=
 =?us-ascii?Q?zImcmdV9ZWgaYVKlGNIH8kTJHZ8ltNNqLQLerJ5gkU9uiNbhUEi+Be5xw3z/?=
 =?us-ascii?Q?h4OFg3HYEy4N0YAAJYNYgVfeVgVjyXvRbU7AqDvooysNTceUWFsZSATyAiIl?=
 =?us-ascii?Q?u6Z0t0ew0/iokRS2mEuECjChhwCQ0FqEwvRrV9raQpNshpn9oSs24sdmdwc3?=
 =?us-ascii?Q?Qdq/rXjwfbwc0Z4lycIaaceHOFpyhyhvDl/dJQRsgIFXkJm9ta6+VNVsoFAS?=
 =?us-ascii?Q?jB3G2lf6J+DZDpgVbBie0Iw1/z1KImKKGMniUW18jpLWjVFPwkhKTBgFsO+a?=
 =?us-ascii?Q?MAVSpvQaHCoRQtRIcO1M3whJMoYQcwrluHkUP5eTS36UwslIP+Ug+vsWK09w?=
 =?us-ascii?Q?0tkLzV6O6Eu/utFW+19VW3IMuhm7rzbBGqpuZD2JEQPlqXxCER+IEOoU1Rvp?=
 =?us-ascii?Q?52rLC2lcz4TsCbLsOg/CdaXwOyvoKp92QJN7jAE0+0kGZzZr0L1P//59/Lp2?=
 =?us-ascii?Q?fmTE/XxvSvEj4u+gchV+wE7PAyJq9/MoAxkCSOzmFaJEZ3miPCyjkKuVyYb+?=
 =?us-ascii?Q?u09f1yBb8IAXQ1mYouyDkacWyHsGrwbuVJK9AHnl9/U7F58F/e0hgdi3Zk3i?=
 =?us-ascii?Q?tVwDUqc3K9b7qNEyyqkBEGF3jtLW6Vlg4XxE2ntnOX0V1LJoYxEG9GXlxl2v?=
 =?us-ascii?Q?jvhs4yMsERnzVe6Jub3jQfV+yOHGWQtUcG+444ZLwGqYKlnUWNsiBeV/QdwU?=
 =?us-ascii?Q?wy1jo4Wp4yynEMfQXiqqMObEvWMpOZg8IWf7Pm9P87eX6UU4HiWwkNSdcT9x?=
 =?us-ascii?Q?isD5tzlWJ7s36JE+U9hUjJtrTEH+IkWB29AOKHaoPj94YZvdb3myOMZKb2J9?=
 =?us-ascii?Q?Brvrii3HYnMqmGmBlAAYvYEnFNqzqqQYiQIphtag+Q7UtzCWbkyHrAHyU1zG?=
 =?us-ascii?Q?khQLcT6elcUOyEMFMLQ4ozU2+VVbHVQQoLO4fiCjT8Dvb5q6qFS0rMkbYypR?=
 =?us-ascii?Q?TmDRotkx74ASJzUJPkDl2IqxMExDWZvb1DYEOc3FNP3OCgzOvrvLMeUrL6Tg?=
 =?us-ascii?Q?Sq9WoYTK7NJPm6ZDCOr9ogjfk24C1EMaQVNldushuEX6jMSMh7Wk46TIYV23?=
 =?us-ascii?Q?/fywi1K2/k4H1AO1aE7pPvt30tZOui9tn53dvDVO4khutNFQwnxPEVJVrvF6?=
 =?us-ascii?Q?tg61w8Y1fKdSbk6d/PSBW/XcQt1jscvU4xPQkd+/fBkUwbGvIJVxiaHikPiA?=
 =?us-ascii?Q?jRBEV35G5NCOELtTQedWnPDVNZ06PFmehBtYoyr/mgcT66zRIxMntH+nYiGf?=
 =?us-ascii?Q?8/RoC+PUmsICLtJ2uhHkEe6EH5zCrKtGCivvGVeB9/kGbGtzJIW2klnNUWcu?=
 =?us-ascii?Q?MSzMPOiW+R7970V5YirAO0YUYF7D8bIHE/oMI3Zs0zrFvPJMNuv3CQuz1SVY?=
 =?us-ascii?Q?hZu8kimJtG9sxct2IfZQDCCaZ3cC4kmLhEj/aQ39Zon+WHv7NjzzNajaQTLZ?=
 =?us-ascii?Q?jA=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	x+hlYoQgk9X0zHeYQYHEnDf3HGJDiczD4v+ALPX5+ysGJekXCcy49pVtQ/pfBLV4wJ2SH7Hlhyu6jAdZMdYG3W/5MDkK9uZyNpICbkSDjIHnBaCj7RcSmBGEHqbkqdR4HWUySa8/GPFrDfxiMzUrKEW190W0dkypCnFYlvo/Rrrix8wnBCNMg0gelEC+UKzVV1UEjsq+TZps41r2e9cCPq/EXBzVDj3oVE2iB6aEFTDJDEiOl2+yDM1rem3mT45cxskDhf47R6xq/06qAOExVnaX07m6unOCMMLpCJ6Quz6CiXIuZ3FdYa+YTJCptd9W3Y0x+9iMZOvV+4shGdNK0uO7+npmgzfEVAly0fCcCEX5w/YQzaMQlyqegKuiCJDu08lM20/yoiOW6a3DFRWllOlc+NySwep6d0Xm+XzdUNHLoxF/LeKQvc8MNyn5mjGHSfoYU4ygBvCHV2fRtNdAH0Ui1uFX67AMzzp0SIO0wnugXgIA4RfIjUIcDsOuKkj/UflzB+D959o0Jsu6JBqQTGJ0nGwKurJ0Ym3sBZylIzV0nLo0bYDzUgPPuTRukxGfg8Ppk8/zqmcwTq5LX87C0DkuOmNYkWmRlYpRJev5zxg=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 37711451-503a-41c6-ba29-08dc1794c0e2
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jan 2024 19:44:43.9551
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pjQd4pWx1o4mRfsvv3dKjB8c8wMsYjcswS9bd1Dur/nhSzzUzbPwGqjla0yssWHVEnN8Vq6oQQGoQaU35NYMy3DxNarhe8yGPE/SN5A3M80=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR10MB7990
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-01-17_12,2024-01-17_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 adultscore=0 phishscore=0
 mlxlogscore=612 suspectscore=0 bulkscore=0 mlxscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2401170143
X-Proofpoint-GUID: Wm4QWvMKGZqU5Ggq8maw0tOkefZLXiSe
X-Proofpoint-ORIG-GUID: Wm4QWvMKGZqU5Ggq8maw0tOkefZLXiSe


> Clang static complains that Value stored to 'status' is never read.
> Return 'status' rather than 'SCI_SUCCESS'.

Applied to 6.8/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering