Received: by 2002:a05:7412:8d1c:b0:fa:4c10:6cad with SMTP id bj28csp627301rdb; Wed, 17 Jan 2024 12:10:44 -0800 (PST) X-Google-Smtp-Source: AGHT+IEp4Y/1w+3yhIIZWgXmfFiIf9/3T2W8x/aOvxZOT3x17Ir2nPlM55EzB60OJ3STBFOaRf6O X-Received: by 2002:a17:906:f59c:b0:a23:35d2:cf97 with SMTP id cm28-20020a170906f59c00b00a2335d2cf97mr5637352ejd.64.1705522244028; Wed, 17 Jan 2024 12:10:44 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705522244; cv=pass; d=google.com; s=arc-20160816; b=bwAnkc13EdlnGFQyd75KX1AOGEj7E4BjKT3uzqqgO6l94gXG+dSJCWyKjC7D9WTQ6u 2o9PEQT+LWQRKTgfktM6EPEeoRCfYj3WdwCYAckh3LY7XPCnPWCqHXpVnT5Fkc0jF1LR YZH84+tqY5beVX1O+MHWWr8YqniPNTAKl2uZfRc6nSdxjOW+694qLld5OSiI8JDyHKS1 zHhSfl5f/2UPgo/s+7Y9zIZsa6yscwvZIRdScQC9fwBR0nsLPE/G4FB2vJLfKLE8GYkS 3X1EyrIUcvj/OiXti2yk1IZ0zlRWsgdU/m2UGpSuWboVMPHecokhzRLKfsSwX56yBk4n i2hA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=1zjVlsCpmMyOvWsQhON2/QjBIUYtMmVfKY/1cWTuImM=; fh=kuN6UX0/7bll+fSVppKDX5efUoi0JvST+WJPmq9h7/w=; b=y7P6AlmJxG0Slf//90pNV2d/rvB/jMPBLmpPC4HRX5zs6tNvBsfI/QP7ZZZw9Y3zkH PlhHwfYV99c18cmaH3TZR/ns/2wf9XoIo5zOix+dodp1lqMmekpR1JmYpP1pr07UwodC ATFC9OGFhBuxZSGyALewYgJrolNAEP6JWUsH56r+R20v8WOm4DCwC2LB2vgMeljoshIV lJyUBxo72UN0PAhRkIgWtk4ie+x2Etrg+Qlx2WQlpfjOWTFRr0cZ5ZgJdfBkU5GhLcW5 8Y+mncgw2HdlUfs56RBEUTbIiLcZ9+1yGe5Vn+XZcWrGacqdp0w5P5EY1U1G3W+47hHV QVYg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2023-11-20 header.b=U6AmF3tN; arc=pass (i=1 spf=pass spfdomain=oracle.com dkim=pass dkdomain=oracle.com dmarc=pass fromdomain=oracle.com); spf=pass (google.com: domain of linux-kernel+bounces-29401-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-29401-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id s8-20020a170906354800b00a27941f3075si5971156eja.343.2024.01.17.12.10.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jan 2024 12:10:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-29401-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2023-11-20 header.b=U6AmF3tN; arc=pass (i=1 spf=pass spfdomain=oracle.com dkim=pass dkdomain=oracle.com dmarc=pass fromdomain=oracle.com); spf=pass (google.com: domain of linux-kernel+bounces-29401-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-29401-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id C3C971F23477 for ; Wed, 17 Jan 2024 20:10:43 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C7A9924B46; Wed, 17 Jan 2024 20:10:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="U6AmF3tN" Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA25724B20; Wed, 17 Jan 2024 20:10:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.177.32 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705522225; cv=none; b=SCnwy7ZnAJN+BEDwRz4JlZ8+o7NDajyeTuhktGH/Xf5T1J4RfbENcOQNeYUuVFjrR/wdtuwlklxlf06LMB1XCtYL91oHOeZhjn5zuodaW4+SnGbM3pxuJVcCFSzhauFeaArVIAR93V6sZm7q3vS3vNU8/D743MIczkR0y8yc1oM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705522225; c=relaxed/simple; bh=SF5JQcvnVmt4Tnjms+Ejj9mC3MVPiWRTIEHklx99jCM=; h=Received:DKIM-Signature:Received:Received:Received:Received: Received:From:To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To: References:MIME-Version:Content-Type:Content-Transfer-Encoding: X-Proofpoint-Virus-Version:X-Proofpoint-Spam-Details: X-Proofpoint-GUID:X-Proofpoint-ORIG-GUID; b=ML4EUwHUKNmatzjvtYMGWzxkXJukADByBXZigqiMeVix0uQz9yhmhl+Vkqgt4Eq+tYPf9ysRGa7SPaezl1rHW6lzZZDAP4DpU+ox+tzC7Fsm5pmgY/2OWYAEj5w92P3Mh7+b4PPqQR2Kmb57S/X7DLovliYvE4V3A2aIsHmYoxE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=U6AmF3tN; arc=none smtp.client-ip=205.220.177.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 40HJciOd003038; Wed, 17 Jan 2024 20:10:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=corp-2023-11-20; bh=1zjVlsCpmMyOvWsQhON2/QjBIUYtMmVfKY/1cWTuImM=; b=U6AmF3tNLEAe/mOB8EC4WNa+ZqZezuSHCr1bLGBTnBcNUdzXrWxBMXJ2lgPKfOersF85 VPUBIZHKYovwD2eRcB1ddVeTe6+o35V8eSgOE15H8ckHDW1zuEnu5hSTRNyMk0vvhBbH EHcRWeSBwsitybNhR72N98tUuPcb2PA/78kjb1SzWA1G2q4j1/ue3WOVamE3JkC4ATZn Y9Imx3vB+hU9bPdrwLtgL5orJAWAL6aFj8jp8GSc0jZQiBs45fXNh2Z1bgLvHKbjdhpf c9/4t8fDfu2P/Swha5B3P6iybZUM1e25x/Rwx7EgdIGDt3aNY0aYFnxN+qpLeeksP3to EA== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3vkm2hrqt5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 17 Jan 2024 20:10:19 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 40HIsM84020000; Wed, 17 Jan 2024 20:10:18 GMT Received: from pps.reinject (localhost [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3vkgyb1byg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 17 Jan 2024 20:10:18 +0000 Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 40HKAHCB030718; Wed, 17 Jan 2024 20:10:17 GMT Received: from ca-mkp2.ca.oracle.com.com (mpeterse-ol9.allregionaliads.osdevelopmeniad.oraclevcn.com [100.100.251.135]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTP id 3vkgyb1bw6-1; Wed, 17 Jan 2024 20:10:17 +0000 From: "Martin K. Petersen" To: Karan Tilak Kumar , Dan Carpenter Cc: "Martin K . Petersen" , Satish Kharat , Sesidhar Baddela , "James E.J. Bottomley" , Arulprabhu Ponnusamy , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] scsi: fnic: unlock on error path in fnic_queuecommand() Date: Wed, 17 Jan 2024 15:10:05 -0500 Message-ID: <170552035092.3348001.1586940422453299571.b4-ty@oracle.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <5360fa20-74bc-4c22-a78e-ea8b18c5410d@moroto.mountain> References: <5360fa20-74bc-4c22-a78e-ea8b18c5410d@moroto.mountain> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-17_12,2024-01-17_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 suspectscore=0 bulkscore=0 spamscore=0 mlxlogscore=647 phishscore=0 malwarescore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2401170147 X-Proofpoint-GUID: jO8xc34yIqNE87m8hJLI73MQUrJeXS2O X-Proofpoint-ORIG-GUID: jO8xc34yIqNE87m8hJLI73MQUrJeXS2O On Wed, 10 Jan 2024 21:41:55 +0300, Dan Carpenter wrote: > Call spin_unlock_irqrestore(&fnic->wq_copy_lock[hwq], flags) before > returning. > > Applied to 6.8/scsi-queue, thanks! [1/1] scsi: fnic: unlock on error path in fnic_queuecommand() https://git.kernel.org/mkp/scsi/c/38945c2b006b -- Martin K. Petersen Oracle Linux Engineering