Received-SPF: pass (google.com: domain of linux-kernel+bounces-29408-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Wed, 17 Jan 2024 12:20:13 -0800
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Luc Van Oostenryck <lucvoo@kernel.org>
Cc: Dan Carpenter <dan.carpenter@linaro.org>,
	Luc Van Oostenryck <luc.vanoostenryck@gmail.com>,
	linux-sparse@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] parse: handle __cleanup__ attribute
Message-ID: <Zag2fYsyJDtDR7a6@google.com>
References: <8d596a06-9f25-4d9f-8282-deb2d03a6b0a@moroto.mountain>
 <i4s2gnr6rlq3yhmfiy7lkbsahnaioilksvmx3eocdjfh2434zo@zhxhwwgqpxt2>
 <44e22df1-734e-49c5-b20b-4f4cdbce24a6@suswa.mountain>
 <75ee8bd3-aa80-46dc-9f0c-874a8f4e9d48@suswa.mountain>
 <k6ztyjq24ik24qtsu3aqpipodzgq37i2ko42ag7wzn4t2ryrzf@i4gbxu7kvslt>
 <c3884893-44fe-4622-8e8e-576a0bdff19f@suswa.mountain>
 <troz4beymvsw2m4y4ocghwiidohi4nbj45ry2tfmbekanu2ray@ooravawiynxr>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <troz4beymvsw2m4y4ocghwiidohi4nbj45ry2tfmbekanu2ray@ooravawiynxr>

Hi,

On Mon, Dec 18, 2023 at 02:51:32PM +0100, Luc Van Oostenryck wrote:
> On Thu, Dec 14, 2023 at 04:20:20PM +0300, Dan Carpenter wrote:
> > Yep.  Perfect.  Thanks so much!
> 
> Pushed now.

Any chance someone is looking at making context tracking working for
code annotated as __cleanup? We already have a bunch of code using
constructs like:

	...
	guard(spinlock_irqsave)(&gpio_lock);

	if (!test_bit(FLAG_REQUESTED, &desc->flags))
		return NULL;
	...

which resuls in:

$ make C=1 W=1 drivers/gpio/gpiolib.o
  CALL    scripts/checksyscalls.sh
  DESCEND objtool
  INSTALL libsubcmd_headers
  CC      drivers/gpio/gpiolib.o
  CHECK   drivers/gpio/gpiolib.c
drivers/gpio/gpiolib.c:2359:6: warning: context imbalance in 'gpiochip_dup_line_label' - different lock contexts for basic block

and I expect we'll see more and more of this.

Thanks.

-- 
Dmitry