Received-SPF: pass (google.com: domain of linux-kernel+bounces-29410-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <644f44ad-7e2b-4a1a-bbd7-ccc79d479242@web.de>
Date: Wed, 17 Jan 2024 21:24:12 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: linux-hardening@vger.kernel.org, kernel-janitors@vger.kernel.org,
 "Guilherme G. Piccoli" <gpiccoli@igalia.com>,
 Joel Fernandes <joel@joelfernandes.org>, Kees Cook <keescook@chromium.org>,
 Tony Luck <tony.luck@intel.com>
Content-Language: en-GB
Cc: LKML <linux-kernel@vger.kernel.org>, =?UTF-8?B?R8O8bnRlciBSw7Zjaw==?=
 <groeck@chromium.org>, Sai Prakash Ranjan
 <saiprakash.ranjan@codeaurora.org>, Kunwu Chan <chentao@kylinos.cn>
From: Markus Elfring <Markus.Elfring@web.de>
Subject: [PATCH] pstore/ram: Return directly after a failed kasprintf() call
 in ramoops_init_prz()
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:7a0FsOiFKps=;AujlA2bNA0FLb56dO9Arnk6Ehd/
 H52E4uHbwT1X6t+TIPDTZM5jukyM/UEl2kRsA9PzQRREhezlkIdEz+H7TPDIoa9ZzaGkKzSsx
 H1WSDFOWmFd+pgNgdLRoSdT1gqTSeXXUJednLL5/hK2CRaycpL7Llvqjcq6HQ7JtqiZJCFln4
 ef/dMVE9JF+UbaHdJlk/y+mq5F4hEu7I6Fvqv+//ZCAuVJpqxjzB+2aem5ReGFLpWvxcgl7HP
 HkQIAgt+K31oLrIPApIZX/9K6il6s6e6oSTgu1GCuZrftKQqqbBdyMjhOswZcIUIf2P2n0fUN
 sAAIA4e/XYDK4DAH9MD8spSnrcCltumApGI1s0CEkgmFqyAY3VM6JHoC6HRqvNuGXEItIHNMW
 Kvk215OnIUsMO2rHPiEP/GlBfWcjVSdA5gyw1oxHVbMCHM7+33TqGhVVtSfsjnBZbwlUIQHUC
 162ItZnfXSZNjbkYNZDdgu1U94JHF2QXY1Dcz9E9HCkv9CpPLwQAH5nKXUWvWxt2Bdzkx/40K
 GxI9REFPSmkzKxaMQgLQxfN9IeSDg+KugdaN6IAOeSvi1Nw5uepufdSLPPzqyIct3m/ysnC9V
 n6IEnJuzzQ3yvD/SK72NCWa32Ub2ntytgKWVVHNTJJ3cjfeNY0iqPle9qrKpIwzSCoFuNSDmj
 GOifNyEPupeVUfVVPYj7KGRjJk/PC7n6yvGV2pGPDQlRjwxU4wRzb6q9pPQF+xjtytJmsSzMQ
 lMg67Q3/WXEc12Bre5JN+3RZlwyaJkb1fWs7+iwA4ZTp0exTPzKcGYTYDM+VxPXMr83i+TTbt
 1y00b0pt71yxE6Vc6n3Ji1RpVuy/0SWaSiJazkRVwHqw+7Elh3MoKSqhdqZsz5qXRON0yaERG
 BkAEOfbp3v2ae0ZOuS8I4VGXHg4JlH1BC7GxSeTPIv55SsP74N0oSmce8SiikCdtW5pBmqc8d
 +c1z0XMx0X6pPuRtGnYnbjyaGuc=

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 17 Jan 2024 21:09:22 +0100

The result from a call of the function =E2=80=9Ckasprintf=E2=80=9D was pas=
sed to
a subsequent function call without checking for a null pointer before
(according to a memory allocation failure).
This issue was detected by using the Coccinelle software.

Thus return directly after a failed kasprintf() call.

Fixes: 1227daa43bce1 ("pstore/ram: Clarify resource reservation labels")
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
=2D--
 fs/pstore/ram.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c
index 88b34fdbf759..1a673a4af17c 100644
=2D-- a/fs/pstore/ram.c
+++ b/fs/pstore/ram.c
@@ -595,6 +595,9 @@ static int ramoops_init_prz(const char *name,
 	}

 	label =3D kasprintf(GFP_KERNEL, "ramoops:%s", name);
+	if (!label)
+		return -ENOMEM;
+
 	*prz =3D persistent_ram_new(*paddr, sz, sig, &cxt->ecc_info,
 				  cxt->memtype, PRZ_FLAG_ZAP_OLD, label);
 	kfree(label);
=2D-
2.43.0