Received-SPF: pass (google.com: domain of linux-kernel+bounces-29436-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240112083421.3728017-1-alexious@zju.edu.cn> <5dd12651-232d-41f2-afa4-2a3e5c127969@redhat.com>
 <CAHp75VfKj7sQ3HkNaqNe0CjVrRb0J=X3gPJf-rSLeU8RQ2hjFg@mail.gmail.com> <17d22c9e.4900.18d162090d8.Coremail.alexious@zju.edu.cn>
In-Reply-To: <17d22c9e.4900.18d162090d8.Coremail.alexious@zju.edu.cn>
From: Andy Shevchenko <andy.shevchenko@gmail.com>
Date: Wed, 17 Jan 2024 22:50:24 +0200
Message-ID: <CAHp75Vdz4FRF5=zFiKarOkA6ezOTP=CbwU2-_fpSCpuaZgb+VA@mail.gmail.com>
Subject: Re: [PATCH] media: atomisp: ssh_css: Fix a null-pointer dereference
 in load_video_binaries
To: alexious@zju.edu.cn
Cc: Hans de Goede <hdegoede@redhat.com>, Mauro Carvalho Chehab <mchehab@kernel.org>, 
	Sakari Ailus <sakari.ailus@linux.intel.com>, 
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Kate Hsuan <hpa@redhat.com>, 
	Dan Carpenter <error27@gmail.com>, Brent Pappas <bpappas@pappasbrent.com>, linux-media@vger.kernel.org, 
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Jan 17, 2024 at 8:34=E2=80=AFAM <alexious@zju.edu.cn> wrote:
> > On Fri, Jan 12, 2024 at 10:49=E2=80=AFAM Hans de Goede <hdegoede@redhat=
com> wrote:
> > > On 1/12/24 09:34, Zhipeng Lu wrote:

> > > > Fixes: ad85094b293e ("Revert "media: staging: atomisp: Remove drive=
r"")
> > Besides that, are you sure the Fixes refers to the correct commit?
>
> Well, I think I referred to the correct commit, which introduce the whole=
 module and leave this bug.
>
> If I did miss something please let me know.

Yes, the driver was before that commit in the kernel. Was it without
the bug? No, because you are referring to a clear revert. So, find the
real commit that had brought that into the kernel.

--=20
With Best Regards,
Andy Shevchenko