Received-SPF: pass (google.com: domain of linux-kernel+bounces-29448-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Heiko =?ISO-8859-1?Q?St=FCbner?= <heiko@sntech.de>
To: Jianfeng Liu <liujianfeng1994@gmail.com>, robh+dt@kernel.org,
 krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
 ezequiel@vanguardiasur.com.ar, p.zabel@pengutronix.de, mchehab@kernel.org,
 Nicolas Dufresne <nicolas@ndufresne.ca>
Cc: sfr@canb.auug.org.au, devicetree@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org,
 linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
 sigmaris@gmail.com, knaerzche@gmail.com,
 Ezequiel Garcia <elezegarcia@gmail.com>
Subject: Re: [PATCH v3 0/2] [v3]Add hantro g1 video decoder support for RK3588
Date: Wed, 17 Jan 2024 22:12:42 +0100
Message-ID: <2196595.7aRn1RRit1@diego>
In-Reply-To: <5490507acc121113e52a8cdddb155fddf6dbb374.camel@ndufresne.ca>
References:
 <20231231151112.3994194-1-liujianfeng1994@gmail.com>
 <5490507acc121113e52a8cdddb155fddf6dbb374.camel@ndufresne.ca>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"

Hi Nicolas,

Am Mittwoch, 17. Januar 2024, 20:16:24 CET schrieb Nicolas Dufresne:
> Le dimanche 31 d=E9cembre 2023 =E0 23:11 +0800, Jianfeng Liu a =E9crit :
> > This is the v3 version of this series adding hantro g1 video decoder
> > support for rk3588.
> >=20
> > RK3588 has Hantro G1 video decoder known as VDPU121 in TRM of RK3588 wh=
ich
> > is capable to decode MPEG2/H.264/VP8 up to 1920x1088. This vpu ip is al=
so
> > found in RK3568.
>=20
> The only concern I have is that we rejected enabling this VPU on RK3399, =
since
> having two H.264 decoders was confusing userspace softwares at the time, =
causing
> the slow one to be picked sometimes. I know the selection is not fully
> implemented in GStreamer either, not sure for LibreELEC ffmpeg fork, Chro=
mium or
> Cros-codec.
>=20
> Of course, its not a problem now, but only when someone provides an rkvde=
c2
> driver that enables the much more capable HW decoder. Shall we hold on H.=
264
> mainline for now ?

hmm, reading the TRM the VDPU121 claims to support:
=2D VP8
=2D VC1
=2D MPEG-1,2,4
=2D H.263
=2D JPEG

So at least the TRM doesn't list h.264 as supported at all on VDPU121 .
Not sure what is up with that or is Rockchip also just suggesting that h.264
should be in the VDPU381 [where h.264 is listed as featured] ?


Heiko