Received-SPF: pass (google.com: domain of linux-kernel+bounces-29476-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: "Keller, Jacob E" <jacob.e.keller@intel.com>
To: Dan Carpenter <dan.carpenter@linaro.org>
CC: Julia Lawall <Julia.Lawall@lip6.fr>, Kees Cook <keescook@chromium.org>,
	"Gustavo A . R . Silva" <gustavoars@kernel.org>, "cocci@systeme.lip6.fr"
	<cocci@systeme.lip6.fr>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, Harshit Mogalapalli
	<harshit.m.mogalapalli@gmail.com>
Subject: RE: [PATCH] coccinelle: semantic patch to check for potential
 struct_size calls
Thread-Topic: [PATCH] coccinelle: semantic patch to check for potential
 struct_size calls
Thread-Index: AQHZSumEyR9kSyf5CEKOOwPKwX3cMbDd/lkAgAKK4dA=
Date: Wed, 17 Jan 2024 21:54:19 +0000
Message-ID: <CO1PR11MB508917C85AAD2ADEFFDAA204D6722@CO1PR11MB5089.namprd11.prod.outlook.com>
References: <20230227202428.3657443-1-jacob.e.keller@intel.com>
 <6ee33330-134c-4bdd-a5eb-e8ff0db6cc8b@moroto.mountain>
In-Reply-To: <6ee33330-134c-4bdd-a5eb-e8ff0db6cc8b@moroto.mountain>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?XKsHjIwP8/BpzgHZm7cQoIPq8Jb3xZXNGXZ0C6N9jysYsZM2eLExn2s6hJAn?=
 =?us-ascii?Q?c07qMrcw2/uwd0DsVt+vfKf8frh7ZbqiR5aWPSfSUDTfeV7Sel6JWKHfNMaH?=
 =?us-ascii?Q?WN6Eaxw2d034nhs2p0xq2AVNgItktqdurhU3gjgmSHdarpQbP5w9Z/GxF7Hw?=
 =?us-ascii?Q?S/bMVVz5DZ9dnRYtV+PqTij/IAuxg1JTk5YfuhIC6jSakH5PDmiWkP+P0VKF?=
 =?us-ascii?Q?1nFNbuG23aQH4Dj4z7qsDt39n9RyMKv1SDDNcHmcmyNbqWUzh2fkuWh1ByIO?=
 =?us-ascii?Q?TYB1R14SwNlGSTgB28rvvgq4g9PHoxVB34ItjkElEtNtWSnygFMiM617wLni?=
 =?us-ascii?Q?HyggA54J68asWz6n9tLuZ6RimMkdX3j+Vufy+g5WVAfLSx+ZIjvdfAqiuFnP?=
 =?us-ascii?Q?fBLFNImT+JiKlD+3ZpydkSGeLdKFDFSDi1NexaJeA+ErbgII4wC/7SIEXyUv?=
 =?us-ascii?Q?hK8O+V5d/SUwz/7R77D4Zq1owuESxzZ+kOYqjSfP/j2rLj1+jkdNO6tYYqEj?=
 =?us-ascii?Q?9U4wqwgBjdgj4fcHQZnsE9zvGJHKQJwepm1vRqOGEAvR6WNaelnqRNmDCAvo?=
 =?us-ascii?Q?9X8IbEeFvBL+2JjhyzJHhz+2QHcgf1B/C9xktwj2qpIyJPWv5kXLgJxtsUPF?=
 =?us-ascii?Q?SvYYZxyBwnsULRlnRK8ipHl7Pd/EqBgFt01bNAtDL2Qyocc7kYvtIyUiz1JO?=
 =?us-ascii?Q?z6zW2UAntl76odM3CNwoVIcA7ZTNco4ph5TCHbKpkvfFHgYC4DzuIPEtxtHu?=
 =?us-ascii?Q?hDzLyFWtyhVsfGkLUeu+dfHmjfMu3YZMEZFaP6Ei9WUVnitk1dgf74ws2YXp?=
 =?us-ascii?Q?yRwm+vQN24pLsl6cU1X3Pgs48w1h0EHwAJRTmaLM6tmXjIlRXw44PRcu7TRP?=
 =?us-ascii?Q?r43Tl8fRxdj9tFPNjVr11ZYs2/PyjUw+hMhbDdGKpd+s+Ae+q/xJcsVw2mhF?=
 =?us-ascii?Q?L2bMhZfAxSKpfPcDQSxN8f9Cc6g4ANIkduONG/Xgo849ifmpvh2cAFhxmTai?=
 =?us-ascii?Q?7l6wEYu6VffHzGhfZT2MBKPG24dJihyEhpHXl+9xq+ntw+0FBHHFcKZPNOQc?=
 =?us-ascii?Q?XkwpD8um9oi5XpZ0yKyMu1JZGm9qa2o5e2rnwJVB/fQxgsJ7w8BlEPKIrqJw?=
 =?us-ascii?Q?2OeX10VMCoRC9ECzE7hGNGuDJcP9OcEb1nCc28uxw0eTLjMaZcNhVrUr9sTW?=
 =?us-ascii?Q?7Y6qRKESpsy3T2Im3VMH5QE4Ra5US19yehLD2H+YMoPjA0+456GfFeoLAu/F?=
 =?us-ascii?Q?hZdzhtCnMX4FWXye4Y0qHygUQyvIDGLK2XzPbQS3eYyJ9hZ+Zr+jWOo1Q1J9?=
 =?us-ascii?Q?m7vKHO/RVuNalmRnVocX9YssXcJzMIbl05UCEiDOf5ZPymyCr0I51Lp41OEL?=
 =?us-ascii?Q?8dlqx2EoM8JZLk/ztYqmdBqelgMHNNg+XyBJgLEman660FkRshRM90ep2E5j?=
 =?us-ascii?Q?0Njkxf4BrS1V7p6H9acv/HArdxx6mARk6qahYZ1G7iMJLwuSqHTSVVEH0O0L?=
 =?us-ascii?Q?DOH1Kk65qpcvvQf7OAEsUL8nr6FpQx2npPaxy8WUX3jnWFC66FwAOQjDcVYk?=
 =?us-ascii?Q?AsgbQ7PkG9I6p5xjPA0wimS4QHbxsyGy6bZlhUNO?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 12429f4e-8916-4f72-4336-08dc17a6db9e
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jan 2024 21:54:19.5777
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: LHPUmDLDZ8dXthhcPauhfH/tY3dvZR2eUf/Ymt5VxjpuDfkp2lz72QumRqts4V6dgdw6vIqeuTi82I8A8IqbXbjeJL1OarxlLdGmFqPbvZk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB6935
X-OriginatorOrg: intel.com


> -----Original Message-----
> From: Dan Carpenter <dan.carpenter@linaro.org>
> Sent: Monday, January 15, 2024 11:03 PM
> To: Keller, Jacob E <jacob.e.keller@intel.com>
> Cc: Julia Lawall <Julia.Lawall@lip6.fr>; Kees Cook <keescook@chromium.org=
>;
> Gustavo A . R . Silva <gustavoars@kernel.org>; cocci@systeme.lip6.fr; lin=
ux-
> kernel@vger.kernel.org; Harshit Mogalapalli <harshit.m.mogalapalli@gmail.=
com>
> Subject: Re: [PATCH] coccinelle: semantic patch to check for potential st=
ruct_size
> calls
>=20
> What happened to this patch?  These sorts of patches go through Kees?
>=20

No one replied and I got side tracked by other projects.

> Also it would be nice if it could handle char arrays.  It doesn't warn
> for the kmalloc in dg_dispatch_as_host():
>=20
Yea it would be nice to handle this too.

> drivers/misc/vmw_vmci/vmci_datagram.c
>    227                          dg_info =3D kmalloc(sizeof(*dg_info) +
>    228                                      (size_t) dg->payload_size, GF=
P_ATOMIC);
>=20
> The Cocci check is looking specifically for:
>=20
> 	sizeof(*dg_info) + (sizeof(*dg_info->msg_payload) * dg->payload_size)
>=20

I think that's a slightly different formulation.

> But since this flex array is u8 there is no multiply.  I don't know how
> are it is to add support for char arrays...
>=20

A separate rule would work.

> Also another common way to write the multiply is:
>=20
> 	sizeof(*dg_info) + (sizeof(dg_info->msg_payload[0]) * dg->payload_size)
>=20
> That should be pretty straight forward to add.
>=20
> regards,
> dan carpenter
>=20

Mostly I just lost track of this because I struggled to get traction in the=
 right lists and trees.

Thanks,
Jake