Received-SPF: pass (google.com: domain of linux-kernel+bounces-29648-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <e583bcd5-cae6-4299-8800-80e862a6bd8f@kylinos.cn>
Date: Thu, 18 Jan 2024 10:03:37 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] pstore/ram: Return directly after a failed kasprintf()
 call in ramoops_init_prz()
To: Markus Elfring <Markus.Elfring@web.de>, linux-hardening@vger.kernel.org,
 kernel-janitors@vger.kernel.org, "Guilherme G. Piccoli"
 <gpiccoli@igalia.com>, Joel Fernandes <joel@joelfernandes.org>,
 Kees Cook <keescook@chromium.org>, Tony Luck <tony.luck@intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>, =?UTF-8?B?R8O8bnRlciBSw7Zjaw==?=
 <groeck@chromium.org>, Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
References: <644f44ad-7e2b-4a1a-bbd7-ccc79d479242@web.de>
Content-Language: en-US
From: Kunwu Chan <chentao@kylinos.cn>
In-Reply-To: <644f44ad-7e2b-4a1a-bbd7-ccc79d479242@web.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable

Hi Markus,
Thanks for your patch.

On 2024/1/18 04:24, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Wed, 17 Jan 2024 21:09:22 +0100
>=20
> The result from a call of the function =E2=80=9Ckasprintf=E2=80=9D was =
passed to
> a subsequent function call without checking for a null pointer before
> (according to a memory allocation failure).
> This issue was detected by using the Coccinelle software.
>=20
> Thus return directly after a failed kasprintf() call.
>=20
> Fixes: 1227daa43bce1 ("pstore/ram: Clarify resource reservation labels"=
)
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>   fs/pstore/ram.c | 3 +++
>   1 file changed, 3 insertions(+)
>=20
> diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c
> index 88b34fdbf759..1a673a4af17c 100644
> --- a/fs/pstore/ram.c
> +++ b/fs/pstore/ram.c
> @@ -595,6 +595,9 @@ static int ramoops_init_prz(const char *name,
>   	}
>=20
>   	label =3D kasprintf(GFP_KERNEL, "ramoops:%s", name);
> +	if (!label)
> +		return -ENOMEM;
> +

This part looks good to me.

Commit 1227daa43bce1 ("pstore/ram: Clarify resource reservation labels")
introduce another two more kasprintf in the ramoops_init_przs.

Could you fix it together?
>   	*prz =3D persistent_ram_new(*paddr, sz, sig, &cxt->ecc_info,
>   				  cxt->memtype, PRZ_FLAG_ZAP_OLD, label);
>   	kfree(label);
> --
> 2.43.0
>=20
--=20
Thanks,
   Kunwu