Received-SPF: pass (google.com: domain of linux-kernel+bounces-29653-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <fe3d5804-706e-40fc-a4e0-819df06f83ff@arista.com>
Date: Thu, 18 Jan 2024 02:18:08 +0000
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] selftests/net: argument value mismatch when calling
 verify_counters()
Content-Language: en-US
To: Mohammad Nassiri <mnassiri@ciena.com>
Cc: edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
 shuah@kernel.org, 0x7f454c46@gmail.com, mohammad.nassiri78@gmail.com,
 netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
 linux-kernel@vger.kernel.org
References: <20240116214826.10754-1-mnassiri@ciena.com>
From: Dmitry Safonov <dima@arista.com>
In-Reply-To: <20240116214826.10754-1-mnassiri@ciena.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Hi Mohammad,

On 1/16/24 21:48, Mohammad Nassiri wrote:
> The end_server() function only operates in the server thread
> and always takes an accept socket instead of a listen socket as
> its input argument. To align with this, invert the boolean values
> used when calling verify_counters() within the end_server() function.
> 
> Fixes: ("3c3ead555648 selftests/net: Add TCP-AO key-management test")
> Signed-off-by: Mohammad Nassiri <mnassiri@ciena.com>
> Link: https://lore.kernel.org/all/934627c5-eebb-4626-be23-cfb134c01d1a@arista.com/


As I've written you off-list, the patch probably was not delivered to
mailing lists due to SPF check not passing. Please, fix the send-email
setup when/if you want to send more patches.

Related to this patch: I'm going to carry and resend it together with 2
more patches, as this fix made 3 selftests fail and I've looked into that.

> ---
>  tools/testing/selftests/net/tcp_ao/key-management.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/net/tcp_ao/key-management.c b/tools/testing/selftests/net/tcp_ao/key-management.c
> index c48b4970ca17..f6a9395e3cd7 100644
> --- a/tools/testing/selftests/net/tcp_ao/key-management.c
> +++ b/tools/testing/selftests/net/tcp_ao/key-management.c
> @@ -843,7 +843,7 @@ static void end_server(const char *tst_name, int sk,
>  	synchronize_threads(); /* 4: verified => closed */
>  	close(sk);
>  
> -	verify_counters(tst_name, true, false, begin, &end);
> +	verify_counters(tst_name, false, true, begin, &end);
>  	synchronize_threads(); /* 5: counters */
>  }
>  

Thanks,
            Dmitry