Received-SPF: pass (google.com: domain of linux-kernel+bounces-29892-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <fd5550ad-76c0-419b-aa07-a0493a57286e@digi.com>
Date: Thu, 18 Jan 2024 09:25:02 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 1/3] gpio: vf610: add support to DT 'ngpios' property
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: linus.walleij@linaro.org, brgl@bgdev.pl, robh+dt@kernel.org,
 krzysztof.kozlowski+dt@linaro.org, andy@kernel.org, conor+dt@kernel.org,
 shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de,
 festevam@gmail.com, linux-imx@nxp.com, stefan@agner.ch,
 linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org
References: <20240117083251.53868-1-hector.palacios@digi.com>
 <20240117083251.53868-2-hector.palacios@digi.com>
 <CAHp75Vci=1nAvxRcbkK2SxGWGbQVbzQMTycMt8tZ5snPRTYXOg@mail.gmail.com>
Content-Language: en-US
From: Hector Palacios <hector.palacios@digi.com>
Organization: Digi
In-Reply-To: <CAHp75Vci=1nAvxRcbkK2SxGWGbQVbzQMTycMt8tZ5snPRTYXOg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UGEzekxRdWJpMnhYNHZIcmplRE9ML1ZTVVMvaHNDNVJoeTVONFpZaUszdlJt?=
 =?utf-8?B?UVZoSEVWWi8xNmJyWm9nU2REZCtRSjZ6VWcxcFVIWDh6aFUrNGVGT05BWi8r?=
 =?utf-8?B?LzF2ZkR5M1VmUGNsdFBJZTZUam45ZGFKTWxnN3NPSC9XUmZHMUhpcUY0Z3hF?=
 =?utf-8?B?VnoxOTIxYVpIYkFIWE92MkplWDUvZUhXcXRGMXd1M0tGU3NVWWtuT05UNkV2?=
 =?utf-8?B?Sjl1T0FMRmYwai9GQ1Rrc1czVEE5cnhHVDB6a1JpTWpTU3p6dmU4RFVCV1ZE?=
 =?utf-8?B?TlFYUVlHVTFvRjZEUHU2bVczdlRFNDFXKzVKbVhna0dJMWV1eHRSeDBGaXVY?=
 =?utf-8?B?RDV2V2h1UjM0QThnaEVYOFJET3piZHYxREJjVzF6NmdMYm1VSnh0V29uWGpw?=
 =?utf-8?B?SG1pSUNiS004RmZQMzE4OEJ4WHJJNVhpUGNBM0YreGYwSmRYUWg2RlVWMEU0?=
 =?utf-8?B?dnFPZ1AvbTVka1h6dVU3Q1lkSUtFOFV3S0llanF6YkZUbTJRUUlsQXpwTkFE?=
 =?utf-8?B?elgvc0N2azVSeSszVXVHbEFNNkx0MjEzTVFUUnlnUFFGdy92T2d1VFYyZ3Zs?=
 =?utf-8?B?c1Z6VXRCaExTSmRsKzEzWlFQeEdLNlVpK24wa1lPdkJlMmU2MEQrczlldUln?=
 =?utf-8?B?N09kb3VUQ1o2bnFiT2hqL0ZjNm9DRFdMWk44eityaWZEamJpQ3FEMUQvSi9l?=
 =?utf-8?B?RE9Kbk8wQmZxaDhLQlN6VThjU2l4QVNGWmNmNUNudDFjbGsvSzA4akZnMjJU?=
 =?utf-8?B?S2tGTmdjQllzSGFndUNRQURiQ1VEd2xEMmVFLzRtT2cyUHNXcTZOVTRPK3dJ?=
 =?utf-8?B?S2RkU0duaTRSRmEvZnNKQnpqZTRYZlZWc0xmS0d5dExDWkVaaHJaYzQ0dmpX?=
 =?utf-8?B?ZmdoNXR1cU4wcHNBTVUzUzE0WjdUVHVML1pOUUJBYmdQZG1lcTRQTWxGRnlI?=
 =?utf-8?B?MUNRN1RIYnBWcHJxVHpvb3VOalFpUkdiR1dIcllLVHljeWZQMGlaR2NIVlFP?=
 =?utf-8?B?RXk4djJjVy85OGZQVmZJRkUzSXV4eEl3MnRkeEdreGVGS0wwaWF2VDRPWnZY?=
 =?utf-8?B?WHozcDYvSGRkTzVWQktXbG1pMjZ3QlJ3LzdjV1cxYkoybUJOclZlMTJUdzdO?=
 =?utf-8?B?SEtpRUtLRkdHekFiRGloVjMxTW9BNG9kSnhCVVFmVzZFb296TU1WTXhPR2Q0?=
 =?utf-8?B?YzZmd3Rvd1dVR1lQWGJ1TVkzallEdXJpQm9iYXZSZTZDM21URmUvQUZYSjI1?=
 =?utf-8?B?RDZCbHA3cDZ6dzFadHhseXhvSzlLSHN1blZRQ1A4VG84RjhmeG1hWjBBUUdm?=
 =?utf-8?B?Si9TMkhKVVdOZm1ObjB2NFBVSVMxQWNzS2RYY0l4MVExWmc4bTJ5SjVQcUhz?=
 =?utf-8?B?YVRJa3l0MngyZXdqKzZzajdWSHRHbGJpaWZ3bzIwa05HZmJOR1FnSmt6RDQy?=
 =?utf-8?B?ZlVMZktYZ1Q5TXlKT1Fna1JvL00wRFpSVDlWQXZSdSt5L3cvRk5FeHF3S0Mx?=
 =?utf-8?B?QXo1ZTZ5QmJVNGVoTnNGMmNNMzVqN0UxYXI3YlRGQnRDbm1UdjNxaCtGaFNT?=
 =?utf-8?B?NTZHTmt5YUUyTU9vRHlJclBDNUtQZTltTHl1dHRad21Yc1NFd0pSYjRPQkdk?=
 =?utf-8?B?TWxJcXlaTzRLNEtxZG40OHE4YXFSbk5XNkdaaVVQSTZwMEhwZzl5WjFKdHpW?=
 =?utf-8?B?WjM5ajlTMXpRNUc5aDBJWEhwc3FINGdHWkVXRmhmbDEwbVFzbEcwdmFWU2l2?=
 =?utf-8?B?WjROTGVyZ0FQTi9KUmtkdWdYaTVJSlh1TlVveEEvWThSSDlzUjVwbzE4MXdX?=
 =?utf-8?B?bkN3VzE3VFpWS2NPREVwZDNzZHdaTE1YTHN4bTQ0VlZCZXNuU1g4U2Zlc2py?=
 =?utf-8?B?UHJJQ09KejhxajZjRGljUmgrRmVhK0gvajBTUnF5WDZrYnErdlBCd1lFblVn?=
 =?utf-8?B?blA0VXJ6ZWZCY09CdkR0NnNjanVLNlBQYitjaW8zdkhmYVQ0TGVVOXBIZW93?=
 =?utf-8?B?RHA0d3BNeXh1dFFrbms5QjN2cEtUek9BV0FPOFB3UGtVS2JaYmNrYWo2Y0pN?=
 =?utf-8?B?cFR1VEpGcjZzQlB4WWFJS0JRVWd6bU1wamxoZjQ0czFjcWsydGxnZTdUQS9N?=
 =?utf-8?Q?O2A9g3P1YxYaenpLj9IBUr4WI?=
X-OriginatorOrg: digi.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3a8d580b-ca47-4470-b905-08dc17ff0f1f
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4370.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jan 2024 08:25:42.0840
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: abb4cdb7-1b7e-483e-a143-7ebfd1184b9e
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KP6A0rl6kgfOVDC9c0AiLEqHNbUtj/SGRrP2ZYdTPyKKaJsW3Iu71KARzgYe0e1M/fo7eHIy/dpoP9sd3H/wlw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB5114
X-BESS-ID: 1705566345-104761-12525-14975-1
X-BESS-VER: 2019.1_20240103.1634
X-BESS-Apparent-Source-IP: 104.47.73.40
X-BESS-Parts: H4sIAAAAAAACA4uuVkqtKFGyUioBkjpK+cVKVubGlkBGBlAsLSUx1TjFIC3J1C
	QlJcnA0tDC2DjFONXSMsUsxSwxLUmpNhYABhSVLkAAAAA=
X-BESS-Outbound-Spam-Score: 0.00
X-BESS-Outbound-Spam-Report: Code version 3.2, rules version 3.2.2.253595 [from 
	cloudscan14-208.us-east-2a.ess.aws.cudaops.com]
	Rule breakdown below
	 pts rule name              description
	---- ---------------------- --------------------------------
	0.00 BSF_BESS_OUTBOUND      META: BESS Outbound 
X-BESS-Outbound-Spam-Status: SCORE=0.00 using account:ESS112744 scores of KILL_LEVEL=7.0 tests=BSF_BESS_OUTBOUND
X-BESS-BRTS-Status:1

Hello Andy,

On 1/17/24 21:51, Andy Shevchenko wrote:
>> Some SoCs, such as i.MX93, don't have all 32 pins available
>> per port. Allow optional generic 'ngpios' property to be
>> specified from the device tree and default to
>> VF610_GPIO_PER_PORT (32) if the property does not exist.
> 
> ...
> 
>> +       ret = device_property_read_u32(dev, "ngpios", &ngpios);
>> +       if (ret || ngpios > VF610_GPIO_PER_PORT)
>> +               gc->ngpio = VF610_GPIO_PER_PORT;
>> +       else
>> +               gc->ngpio = (u16)ngpios;
> 
> This property is being read by the GPIOLIB core. Why do you need to repeat this?

My apologies; I had not seen this.
I'll use gpiochip_get_ngpios() on the next iteration.

Thank you!
-- 
Héctor Palacios