Received: by 2002:a05:7412:ba23:b0:fa:4c10:6cad with SMTP id jp35csp206058rdb; Thu, 18 Jan 2024 00:39:27 -0800 (PST) X-Google-Smtp-Source: AGHT+IE892DlqHgzWrD1OpJP9Xtm05TTJi18RWOYd4Jl1CoPUjaV2YmIylmrAp6OhpExyZ1RpayC X-Received: by 2002:a05:622a:1055:b0:42a:e9f:1968 with SMTP id f21-20020a05622a105500b0042a0e9f1968mr476298qte.109.1705567167657; Thu, 18 Jan 2024 00:39:27 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705567167; cv=pass; d=google.com; s=arc-20160816; b=aTHsCc9My0jMH8WZ0z0iuy0ggev21M5LimW6B3E2f+WZmNTyHTX3c40j06u+HRyDAY LYq0H2Hs0EAVf4xrOS7Nv/KZjKo6zrJyB0QKrENADaBTCA/nAcUe1PgVuIoQu4mdQEb1 b7XNOna9hnd1sYSo1GtSwsUfwEDleGQWeb+fyb1j5R4/Q5fwLtW91Dv01JKFTGxI+Bz5 Mthned+miXn/W+jJb1I0rRxoJ83bE/UTb9/fVELwoUSE39OIOQk7BYUXrKRZMitmXJc2 zPyWhkNW1UgN9WQyIcuZjplul6zj7uckijjskjN4HF65zX1ovl3SR51gEixUUL1EOpLw YdiQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date:dkim-signature; bh=JlgKP+FPv3esdIvjSP1xwJJg3T/aL8cA5hIPaywX15k=; fh=/VCIBwOV1SV2Dd9lJ3hI/KvSbRGoUkBtaySn2LE1TV4=; b=Lm+wKsEpoyDJc5M7Qjbvk387ZythWm2BKrrQy/TU8hkorlc5EJmkfR8i2fnZPclI7Q OOqs5Ykgt8pWT8n8xTDWqKqYKLA03J44kIAKelKv0jjA0CzF+CPJsc5ZBav2lVn0xv76 laSSuW0i6CVNkkkdOrvsAAWeingCpEO5M6aGenPJXcSl+LNTr1ju91XZCdp7mP1FN/ug BniRBDgunUjmmM++KiRaaD7y5FOHDdqc4Ogx67l4qmoaVY/m88v4i5FKPnQteLuIsqGt rCd0PG5pu5Mohj+IMPijUT+PbJb1+adKs7RCRohWl7MTqzITCOHA4r2pDj0P3cLRHjdZ XnjQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=FFAXbHkx; arc=pass (i=1 dkim=pass dkdomain=armlinux.org.uk dmarc=pass fromdomain=armlinux.org.uk); spf=pass (google.com: domain of linux-kernel+bounces-29900-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-29900-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id hb8-20020a05622a2b4800b00429c5cba26csi13523832qtb.289.2024.01.18.00.39.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jan 2024 00:39:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-29900-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=FFAXbHkx; arc=pass (i=1 dkim=pass dkdomain=armlinux.org.uk dmarc=pass fromdomain=armlinux.org.uk); spf=pass (google.com: domain of linux-kernel+bounces-29900-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-29900-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 56CE11C2216E for ; Thu, 18 Jan 2024 08:39:27 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0FA91125C0; Thu, 18 Jan 2024 08:36:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="FFAXbHkx" Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF400C2E9; Thu, 18 Jan 2024 08:36:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705566999; cv=none; b=Ug2YtFpm0FkvjCE8DY2jXbUYuCI9EzH2hjwHbJce7IR3FbA8f3wchQi4S7MgfETn0HXw48ysaZWt7i1uN7iMZjvX9TmTm9xOMPjuJyq6WXRjzrSJOR6KA8cBsUV9bON2yYHNnxcT9oBUkFgUUe312kRYoijFZwjI1OeVnfapYvs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705566999; c=relaxed/simple; bh=9nB0hvJ/9aLf6fDnzN/xsePM/QortmHnFQleCMr1hlw=; h=DKIM-Signature:Received:Received:Date:From:To:Cc:Subject: Message-ID:References:MIME-Version:Content-Type: Content-Disposition:In-Reply-To:Sender; b=ZZFyLhzBy36yGZcTvOnVqRfMdAIiamaPTtKBdrpmnI1YgfQmCT6iQBGq55JyUJySa+TVaCFrsCWd+6HmuTros9W6ELYFl2RWBCZTRAHQM2Jyte2/tp5Gmp/aCBfRaRMgi0VU7IUJu6jUMqWfzvi44ZcBnhetY37ch3YsM2KwGMU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=FFAXbHkx; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=JlgKP+FPv3esdIvjSP1xwJJg3T/aL8cA5hIPaywX15k=; b=FFAXbHkx35OhEr7iZ/8v5xXeJo gaQRtOKk86oVCsINzzaPANYk1qP/G04oEuyAczNG2Ip8dnMy1uENgzUWgGJP5UzJny9bxyv9rswAZ N4s6a5J0ddbKcZp0YrmHcInr1EczDn9JYK8+3SQOuslFjVDsrUa5P5YADa/L+YFq+WTbFlJYH8brJ HbvH8NWuFC+CTukctlArlV61WRcZc21igWPkUNTg8mat6q7oanmnMaKDLrzyzJuPTb5xLxGScA0Eo GceHDR9TEhynQVgbdO6S1wZqYb/TLileSp7N8j8vRNIklMfl+zUoCDy9sEwRYKziVp0I1w39hQNzj 476cXXzg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:58228) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rQNst-0005VY-1S; Thu, 18 Jan 2024 08:36:23 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1rQNsp-0005a2-Et; Thu, 18 Jan 2024 08:36:19 +0000 Date: Thu, 18 Jan 2024 08:36:19 +0000 From: "Russell King (Oracle)" To: Elliot Ayrey Cc: Marcin Wojtas , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Subject: Re: [PATCH] net: mvpp2: Add EEE get/set to mvpp2 driver Message-ID: References: <20240118015748.3507954-1-elliot.ayrey@alliedtelesis.co.nz> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240118015748.3507954-1-elliot.ayrey@alliedtelesis.co.nz> Sender: Russell King (Oracle) On Thu, Jan 18, 2024 at 02:57:48PM +1300, Elliot Ayrey wrote: > Fill in the missing .get_eee and .set_eee functions for the mvpp2 > driver. This has no benefit without also configuring LPI in the driver. In any case, you should be calling the phylink functions not the phylib functions. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!