Received: by 2002:a05:7412:ba23:b0:fa:4c10:6cad with SMTP id jp35csp226101rdb; Thu, 18 Jan 2024 01:28:35 -0800 (PST) X-Google-Smtp-Source: AGHT+IHLSp6Vh1OAfrXbCjHcuu49JomtixQBOMlwoXvQiE/hry2+JurSgj5YnEsaKgYntzuKJDJb X-Received: by 2002:a05:6214:e64:b0:681:563d:1003 with SMTP id jz4-20020a0562140e6400b00681563d1003mr480388qvb.113.1705570115139; Thu, 18 Jan 2024 01:28:35 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705570115; cv=pass; d=google.com; s=arc-20160816; b=Gbz4arwnrfeoBHrnNquT4jJlvx6hUbrOKtrQU8NhQ/IkN1IKDzVWHYWPFiwd9+XFvB 1Ws7UsjYNdDWg/MZzYfJir4VANGdVAHrjNE9zX67sK1pQlR49NnMfma4IiFnq/CDKB5F UmUmzriDuJ8E1mNr5L6Uu1RadG1Yz5rMgkBpwM668frU4qKrhVHc4i/jalbHOeM4IHMi ZRIrh9VT2NzuzNe7Rjscw2hxbO8veCmtwoZn30OUiYl/FTvMxU52Us2YQ7lbiGUL6G41 NFrJPq+9J5zINKscgSpztqW0QHNTBAO0QlKfG2NacYFGPlO9vl9o1IumFYO5esUdTgxb HgMA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id; bh=HtL2iiU0nfDyiRt9tTd7AcJL7rTNP36DMyPCVn7+M1g=; fh=qI0D3LdlzvC4gPQMccwIqYgRZT67ah7JIE1N+oAIm4s=; b=fqchfjHYEflK708R/63B5vQuQZz+EZGiqiQLA75iVzGWvQD2UkJjHSGGGOLpC2mPhf D5D8KUHLkGazxOIbjW9pC3bESkeixoJ0Tgn0Y45trVyCtSYY5tn5VKZCUMQCRlFlw7im dCcZ9ff9Xm3GUH4qAUDReryjP8yxu1ieldElYtAuetlB2U1ebT+/AdQAqJCy4gU02gRK 7vVKjNZqHbVa5qDal3Cuw/EEOZ2VHUH1K5hEaGX48tjX4Sxi22tKI5r5raZZofbjGcsm c53h699IjnMujJVNoBF4VbH7irih3CXrrOtQmY0WgtmPMVYgbls4hUb9J2CcBo161oUA 8I+Q== ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-29957-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-29957-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id n6-20020a0c9d46000000b0067f8e28347asi6213488qvf.492.2024.01.18.01.28.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jan 2024 01:28:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-29957-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-29957-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-29957-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id D07A81C2499A for ; Thu, 18 Jan 2024 09:28:34 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5334C208CC; Thu, 18 Jan 2024 09:28:04 +0000 (UTC) Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 221C1208C2; Thu, 18 Jan 2024 09:28:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705570083; cv=none; b=Z9TH9hssX/TqEqSsLikGqAq8Nas/2eJ874YIFFpGlm7xlfxMHabhpM9/DT75cIGnAi9u3JFXJoqDNexw+v1xv9HYHq27Ot8ztmjgCprByK/H6lp0w3Q0F1udfbYfjKmNg+0pMS/KE+BHsDMOZMRGApPLhe63d8SpY8z1pwPM0aE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705570083; c=relaxed/simple; bh=/gGlNbjmBlv+zqsAjlslP3odFZZNblilnBYeDhn2ZF0=; h=Received:X-Google-DKIM-Signature:X-Gm-Message-State: X-Google-Smtp-Source:X-Received:Received:Message-ID:Date: MIME-Version:User-Agent:Subject:Content-Language:To:Cc:References: From:Autocrypt:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=BuWqPWcKRjfNbwrCuqqQX7U+y1edArUGsnqZogkqkByg4VWvNhu5rM8/mbiuIThkt9/ejDNUfaUGpVc5a3LdaTuJVwFkLmfq337zdnlm7EPww3BCT0dqYUIuNHBsj2os+ToO3kLEwGS0n7AUoy6vCgqPKX+b3tgWQiXMtH3155I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-337c4f0f9daso1144341f8f.2; Thu, 18 Jan 2024 01:28:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705570079; x=1706174879; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HtL2iiU0nfDyiRt9tTd7AcJL7rTNP36DMyPCVn7+M1g=; b=kteP3YSl6cprDjf0LNvTFO4Kjc1cwkeO0h+EWbdDcWCUfy4+MoqIE3gdX8qXK52btj NGxCErgQQpHK4br4QBSYtk5xF4jk9q1fxOaz8zUc51sJvVG7z5Lb6KNfYr4aXuZYT0k7 LWj+JEax1mHZhnnB2yns04REZGkKlb+ZjAtkM7JFVph+50VmQxiQUUlTylE7Tkoll1JX yJVeroAS56AqoxJ7ib8MIgEnz1/nubhm2sy9Gd+GkoeU3BGJAnEEBdFKRcNVF0efEbU2 pgk/mAoalughEBnPY1iwL2rKDDcfqYdgsrFMLDC6iVadJhav5AP/WZyFPAe4QiamMN2e xAIA== X-Gm-Message-State: AOJu0YwH12yvj44y9Ajh+rsg40T76d2Bx+qBDZHkSyJzvDwNnqpyismH IIMSCLw0HBvJ5XHL0CPDe8T1cM4ZU79m0AzvBJKGy0FWY8wdiOtI X-Received: by 2002:a5d:5441:0:b0:336:6ba1:556d with SMTP id w1-20020a5d5441000000b003366ba1556dmr371299wrv.84.1705570079173; Thu, 18 Jan 2024 01:27:59 -0800 (PST) Received: from ?IPV6:2a0b:e7c0:0:107::aaaa:59? ([2a0b:e7c0:0:107::aaaa:59]) by smtp.gmail.com with ESMTPSA id b16-20020adfe650000000b00337a81a0a89sm3533054wrn.114.2024.01.18.01.27.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Jan 2024 01:27:58 -0800 (PST) Message-ID: <02bec7b8-7754-4b9d-84ae-51621d6aa7ec@kernel.org> Date: Thu, 18 Jan 2024 10:27:54 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] usb: gadget: u_serial: Add null pointer checks after RX/TX submission Content-Language: en-US To: Kuen-Han Tsai , gregkh@linuxfoundation.org, quic_prashk@quicinc.com, stern@rowland.harvard.edu, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org References: <20240116141801.396398-1-khtsai@google.com> From: Jiri Slaby Autocrypt: addr=jirislaby@kernel.org; keydata= xsFNBE6S54YBEACzzjLwDUbU5elY4GTg/NdotjA0jyyJtYI86wdKraekbNE0bC4zV+ryvH4j rrcDwGs6tFVrAHvdHeIdI07s1iIx5R/ndcHwt4fvI8CL5PzPmn5J+h0WERR5rFprRh6axhOk rSD5CwQl19fm4AJCS6A9GJtOoiLpWn2/IbogPc71jQVrupZYYx51rAaHZ0D2KYK/uhfc6neJ i0WqPlbtIlIrpvWxckucNu6ZwXjFY0f3qIRg3Vqh5QxPkojGsq9tXVFVLEkSVz6FoqCHrUTx wr+aw6qqQVgvT/McQtsI0S66uIkQjzPUrgAEtWUv76rM4ekqL9stHyvTGw0Fjsualwb0Gwdx ReTZzMgheAyoy/umIOKrSEpWouVoBt5FFSZUyjuDdlPPYyPav+hpI6ggmCTld3u2hyiHji2H cDpcLM2LMhlHBipu80s9anNeZhCANDhbC5E+NZmuwgzHBcan8WC7xsPXPaiZSIm7TKaVoOcL 9tE5aN3jQmIlrT7ZUX52Ff/hSdx/JKDP3YMNtt4B0cH6ejIjtqTd+Ge8sSttsnNM0CQUkXps w98jwz+Lxw/bKMr3NSnnFpUZaxwji3BC9vYyxKMAwNelBCHEgS/OAa3EJoTfuYOK6wT6nadm YqYjwYbZE5V/SwzMbpWu7Jwlvuwyfo5mh7w5iMfnZE+vHFwp/wARAQABzSFKaXJpIFNsYWJ5 IDxqaXJpc2xhYnlAa2VybmVsLm9yZz7CwXcEEwEIACEFAlW3RUwCGwMFCwkIBwIGFQgJCgsC BBYCAwECHgECF4AACgkQvSWxBAa0cEnVTg//TQpdIAr8Tn0VAeUjdVIH9XCFw+cPSU+zMSCH eCZoA/N6gitEcnvHoFVVM7b3hK2HgoFUNbmYC0RdcSc80pOF5gCnACSP9XWHGWzeKCARRcQR 4s5YD8I4VV5hqXcKo2DFAtIOVbHDW+0okOzcecdasCakUTr7s2fXz97uuoc2gIBB7bmHUGAH XQXHvdnCLjDjR+eJN+zrtbqZKYSfj89s/ZHn5Slug6w8qOPT1sVNGG+eWPlc5s7XYhT9z66E l5C0rG35JE4PhC+tl7BaE5IwjJlBMHf/cMJxNHAYoQ1hWQCKOfMDQ6bsEr++kGUCbHkrEFwD UVA72iLnnnlZCMevwE4hc0zVhseWhPc/KMYObU1sDGqaCesRLkE3tiE7X2cikmj/qH0CoMWe gjnwnQ2qVJcaPSzJ4QITvchEQ+tbuVAyvn9H+9MkdT7b7b2OaqYsUP8rn/2k1Td5zknUz7iF oJ0Z9wPTl6tDfF8phaMIPISYrhceVOIoL+rWfaikhBulZTIT5ihieY9nQOw6vhOfWkYvv0Dl o4GRnb2ybPQpfEs7WtetOsUgiUbfljTgILFw3CsPW8JESOGQc0Pv8ieznIighqPPFz9g+zSu Ss/rpcsqag5n9rQp/H3WW5zKUpeYcKGaPDp/vSUovMcjp8USIhzBBrmI7UWAtuedG9prjqfO wU0ETpLnhgEQAM+cDWLL+Wvc9cLhA2OXZ/gMmu7NbYKjfth1UyOuBd5emIO+d4RfFM02XFTI t4MxwhAryhsKQQcA4iQNldkbyeviYrPKWjLTjRXT5cD2lpWzr+Jx7mX7InV5JOz1Qq+P+nJW YIBjUKhI03ux89p58CYil24Zpyn2F5cX7U+inY8lJIBwLPBnc9Z0An/DVnUOD+0wIcYVnZAK DiIXODkGqTg3fhZwbbi+KAhtHPFM2fGw2VTUf62IHzV+eBSnamzPOBc1XsJYKRo3FHNeLuS8 f4wUe7bWb9O66PPFK/RkeqNX6akkFBf9VfrZ1rTEKAyJ2uqf1EI1olYnENk4+00IBa+BavGQ 8UW9dGW3nbPrfuOV5UUvbnsSQwj67pSdrBQqilr5N/5H9z7VCDQ0dhuJNtvDSlTf2iUFBqgk 3smln31PUYiVPrMP0V4ja0i9qtO/TB01rTfTyXTRtqz53qO5dGsYiliJO5aUmh8swVpotgK4 /57h3zGsaXO9PGgnnAdqeKVITaFTLY1ISg+Ptb4KoliiOjrBMmQUSJVtkUXMrCMCeuPDGHo7 39Xc75lcHlGuM3yEB//htKjyprbLeLf1y4xPyTeeF5zg/0ztRZNKZicgEmxyUNBHHnBKHQxz 1j+mzH0HjZZtXjGu2KLJ18G07q0fpz2ZPk2D53Ww39VNI/J9ABEBAAHCwV8EGAECAAkFAk6S 54YCGwwACgkQvSWxBAa0cEk3tRAAgO+DFpbyIa4RlnfpcW17AfnpZi9VR5+zr496n2jH/1ld wRO/S+QNSA8qdABqMb9WI4BNaoANgcg0AS429Mq0taaWKkAjkkGAT7mD1Q5PiLr06Y/+Kzdr 90eUVneqM2TUQQbK+Kh7JwmGVrRGNqQrDk+gRNvKnGwFNeTkTKtJ0P8jYd7P1gZb9Fwj9YLx jhn/sVIhNmEBLBoI7PL+9fbILqJPHgAwW35rpnq4f/EYTykbk1sa13Tav6btJ+4QOgbcezWI wZ5w/JVfEJW9JXp3BFAVzRQ5nVrrLDAJZ8Y5ioWcm99JtSIIxXxt9FJaGc1Bgsi5K/+dyTKL wLMJgiBzbVx8G+fCJJ9YtlNOPWhbKPlrQ8+AY52Aagi9WNhe6XfJdh5g6ptiOILm330mkR4g W6nEgZVyIyTq3ekOuruftWL99qpP5zi+eNrMmLRQx9iecDNgFr342R9bTDlb1TLuRb+/tJ98 f/bIWIr0cqQmqQ33FgRhrG1+Xml6UXyJ2jExmlO8JljuOGeXYh6ZkIEyzqzffzBLXZCujlYQ DFXpyMNVJ2ZwPmX2mWEoYuaBU0JN7wM+/zWgOf2zRwhEuD3A2cO2PxoiIfyUEfB9SSmffaK/ S4xXoB6wvGENZ85Hg37C7WDNdaAt6Xh2uQIly5grkgvWppkNy4ZHxE+jeNsU7tg= In-Reply-To: <20240116141801.396398-1-khtsai@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 16. 01. 24, 15:16, Kuen-Han Tsai wrote: > Commit ffd603f21423 ("usb: gadget: u_serial: Add null pointer check in > gs_start_io") adds null pointer checks to gs_start_io(), but it doesn't > fully fix the potential null pointer dereference issue. While > gserial_connect() calls gs_start_io() with port_lock held, gs_start_rx() > and gs_start_tx() release the lock during endpoint request submission. > This creates a window where gs_close() could set port->port_tty to NULL, > leading to a dereference when the lock is reacquired. > > This patch adds a null pointer check for port->port_tty after RX/TX > submission, and removes the initial null pointer check in gs_start_io() > since the caller must hold port_lock and guarantee non-null values for > port_usb and port_tty. Or you switch to tty_port refcounting and need not fiddling with this at all ;). thanks, -- js suse labs