Received-SPF: pass (google.com: domain of linux-kernel+bounces-29992-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Kunwu Chan <chentao@kylinos.cn>
To: keescook@chromium.org,
	tony.luck@intel.com,
	gpiccoli@igalia.com
Cc: linux-hardening@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Kunwu Chan <chentao@kylinos.cn>
Subject: [PATCH] pstore/zone: Add a null pointer check to the psz_kmsg_read
Date: Thu, 18 Jan 2024 18:02:06 +0800
Message-Id: <20240118100206.213928-1-chentao@kylinos.cn>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable

kasprintf() returns a pointer to dynamically allocated memory
which can be NULL upon failure. Ensure the allocation was successful
by checking the pointer validity.

Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
---
 fs/pstore/zone.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/fs/pstore/zone.c b/fs/pstore/zone.c
index 2770746bb7aa..abca117725c8 100644
--- a/fs/pstore/zone.c
+++ b/fs/pstore/zone.c
@@ -973,6 +973,8 @@ static ssize_t psz_kmsg_read(struct pstore_zone *zone=
,
 		char *buf =3D kasprintf(GFP_KERNEL, "%s: Total %d times\n",
 				      kmsg_dump_reason_str(record->reason),
 				      record->count);
+		if (!buf)
+			return -ENOMEM;
 		hlen =3D strlen(buf);
 		record->buf =3D krealloc(buf, hlen + size, GFP_KERNEL);
 		if (!record->buf) {
--=20
2.39.2