Received-SPF: pass (google.com: domain of linux-kernel+bounces-30003-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Thu, 18 Jan 2024 10:19:23 +0000
From: Conor Dooley <conor@kernel.org>
To: Primoz Fiser <primoz.fiser@norik.com>
Cc: Mathieu Othacehe <othacehe@gnu.org>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>, Li Yang <leoyang.li@nxp.com>,
	Stefan Wahren <wahrenst@gmx.net>,
	Christoph Stoidner <c.stoidner@phytec.de>,
	Wadim Egorov <w.egorov@phytec.de>, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	upstream@lists.phytec.de
Subject: Re: [PATCH v2 2/2] arm64: dts: imx93-phycore-segin: Add Phytec
 i.MX93 Segin
Message-ID: <20240118-regretful-viewer-8d7dfc7a0802@spud>
References: <20240117074911.7425-1-othacehe@gnu.org>
 <20240117074911.7425-3-othacehe@gnu.org>
 <c1ef5c08-1ae9-4a22-8ca9-47673c023e1e@norik.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="gdVdvko2Jiy19Yvv"
Content-Disposition: inline
In-Reply-To: <c1ef5c08-1ae9-4a22-8ca9-47673c023e1e@norik.com>


--gdVdvko2Jiy19Yvv
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jan 18, 2024 at 10:58:36AM +0100, Primoz Fiser wrote:
> > +	reg_usdhc2_vmmc: regulator-usdhc2 {
> > +		compatible =3D "regulator-fixed";
> > +		pinctrl-names =3D "default";
> > +		pinctrl-0 =3D <&pinctrl_reg_usdhc2_vmmc>;
> > +		regulator-name =3D "VSD_3V3";
> > +		regulator-min-microvolt =3D <3300000>;
> > +		regulator-max-microvolt =3D <3300000>;
> > +		gpio =3D <&gpio3 7 GPIO_ACTIVE_HIGH>;
> > +		enable-active-high;
>=20
> Order properties here alphabetically like in the downstream kernel.
>=20
> Comment applies for the entire patch.

Please do not order properties alphabetically. Instead, please read the
new documentation on property ordering that makes explicit what has just
been convention until now:
https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git/tree/Documen=
tation/devicetree/bindings/dts-coding-style.rst?h=3Dfor-next&id=3D83a368a3f=
c8ae8538bccb713dc0cae9eacc04790#n112

Cheers,
Conor.

--gdVdvko2Jiy19Yvv
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZaj7KwAKCRB4tDGHoIJi
0m6eAQClJvcWaV+PGbHsXiJ9NIcovUuFyFdgcqzj7m5pggaarAD/Wj3uRmz9ihlN
pH62UkUr3zU0WnMWaTu8yz4LXjHEQAo=
=gJVS
-----END PGP SIGNATURE-----

--gdVdvko2Jiy19Yvv--