Received: by 2002:a05:7412:ba23:b0:fa:4c10:6cad with SMTP id jp35csp271695rdb; Thu, 18 Jan 2024 03:10:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IEfjp+PmMsfL+KM8bB/i5VOzb9I5Jgdcv6VLzZiU6ostZu5PvcfOXqzgl45urjfsVoMZa8s X-Received: by 2002:a05:6214:d65:b0:67e:d89f:e392 with SMTP id 5-20020a0562140d6500b0067ed89fe392mr788779qvs.11.1705576245443; Thu, 18 Jan 2024 03:10:45 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705576245; cv=pass; d=google.com; s=arc-20160816; b=Y2D9IrZee9y7m+ZWrezvmH3nouZ+2wqVsYKRW/2WGH0PIPvTes2JoGRUbNG9+6TwXG T+PzUeQ681lHZ0m2Q9zB25UhvXW6ek8msDCZy0hw9tBhVMtkQEXWc2Jb7h6PnQG+bpRf p7jCxqZvRK+zg5ZehoimbJvatiZLypEh+ML5fd7nsEhHYdJMCoLCyZYgKjL1u0t6+rci hbtMgUaen8pWkSblGGZ4anGv0EskcRtXa4kBExddEEgy4nm3k3cJCzfr99dGlTDW9/5p 06v1jOvHHsxE1tnt8CnaMyYbSZwcPDgKEttSs/YGRk8AfbnW8uRh9jMlzBQplNE3AqWH ttZA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=QcpOCuFcl9soU6pTrSQeC/VBrMuEv6Xtf/AwXXHCSZg=; fh=vc72cqMtTxQAMyizXvYN6Azr7Hu29gAS/vKaMF1SFgk=; b=J8J/xhe6+BE87LnbGFImck+PlRyT0JpFm42afWBClPscXZge+j6OMtU4l1GKyuUAne Aqe0rm9pbJKK2EkUKYoS7Svs01XhkxFQwEazTTMTKq4b9XgUxZ9U2fA2OZ8uYwWRk4sr FKQsmq7Arnrnm7bAQwrs81YcBITTotz579vYFjCbQ+A5X9Di3pWrHzbWv3EBoiWlSmvE 6b9qVaozVRxyf+2sNxg/AQwI3WKXpYd4Y4ytfT/S0gdHEZtAkg44Y0qQfUYu0W+T4/Pd WMg1Jck83aO7g78PvU9XcSSF6sgMaq834Gvab8U2VozRqztcB0mP5GaB/7os2I33zNhV 2pFA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=bLzP5bw8; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-30029-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-30029-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id t5-20020a0cc445000000b0067f2fca6cb7si13558282qvi.22.2024.01.18.03.10.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jan 2024 03:10:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-30029-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=bLzP5bw8; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-30029-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-30029-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 28CC31C2082E for ; Thu, 18 Jan 2024 11:10:45 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 73A04241F0; Thu, 18 Jan 2024 11:10:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="bLzP5bw8" Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A09C422068; Thu, 18 Jan 2024 11:10:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.55.52.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705576229; cv=none; b=PEdOCx0OYmxiVg2W//Pe2r+ipxGdY0WEeY2g0iwm1wirGcsZOKf5Pcwd9Many+FvJtReWNl+W5n9Ko7CQHco4QxbEoKBsnkMLGo6RUWxJhKMzWWpMd7jW0wDcSL+dD93JYETXV1HnBVNeF8AJeIVriW4Djdf7bgsUeVVoHDArps= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705576229; c=relaxed/simple; bh=07FNtxDV64G/dYussRz0AVKbrFzrHIChmm+6ZAmMYVw=; h=DKIM-Signature:X-IronPort-AV:X-IronPort-AV:Received:X-ExtLoop1: X-IronPort-AV:Received:From:To:Cc:Subject:Date:Message-Id:X-Mailer: MIME-Version:Content-Transfer-Encoding; b=p/GF/U7KZlmtiR5kkgmNna4EngnRKS5RmED2WLDTRHNZiQGPteA3YZZ+JxA1k7tDxOkdpqS8sEkpvhhhgauwy5O2er6Vn8WLbGm0rLDK0tlhfTzld6BUGqBQ/fXMq2Lt+bv3FqQmZK+1QmsASU+i8UjcKwzZe4RkBjqnBfGTgCc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=bLzP5bw8; arc=none smtp.client-ip=192.55.52.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1705576227; x=1737112227; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=07FNtxDV64G/dYussRz0AVKbrFzrHIChmm+6ZAmMYVw=; b=bLzP5bw8+jOQcZzcU5cOFugkbk2GwSN09gHhM96lfL995btZs5wIZHJX Scc8CqlbGy2BuoKBMvuZwuIHqzfU/9Y9CWtEdZ9GFaW9OHQffkMcGvJHg oDLODZS9WLEzkjGne772wAgh6ZQ+P/dMM2sV4HiMfvzbiJCzUoeN+Mosv 7vGsK3fQC6TJC0J6cmM+i/5NsEATwufdOHv8A0oNgvrlVOuu632n7ttIz sV0LTpuAcS39/daZEHMs7Yd/NbuxwhXrcGHnrx+IDwqTjiJsmja2kjmiR n8w5RhlQBi3H12390ZLYWwPcu5lwIWnfh+uX7IHdhfj05zCQEOy4BwaKl w==; X-IronPort-AV: E=McAfee;i="6600,9927,10956"; a="486571165" X-IronPort-AV: E=Sophos;i="6.05,201,1701158400"; d="scan'208";a="486571165" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2024 03:10:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,201,1701158400"; d="scan'208";a="262406" Received: from amlin-018-114.igk.intel.com ([10.102.18.114]) by fmviesa003.fm.intel.com with ESMTP; 18 Jan 2024 03:10:24 -0800 From: Arkadiusz Kubalewski To: netdev@vger.kernel.org Cc: vadim.fedorenko@linux.dev, jiri@resnulli.us, davem@davemloft.net, milena.olech@intel.com, linux-kernel@vger.kernel.org, pabeni@redhat.com, kuba@kernel.org, mschmidt@redhat.com, Arkadiusz Kubalewski Subject: [PATCH net v5 0/4] dpll: fix unordered unbind/bind registerer issues Date: Thu, 18 Jan 2024 12:07:15 +0100 Message-Id: <20240118110719.567117-1-arkadiusz.kubalewski@intel.com> X-Mailer: git-send-email 2.38.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Fix issues when performing unordered unbind/bind of a kernel modules which are using a dpll device with DPLL_PIN_TYPE_MUX pins. Currently only serialized bind/unbind of such use case works, fix the issues and allow for unserialized kernel module bind order. The issues are observed on the ice driver, i.e., $ echo 0000:af:00.0 > /sys/bus/pci/drivers/ice/unbind $ echo 0000:af:00.1 > /sys/bus/pci/drivers/ice/unbind results in: ice 0000:af:00.0: Removed PTP clock BUG: kernel NULL pointer dereference, address: 0000000000000010 PF: supervisor read access in kernel mode PF: error_code(0x0000) - not-present page PGD 0 P4D 0 Oops: 0000 [#1] PREEMPT SMP PTI CPU: 7 PID: 71848 Comm: bash Kdump: loaded Not tainted 6.6.0-rc5_next-queue_19th-Oct-2023-01625-g039e5d15e451 #1 Hardware name: Intel Corporation S2600STB/S2600STB, BIOS SE5C620.86B.02.01.0008.031920191559 03/19/2019 RIP: 0010:ice_dpll_rclk_state_on_pin_get+0x2f/0x90 [ice] Code: 41 57 4d 89 cf 41 56 41 55 4d 89 c5 41 54 55 48 89 f5 53 4c 8b 66 08 48 89 cb 4d 8d b4 24 f0 49 00 00 4c 89 f7 e8 71 ec 1f c5 <0f> b6 5b 10 41 0f b6 84 24 30 4b 00 00 29 c3 41 0f b6 84 24 28 4b RSP: 0018:ffffc902b179fb60 EFLAGS: 00010246 RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000000 RDX: ffff8882c1398000 RSI: ffff888c7435cc60 RDI: ffff888c7435cb90 RBP: ffff888c7435cc60 R08: ffffc902b179fbb0 R09: 0000000000000000 R10: ffff888ef1fc8050 R11: fffffffffff82700 R12: ffff888c743581a0 R13: ffffc902b179fbb0 R14: ffff888c7435cb90 R15: 0000000000000000 FS: 00007fdc7dae0740(0000) GS:ffff888c105c0000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 0000000000000010 CR3: 0000000132c24002 CR4: 00000000007706e0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 PKRU: 55555554 Call Trace: ? __die+0x20/0x70 ? page_fault_oops+0x76/0x170 ? exc_page_fault+0x65/0x150 ? asm_exc_page_fault+0x22/0x30 ? ice_dpll_rclk_state_on_pin_get+0x2f/0x90 [ice] ? __pfx_ice_dpll_rclk_state_on_pin_get+0x10/0x10 [ice] dpll_msg_add_pin_parents+0x142/0x1d0 dpll_pin_event_send+0x7d/0x150 dpll_pin_on_pin_unregister+0x3f/0x100 ice_dpll_deinit_pins+0xa1/0x230 [ice] ice_dpll_deinit+0x29/0xe0 [ice] ice_remove+0xcd/0x200 [ice] pci_device_remove+0x33/0xa0 device_release_driver_internal+0x193/0x200 unbind_store+0x9d/0xb0 kernfs_fop_write_iter+0x128/0x1c0 vfs_write+0x2bb/0x3e0 ksys_write+0x5f/0xe0 do_syscall_64+0x59/0x90 ? filp_close+0x1b/0x30 ? do_dup2+0x7d/0xd0 ? syscall_exit_work+0x103/0x130 ? syscall_exit_to_user_mode+0x22/0x40 ? do_syscall_64+0x69/0x90 ? syscall_exit_work+0x103/0x130 ? syscall_exit_to_user_mode+0x22/0x40 ? do_syscall_64+0x69/0x90 entry_SYSCALL_64_after_hwframe+0x6e/0xd8 RIP: 0033:0x7fdc7d93eb97 Code: 0b 00 f7 d8 64 89 02 48 c7 c0 ff ff ff ff eb b7 0f 1f 00 f3 0f 1e fa 64 8b 04 25 18 00 00 00 85 c0 75 10 b8 01 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 51 c3 48 83 ec 28 48 89 54 24 18 48 89 74 24 RSP: 002b:00007fff2aa91028 EFLAGS: 00000246 ORIG_RAX: 0000000000000001 RAX: ffffffffffffffda RBX: 000000000000000d RCX: 00007fdc7d93eb97 RDX: 000000000000000d RSI: 00005644814ec9b0 RDI: 0000000000000001 RBP: 00005644814ec9b0 R08: 0000000000000000 R09: 00007fdc7d9b14e0 R10: 00007fdc7d9b13e0 R11: 0000000000000246 R12: 000000000000000d R13: 00007fdc7d9fb780 R14: 000000000000000d R15: 00007fdc7d9f69e0 Modules linked in: uinput vfio_pci vfio_pci_core vfio_iommu_type1 vfio irqbypass ixgbevf snd_seq_dummy snd_hrtimer snd_seq snd_timer snd_seq_device snd soundcore overlay qrtr rfkill vfat fat xfs libcrc32c rpcrdma sunrpc rdma_ucm ib_srpt ib_isert iscsi_target_mod target_core_mod ib_iser libiscsi scsi_transport_iscsi rdma_cm iw_cm ib_cm intel_rapl_msr intel_rapl_common intel_uncore_frequency intel_uncore_frequency_common isst_if_common skx_edac nfit libnvdimm ipmi_ssif x86_pkg_temp_thermal intel_powerclamp coretemp irdma rapl intel_cstate ib_uverbs iTCO_wdt iTCO_vendor_support acpi_ipmi intel_uncore mei_me ipmi_si pcspkr i2c_i801 ib_core mei ipmi_devintf intel_pch_thermal ioatdma i2c_smbus ipmi_msghandler lpc_ich joydev acpi_power_meter acpi_pad ext4 mbcache jbd2 sd_mod t10_pi sg ast i2c_algo_bit drm_shmem_helper drm_kms_helper ice crct10dif_pclmul ixgbe crc32_pclmul drm crc32c_intel ahci i40e libahci ghash_clmulni_intel libata mdio dca gnss wmi fuse [last unloaded: iavf] CR2: 0000000000000010 v5: - change order of patches: [v4 4/4] -> [v5 1/4], [v4 1/4] -> [v5 2/4], [v4 2/4] -> [v5 3/4], [v4 3/4] -> [v5 4/4] Arkadiusz Kubalewski (4): dpll: fix broken error path in dpll_pin_alloc(..) dpll: fix pin dump crash for rebound module dpll: fix userspace availability of pins dpll: fix register pin with unregistered parent pin drivers/dpll/dpll_core.c | 67 +++++++++++++++++++++++++++++++------ drivers/dpll/dpll_core.h | 4 +-- drivers/dpll/dpll_netlink.c | 57 ++++++++++++++++++++++--------- 3 files changed, 99 insertions(+), 29 deletions(-) base-commit: ea937f77208323d35ffe2f8d8fc81b00118bfcda -- 2.38.1