Received: by 2002:a05:7412:ba23:b0:fa:4c10:6cad with SMTP id jp35csp284848rdb; Thu, 18 Jan 2024 03:38:41 -0800 (PST) X-Google-Smtp-Source: AGHT+IHm0/5TdYjMjuPnq5oNPmWB0AG5xUrvPeJphzHbV8M7Gpg7p+N6NtqHCsVDDf43ptJCQd5z X-Received: by 2002:a17:902:ce8e:b0:1d5:c3b0:1bdb with SMTP id f14-20020a170902ce8e00b001d5c3b01bdbmr779578plg.2.1705577920764; Thu, 18 Jan 2024 03:38:40 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705577920; cv=pass; d=google.com; s=arc-20160816; b=uYKSnM59E83jCzt5L4yKYm9Z9URMJZSulluRKR1iIc77x7hB1xwcIWVjjh0hvQHhyF fOv+cL/0cS4a2OgBsbCmdP0N6OdITozU5/GcI8BPkqZB3YSXSQr/lSuy6VVDp9i6XsMP l+I5Po8n3IMDR73GaMzpEVrWlgqsVyUHU1/lOFtfRx1qwL2r3DRukmvsrmBlM3SNWDXu dsNW4FITQd9dXk8muHSWvLZ9YOUXnlpj6nqYn3Y7H9bvVn8x7AQ+4Ji8N2eXviGx+7du QokuQqFHEi5M7jGDbDHgWLX9kmbdtTJ5eWgNybulbE3eW8RNVRtthG7vPhOUV5IeaaAp bTcw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=GVdU1A74qUHSIDgwEfJ6kfyoxaDoAPC8NwCrvfgSTKE=; fh=/sJeVW4dOqmkGwl/hE3kEHsH4Q9sVDyXq0yPjqS5nww=; b=zafDUdqCUYYLSZ4G2GBW4GvIiZGyw/aEELU4P8UpvX2h97Upt8DWMQTzT2bChZ8pZg ySOUP0YUhOMA/TkeF0cRBRc0AuM7T0jUihxzVJkXBk9owcaPGFyEvmWJq2/nz3czbhpL 9jrTPxKUiRjGP9HrOogGV46WOSIG4Ky4Ejm8ZDs1F0utK28kVv9MDgifLd8YMS9Z+9vI 5mfbWEv1xUPIsAOw/7EpjpZiLDCt9uffdmmpnqfVlOI9xDXNahgShsJd59YiO3IhlH/1 NkCpp/s6o3gV7MUvLmuLN2DT4pTdF2JH8YkyLG6n9X/RDH6Hv3E8rwZjx478fM42l7OD bSHA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=RaQbvfru; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-30060-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-30060-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id x13-20020a170902ec8d00b001d489431171si1351139plg.488.2024.01.18.03.38.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jan 2024 03:38:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-30060-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=RaQbvfru; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-30060-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-30060-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id CE599284707 for ; Thu, 18 Jan 2024 11:38:38 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8AE3D2420F; Thu, 18 Jan 2024 11:38:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RaQbvfru" Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 39860241FB for ; Thu, 18 Jan 2024 11:38:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705577911; cv=none; b=Z2uEhJ2/jr2vnLGNwIRFv1blhc7hYKkoDl05n5s54EOzEooxGD7/l/NyUnAdmjfkw7VLAxxxt5VicurTJ3uENJlrtpjHOefbxtAdwcvQ3BnwfMQizBl/yxi6YmmLlKBIsxbBfSJ1K/uTbGHsTUR3d2+hpSJXVX3tza1zNWTeSsM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705577911; c=relaxed/simple; bh=JzXspu+B6FBrN8pCVJrEuM4Ry5P/lCfwFyfAEVzd/mE=; h=Received:DKIM-Signature:X-Google-DKIM-Signature: X-Gm-Message-State:X-Google-Smtp-Source:X-Received:MIME-Version: References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc: Content-Type:Content-Transfer-Encoding; b=kgTD76birYM1LN3MOfK5X9mVY4B6e1ZXC0DUSucFwwVYijukMw7+tD2f7VZEn60C9OSF1GHibYVvZCryk+XVfx1ogSEsGMsz1TM6wavJ+F0vyX+QB9bx5nna5/J6+lW45F/cRLe7hV5gIbMLNcl/Wm/aS4mGas91Pr0OFXX4Frc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RaQbvfru; arc=none smtp.client-ip=209.85.167.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-50e72e3d435so11776010e87.2 for ; Thu, 18 Jan 2024 03:38:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705577908; x=1706182708; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=GVdU1A74qUHSIDgwEfJ6kfyoxaDoAPC8NwCrvfgSTKE=; b=RaQbvfrui5GJ6GvvcAeOx7RXaTo8vDSIsGX90rIK8M6uEQYPS/RlUIruUHLI9QUJwB ErbklyuGapsZXpsT/ap2tbVdpDWromlyJDPaM08K7py8y70ipe+5cegIPC6kIRIOxHwa MD9EkRQMqCPCojmjYW7MUdQEN1VCVBnaSygTZQ46RLxz0sYi5BDgZn9aBfLynOXvcecS W8hqXpe/LNJNgJjFHD1Y4kHlLVDtcMcKlmULwKOmE2d0rTn0J+0QS0p6P1QEtwUZEOei nKxBbpaYRVhlI48ZOS8oxptoftJqLzXCJbW4uLE/AHaLZeN3bqza2BfrqNk7fzWIVm/K XKnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705577908; x=1706182708; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GVdU1A74qUHSIDgwEfJ6kfyoxaDoAPC8NwCrvfgSTKE=; b=BovILzEh+xNVa8gReTWUeT8l6jSHVkmf0jhm9FXEMgIkmMYSDUssUJafuEOmML42Ul qXnvFp3wEvDt9XQAfB5LVb4UBkXgp5642oyuWeFgYFCGdlh/6KNg0dag+Gu+07yOZwid OMJy/sIsyw+cghptNCXYrgjCjln341yqWr8rVyrZFHA6LiGQBTMGZPHrCzwPKo+tF2jt 8LAPE/6SbJJ3oDDeFptSZQrqqCGRp0R39Fyl8nMTAkDm1lwXri3mJujCJ1CBSup2skHP GPCYVs9Z7EBWpl+y4Wbf9pTbG5P9MPtefU+kOUzbyNnvZ0jECSPqNO39miEvL0XuljEF zzWA== X-Gm-Message-State: AOJu0Yxo5UHPjn9UahmYH9TH2EwM9nugXZ86ewWlhgg/TM4EI45y4hzS 3n/7HjsXjA/nNbVDav4xt4l0hIfpHz41kiOgr67ac1IlA1x59zlNgXNPkgze7CJ9DgrrsnrNd39 K0ulNSDUmjLaMF/Hy/FRhOjhuflU= X-Received: by 2002:ac2:5de8:0:b0:50e:aac2:b88d with SMTP id z8-20020ac25de8000000b0050eaac2b88dmr261576lfq.94.1705577907999; Thu, 18 Jan 2024 03:38:27 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240117031212.1104034-1-nunes.erico@gmail.com> <20240117031212.1104034-5-nunes.erico@gmail.com> In-Reply-To: From: Erico Nunes Date: Thu, 18 Jan 2024 12:38:15 +0100 Message-ID: Subject: Re: [PATCH v1 4/6] drm/lima: handle spurious timeouts due to high irq latency To: Qiang Yu Cc: dri-devel@lists.freedesktop.org, lima@lists.freedesktop.org, anarsoul@gmail.com, Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Sumit Semwal , christian.koenig@amd.com, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Jan 18, 2024 at 3:46=E2=80=AFAM Qiang Yu wrote: > > On Wed, Jan 17, 2024 at 11:12=E2=80=AFAM Erico Nunes wrote: > > diff --git a/drivers/gpu/drm/lima/lima_sched.h b/drivers/gpu/drm/lima/l= ima_sched.h > > index 6a11764d87b3..34050facb110 100644 > > --- a/drivers/gpu/drm/lima/lima_sched.h > > +++ b/drivers/gpu/drm/lima/lima_sched.h > > @@ -29,6 +29,8 @@ struct lima_sched_task { > > bool recoverable; > > struct lima_bo *heap; > > > > + struct dma_fence *done_fence; > This is same as the following fence, do we really need a duplicated one? Checking again now, I think we can reuse the existing one.