Received: by 2002:a05:7412:ba23:b0:fa:4c10:6cad with SMTP id jp35csp300914rdb; Thu, 18 Jan 2024 04:10:33 -0800 (PST) X-Google-Smtp-Source: AGHT+IF5ywxXvRlgsIY+U/pb4tpOE1YcXlB1bT2lh6hD0rRUkmjEV984aHAsvh4ACH0OPxC2dCYy X-Received: by 2002:a17:907:8dc6:b0:a23:339f:3313 with SMTP id tg6-20020a1709078dc600b00a23339f3313mr634322ejc.55.1705579833416; Thu, 18 Jan 2024 04:10:33 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705579833; cv=pass; d=google.com; s=arc-20160816; b=qhsnhGQ8T4yIFizgAWSZAcOu29dFx7DycxWs27zUgwHf50eqt7WxIO1G5iGd9U6idV vSbPyPuAN2q2TSSLDx7rUntRlV/zLuJGd3SZ8UuHGjTVHt8lZceZ0CUuat0APWZJaRgI 18SOcoQEeBggQU2BDiZU8v6aHfdFEIHtfqaZUYSSsFiTEBPECh+Ybs2Q08Gv4Kpbmw0H QzCo9rTRRnYEvggcOG1npilwKiWwYxKnFGZ+SRgfJSNTZ+Mcxy018xozhGXrS8lU/hHV I4oTAwkXk3dAQJCxr9toOJ+yebNe+H9ttrAVk0U7fTkw79kXYBSvEgQTWLhp7SMPUw6n 1U+g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id; bh=SX/XZn1POQYwG2J1Ew30vmx5YXraU0+ilMQjpyd+s4c=; fh=wMUm8lHAF+oMLAE96APUIAhFKKtvi92ZPQPCtf5iclU=; b=WNtX9JgqF0HMZuddZ9+fNrbsUMV0hlnLdj5MV3GnW5AHptnZTeJfRIq+Y+PMmCamEM Wa524C3Vjxiox+T65tIoputcpz2C38F0FgC0Gfsz2eByOWuCLFX1bLdnUUUqCqvwe/rs UpwgTTZzGJZf0goXVaF+YHzC9pW9EurmyJzOlcqwifV/IY+51A+yMuRI2K6sPsoSC/b6 HyTq2elpBp91CcHdFaGvTm6gRma7ZQ35DLLd8V0JA/OsaW/2UIHlWwDZEG1t9ispyksg Onffi6FyShdQ9fvbxPESv4UuHfCBZ6M1eIaFJQnZotQbCMwwo8TIxxO1xdS9JEDcLAUV YUAg== ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=arm.com dmarc=pass fromdomain=arm.com); spf=pass (google.com: domain of linux-kernel+bounces-30083-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-30083-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id d10-20020a170906c20a00b00a2a5ed4c4e4si6835200ejz.155.2024.01.18.04.10.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jan 2024 04:10:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-30083-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=arm.com dmarc=pass fromdomain=arm.com); spf=pass (google.com: domain of linux-kernel+bounces-30083-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-30083-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 2CFD31F2446D for ; Thu, 18 Jan 2024 12:10:33 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5B54824B4C; Thu, 18 Jan 2024 12:10:21 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6468C24B32 for ; Thu, 18 Jan 2024 12:10:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705579820; cv=none; b=TuFk78hGF/bqg0Id4jxO2wi6i9/Oe63xPshISnywvm9BgkuqyKnd8qD3Cn3ZOTsUfKQYZW9k0FqzQFICfUsGufpLRShmLCHZqHweUSk1QhUt46BJjv6HfL2qCuYnnH57dGaZROvBodOoc+sRSLDITIVeVCZ8aaqBtLcZrrPdYLU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705579820; c=relaxed/simple; bh=6psjQ1uD9PMdcSnhUZ2DvHkE/3zowXNYTyjhRH/uRjo=; h=Received:Received:Message-ID:Date:MIME-Version:User-Agent:Subject: Content-Language:To:Cc:References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding; b=R5fejShQ8VQQhSAVeAQ1hikNuZYpbly4AliFUV3BnYtvrnErpJy05y3rveFTcGu4EJ+rcZOwcxKBlSahK0BdYarYB+PH4+RZxL+LWduBpRcGVpa2rG6V9Ol0EUttdoyJSWNGLWPZuuth9n+LhETenBhpLN3Tm39zyueGizsXEAI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3E38D1042; Thu, 18 Jan 2024 04:11:03 -0800 (PST) Received: from [192.168.2.88] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 20CFE3F5A1; Thu, 18 Jan 2024 04:10:14 -0800 (PST) Message-ID: Date: Thu, 18 Jan 2024 13:10:02 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [Resend PATCH] topology: Set capacity_freq_ref in all cases Content-Language: en-US To: Vincent Guittot , mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, sudeep.holla@arm.com, gregkh@linuxfoundation.org, rafael@kernel.org, linux-kernel@vger.kernel.org Cc: lukasz.luba@arm.com, ionela.voinescu@arm.com References: <20240117190545.596057-1-vincent.guittot@linaro.org> From: Dietmar Eggemann In-Reply-To: <20240117190545.596057-1-vincent.guittot@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 17/01/2024 20:05, Vincent Guittot wrote: > If "capacity-dmips-mhz" is not set, raw_capacity is null and we skip the > normalization step which includes setting per_cpu capacity_freq_ref. > Always register the notifier but skip the capacity normalization if > raw_capacity is null. > > Fixes: 9942cb22ea45 ("sched/topology: Add a new arch_scale_freq_ref() method") > Signed-off-by: Vincent Guittot > --- Reviewed-by: Dietmar Eggemann Tested-by: Dietmar Eggemann (on h960 w/ and w/o capacity-dmips-mhz in dts file) [...]