Received-SPF: pass (google.com: domain of linux-kernel+bounces-30113-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <9b370036-bf3a-49d3-99a0-5c11eaca4e6f@digi.com>
Date: Thu, 18 Jan 2024 13:44:23 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 1/3] gpio: vf610: add support to DT 'ngpios' property
Content-Language: en-US
To: Bartosz Golaszewski <brgl@bgdev.pl>,
 Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: linus.walleij@linaro.org, robh+dt@kernel.org,
 krzysztof.kozlowski+dt@linaro.org, andy@kernel.org, conor+dt@kernel.org,
 shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de,
 festevam@gmail.com, linux-imx@nxp.com, stefan@agner.ch,
 linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org
References: <20240117083251.53868-1-hector.palacios@digi.com>
 <20240117083251.53868-2-hector.palacios@digi.com>
 <CAHp75Vci=1nAvxRcbkK2SxGWGbQVbzQMTycMt8tZ5snPRTYXOg@mail.gmail.com>
 <fd5550ad-76c0-419b-aa07-a0493a57286e@digi.com>
 <CAHp75Vf4wXLEjmfpz6KQSCB0Jd8LNv6+SU_ikbhR_8PsJHuq-g@mail.gmail.com>
 <CAMRc=MfAW5NDJHtZ1333-xrcCyQfft-pQF1-0Vv_ehY16agShw@mail.gmail.com>
From: Hector Palacios <hector.palacios@digi.com>
Organization: Digi
In-Reply-To: <CAMRc=MfAW5NDJHtZ1333-xrcCyQfft-pQF1-0Vv_ehY16agShw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZkNnS3U4bVIxT1M2MzlVYWhFc0I5R01SZUNXMENreXVXZ3JtbWgyTGFEV2d6?=
 =?utf-8?B?QkxSbGV3OURoRmtYUGUrdlZTVTNIVkIwZFlXNGs0VDV2ZGhMSU43ZzB2WHR5?=
 =?utf-8?B?VXdRV2NkK1BEZzh2RUhiOWRwd0pmYi9lRGFvN3lacFdjZEdTdTFkM1NCTDJ6?=
 =?utf-8?B?ajU4YlFYbDdPMzFRbi9aSWE5N1Mwdkl4QVgvVWFKVFEwQmMvcFY0NlpweE9K?=
 =?utf-8?B?dGVuR3VwYVR4K2pXZjE1dnlidzFyRFI3SU14ejc3R092YjFWRS9XZU9OcGp4?=
 =?utf-8?B?ZnVmdGRZWVJtVTR6QnBXd2N4VUd5eTlZcS8zTFJ2MXl1RVlKVEFWTjVSWVBS?=
 =?utf-8?B?Wk9JQ0FrQlNZSktIYWlUU1ZON0dNbUk0UE9KSzV3K0VkR2pFVHpNbEQxUDF6?=
 =?utf-8?B?Q3czZWwvRjl1dENvWGdZMVVsWDl1Y2NSWms2cmF4MHJvVW9yUEZ4b2pmajBF?=
 =?utf-8?B?SWR5QzBHYXRhSFMrUUJoV0JnYmhNR0cwdmx6ODAzNmJ4Yk40Z1F0dHRXZUcx?=
 =?utf-8?B?bGJSR1dRR2lGcG8yVlJnZmhsSVVjRU83NzhkNGhIbWdTQWQrek1VOUNsWnZM?=
 =?utf-8?B?cGNFek5meXAwcFdmMnhObHc5OWFMMENLUTBJcGtleTh5ek5lU2Fpa08velpP?=
 =?utf-8?B?UDh0M1hPaUczYllLZGxaNXdudkNyTHp4ak1idjJxNHpRMFhXNDRiNDZjYk5n?=
 =?utf-8?B?c1ZMTUExdGFEcG1kL3BvbnRma1B1cE1Rc1VmMUpYS05hZ0lkdFJ2QkpZY0U3?=
 =?utf-8?B?MzRaeXUzdEl6R09kRkRKOWEzelVYSllZVXRuQ2Z0M3VmQlo1S3NtUUpkd2k0?=
 =?utf-8?B?SFBwZlVuOVVhV1RhT0tqeVhydGcvd1Mrd3BxTXZDUXh3TVpzaDExZWgzRjg0?=
 =?utf-8?B?d3d5OXlGSCswNjhXMXBRQTBwUEhSejNJc0Iydk5VWENKdFU5NHRlQWdkM1NZ?=
 =?utf-8?B?S0YzMGNXTEVYSE8xN1hTY1krdWpKTE1iKzltZnFpM1BES20yQTlCUHdRWmNt?=
 =?utf-8?B?QmoyZGhIRUxNL29ZK3A3TFhtbFRNdk5HYVB0ZnRsMHZ1NVJnbVhNc2F2ZjVl?=
 =?utf-8?B?OTFkdzJHVXlwWjYzcklWNElUVnQ2a1JhOW5RNnlhdWd0T2Z0QksrTjhtZlFH?=
 =?utf-8?B?RHhqR2pQL1ZGYkE4cHR3TUZpNzRwbkwvVVhpSnA5TVdjOU40YmNFcUw0R0Ft?=
 =?utf-8?B?VmNLZkJFKzl6K2ZkZFgwVTB4OG9NZnFPSmpzVmpXSlBFSHlKUWtWZjloQk1h?=
 =?utf-8?B?V2FFVVh3VWgxSDFPNTdnQjRVTFdaNWtiL2czUzF2cmlpdnE3MU1nUVNOS3d2?=
 =?utf-8?B?bHB2TUVwT2pUS3J2L01vQjgwN0RYZ2Zjb1cyUndRd2xPcVJXbHpRU01WRkxl?=
 =?utf-8?B?QU1hNkswdWpVZWhybXZVNDN5VGp0cjdvK3VlblFoWGthSDU5dkVLcFhJbUZr?=
 =?utf-8?B?blhuSlVWRjRyQS8xMXRjMXZMYk9pNmFLVTQ2UkhKVExzTW9NZTB3UWJQMHJQ?=
 =?utf-8?B?OUo0MEhrVldqYmxPQlVUUlpKWWU3bVpJUE9iQ3F2TS9SbERSMHdJd0JtRHRo?=
 =?utf-8?B?aysxanZRTUFZNU0wUWNkcGtEYkdNVEVYbloyMVVhdlNLUFJBTmsxM2ZsaXI3?=
 =?utf-8?B?WTJrT2hMWGt3QW1HdUFxSzFSRzdtOXBpdERKZHhBZW1vQzBIcE9hZkZvUlNN?=
 =?utf-8?B?L0k4RkJURHcyWUpuakhadDgyVVQ2eVpSM09FRDBxOTI0MVJ4ck5VRGRHUkJY?=
 =?utf-8?B?WHNtRnh5aWp0aG1YT3hqckVuVndpMWErVDkyQVB0R0VFbGVhUmpHWmY3SWFp?=
 =?utf-8?B?Z2l2dUtPZDJoc29CRnMxQWRHWXRnTk5vSmFObHE0a1E0VWdJOFQ1elBnbXc3?=
 =?utf-8?B?NjBIQkJDV1VSdjFzejgrbUNoYWg0Yzl6OUprQkt2ak1rTUg1TXN5eWt0elVj?=
 =?utf-8?B?SExFYlZyeUE3QTYvM2dRSXBNQ2FGOW56SWRqTDg3TEUxUVAxbWR0UXRZNHBi?=
 =?utf-8?B?cTNwdk9TM2xGcmhrVU5hcExudzE2VFljWUR6SklEK3IvaGZYYTZwNmloSWJG?=
 =?utf-8?B?bmQ1dTBZSXNNM3hoTVBhRktKeUhVSTVRUVJDa3oxd21YN1FKbmxlTVZXZi9Q?=
 =?utf-8?Q?m5sk/71pIGbNidFJb8lQqBkkp?=
X-OriginatorOrg: digi.com
X-MS-Exchange-CrossTenant-Network-Message-Id: aa34c9bf-413b-4051-d95c-08dc18233825
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4370.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jan 2024 12:44:32.8055
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: abb4cdb7-1b7e-483e-a143-7ebfd1184b9e
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yCx62WIueJDsIlMrnQGKGFZILqeh6Og3H0FMUyqBDMnUD5wvLSkNkq8/ZC3+vXPIVZi9tlxFvYL9az6MR8HHKQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4513
X-BESS-ID: 1705581876-104535-12453-16414-1
X-BESS-VER: 2019.1_20240103.1634
X-BESS-Apparent-Source-IP: 104.47.58.100
X-BESS-Parts: H4sIAAAAAAACA4uuVkqtKFGyUioBkjpK+cVKVoamRqZAVgZQ0Nw00dDCICnJON
	ks0dwozdzUJNHEIiXVwiI5KS0pLc1EqTYWAJCL+RdBAAAA
X-BESS-Outbound-Spam-Score: 0.50
X-BESS-Outbound-Spam-Report: Code version 3.2, rules version 3.2.2.253598 [from 
	cloudscan10-60.us-east-2a.ess.aws.cudaops.com]
	Rule breakdown below
	 pts rule name              description
	---- ---------------------- --------------------------------
	0.00 BSF_BESS_OUTBOUND      META: BESS Outbound 
	0.50 BSF_SC0_SA983          META: Custom Rule BSF_SC0_SA983 
X-BESS-Outbound-Spam-Status: SCORE=0.50 using account:ESS112744 scores of KILL_LEVEL=7.0 tests=BSF_BESS_OUTBOUND, BSF_SC0_SA983
X-BESS-BRTS-Status:1

On 1/18/24 13:03, Bartosz Golaszewski wrote:
> 
> On Thu, Jan 18, 2024 at 10:04 AM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
>>
>> On Thu, Jan 18, 2024 at 10:25 AM Hector Palacios
>> <hector.palacios@digi.com> wrote:
>>> On 1/17/24 21:51, Andy Shevchenko wrote:
>>>>> Some SoCs, such as i.MX93, don't have all 32 pins available
>>>>> per port. Allow optional generic 'ngpios' property to be
>>>>> specified from the device tree and default to
>>>>> VF610_GPIO_PER_PORT (32) if the property does not exist.
>>
>> ...
>>
>>>>> +       ret = device_property_read_u32(dev, "ngpios", &ngpios);
>>>>> +       if (ret || ngpios > VF610_GPIO_PER_PORT)
>>>>> +               gc->ngpio = VF610_GPIO_PER_PORT;
>>>>> +       else
>>>>> +               gc->ngpio = (u16)ngpios;
>>>>
>>>> This property is being read by the GPIOLIB core. Why do you need to repeat this?
>>>
>>> My apologies; I had not seen this.
>>> I'll use gpiochip_get_ngpios() on the next iteration.
>>
>> But still why?
>> https://elixir.bootlin.com/linux/latest/source/drivers/gpio/gpiolib.c#L867
>>
>> It's called for every driver.
>>
>> Maybe it's needed to be refactored to allow fallbacks? Then can the
>> GPIO MMIO case also be updated?
>>
> 
> I guess it's because Hector wants to set an upper limit on the number of GPIOs?

I think Andy is suggesting to rework the gpio-vf610 driver to use 
bgpio_chip struct (it doesn't currently), and then I guess the 'ngpio' 
property gets read automatically if you call bgpio_init().
-- 
Héctor Palacios