Received: by 2002:a05:7412:ba23:b0:fa:4c10:6cad with SMTP id jp35csp330116rdb; Thu, 18 Jan 2024 05:05:13 -0800 (PST) X-Google-Smtp-Source: AGHT+IFavlsbzS7Xo1eTpaKDL9dNWMsMlUSXO8z7g7+AJit77u9eWyksQLVTM5aYZV+WFM/+Rf9P X-Received: by 2002:a05:6402:1a30:b0:559:ccc4:157e with SMTP id be16-20020a0564021a3000b00559ccc4157emr595904edb.30.1705583113108; Thu, 18 Jan 2024 05:05:13 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705583113; cv=pass; d=google.com; s=arc-20160816; b=Sm7I8S2synrkFiGVagWrJxts1CQrnSpTO6/TGumX9yWwI2xDNVc4VWKQwOPDQr7bS/ pzC0VwczgmnMorR9ai5GbWUreNFcqhjTfvbmSR3iYsquDU0fTWVpjYNnbez52hnLhS90 N0GuXx/hzRdcC29/jd+zC/czhYMywFICzQdW5g8TWe2Td6M7TdpMr5eLTmgO/ydYG8Zv UnoSwpxdUsqN/4YA0IiAksaKszmNX96N9f4G8S6JyaNWjMIhY01yJ+YIGHet9DnHHelS O/vim8m0ELBo43MKqA6gdIKKI/39sSD2E1o6RGequ0XC2bO3e8lfaHe98CQZ0/pOMYKo CDHQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=date:message-id:user-agent:cc:to:references:in-reply-to:from :subject:content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature; bh=zC99iZbDtU2MbBcMCP6nOoGN7A+yKmyfA/Yd8YLODLQ=; fh=elkCitxqEiwydVJOHj+Bv6zD0ryATVWjGCzTCijw6so=; b=Jrvec0S/fM1kg70CE/K0SKb6kopKh2vC3lI3JrRTJfjZm4aPXIYujOL5e6fC/ZPepr c5gNh89gs22DcJFtAAMM/fGzwjD9G97FPQHf0CdKr3XJNbLG2ZHxjilNEulINSv8TkQo D96d7E+6tvrBPD99io993nl+79A2R1iFMbuW911trJYO3+wzw9uwibuAFrxVybN7V8r7 qjZduAKrKsOH61Bc6wRMjs5gTQggPx2cbBj1cEulKunL+4ga2HCGwCkP5DkMyayRTyCv JgfoTfHbg+ph09AWzGIWjrzpl7PLYSuoCVWuAZiMk/zFiWCDwYt5NJ2QTSmLneUzu4iQ ULsw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=L5Varki2; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-30129-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-30129-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id l20-20020a056402125400b00559e680ccd8si1339064edw.293.2024.01.18.05.05.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jan 2024 05:05:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-30129-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=L5Varki2; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-30129-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-30129-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id D983A1F22C3E for ; Thu, 18 Jan 2024 13:05:12 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A31BC2510C; Thu, 18 Jan 2024 13:05:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="L5Varki2" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6C3624B57; Thu, 18 Jan 2024 13:05:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705583104; cv=none; b=stcRkhqB1+emP6oAEcYbHqKo9Ml3Zsn2sP6G6JR8bHzGZ9SknAB9/4iP0GTs+a8GdoQQLb3xLYohC5UpsKElA4yILCA2TCX0KN0rQBk83wnSqDkolPOU9lBtmQdRrDJQC1pfen9wbHMF9qJMK/HTSLdE+YPkaEz4G4APVCDAI2U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705583104; c=relaxed/simple; bh=N0E3M1FXEk/M8+abhwlanetMGkMmya/Ds9xC17DAntA=; h=Received:DKIM-Signature:Content-Type:MIME-Version: Content-Transfer-Encoding:Subject:From:In-Reply-To:References:To: Cc:User-Agent:Message-ID:Date; b=MsrLJWQ1V6Pr5WletODLwnWYXhE42d3IqmRERWhTq1HuKkxBK2SeU0od4f7tY6f/9nr/FFDnQ2d9TXzZNEn/8DbXedIEODCi+7z8ayNheK89lk+xcYxsoS/9lg0E5WkC+1XKvXBrGIs4PQe2PB+aiSKnKxHTihr8G+OHUGGNKi8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=L5Varki2; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id DE060C433C7; Thu, 18 Jan 2024 13:05:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705583104; bh=N0E3M1FXEk/M8+abhwlanetMGkMmya/Ds9xC17DAntA=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=L5Varki2auyKh0ktZANIc+BPFQQa6dIJxVFhDdUzUz+Q2cuL5Bpmm0cEH/Fw0a/Y1 IN6wGdjYP/lP4X4/k8Uf6QsMBTy/fepkRMhtWSGTMWO+bARq0P2KrMUgRlR/VIOhWH FWP/1DdUWENTxIkwYdaOboWhtrZ45/IFLdnhHOLFkmVMoTbwjDbAeKuvwHRLTSssYl vcqBgWPUQmH6P1j6fxWcZWamtEU3L8ieSPPd9txwy4+3G//7FVTgyLebh1G9uTOvaJ +TMsVnOjqodbeRVuduuo3Ot6uH76h6weEcMU7SZ105ulBNYEEHGtvGzUDg7URsMxsp 9f205sagdwHiQ== Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [v2] wifi: brcmsmac: phy: Remove unreachable code From: Kalle Valo In-Reply-To: <20230814093621.289754-1-artem.chernyshev@red-soft.ru> References: <20230814093621.289754-1-artem.chernyshev@red-soft.ru> To: Artem Chernyshev Cc: Jonas Gorski , Franky Lin , Artem Chernyshev , Hante Meuleman , Arend van Spriel , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, SHA-cyfmac-dev-list@infineon.com, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <170558309941.2924528.648376255659040623.kvalo@kernel.org> Date: Thu, 18 Jan 2024 13:05:01 +0000 (UTC) Artem Chernyshev wrote: > wlc_phy_txpwr_srom_read_nphy() in wlc_phy_attach_nphy() can not > return false, so it's impossible to get true value in this > if-statement. Also change those functions return types to void > since no one using it. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Signed-off-by: Artem Chernyshev > Reviewed-by: Jonas Gorski Patch applied to wireless-next.git, thanks. 47f0e32ffe4e wifi: brcmsmac: phy: Remove unreachable code -- https://patchwork.kernel.org/project/linux-wireless/patch/20230814093621.289754-1-artem.chernyshev@red-soft.ru/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches