Received-SPF: pass (google.com: domain of linux-kernel+bounces-30162-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: Mathieu Othacehe <othacehe@gnu.org>
To: Conor Dooley <conor@kernel.org>
Cc: Primoz Fiser <primoz.fiser@norik.com>,  Rob Herring
 <robh+dt@kernel.org>,  Krzysztof Kozlowski
 <krzysztof.kozlowski+dt@linaro.org>,  Conor Dooley <conor+dt@kernel.org>,
  Shawn Guo <shawnguo@kernel.org>,  Sascha Hauer <s.hauer@pengutronix.de>,
  Pengutronix Kernel Team <kernel@pengutronix.de>,  Fabio Estevam
 <festevam@gmail.com>,  NXP Linux Team <linux-imx@nxp.com>,  Li Yang
 <leoyang.li@nxp.com>,  Stefan Wahren <wahrenst@gmx.net>,  Christoph
 Stoidner <c.stoidner@phytec.de>,  Wadim Egorov <w.egorov@phytec.de>,
  devicetree@vger.kernel.org,  linux-kernel@vger.kernel.org,
  linux-arm-kernel@lists.infradead.org,  upstream@lists.phytec.de
Subject: Re: [PATCH v2 2/2] arm64: dts: imx93-phycore-segin: Add Phytec
 i.MX93 Segin
In-Reply-To: <20240118-regretful-viewer-8d7dfc7a0802@spud> (Conor Dooley's
	message of "Thu, 18 Jan 2024 10:19:23 +0000")
References: <20240117074911.7425-1-othacehe@gnu.org>
	<20240117074911.7425-3-othacehe@gnu.org>
	<c1ef5c08-1ae9-4a22-8ca9-47673c023e1e@norik.com>
	<20240118-regretful-viewer-8d7dfc7a0802@spud>
Date: Thu, 18 Jan 2024 14:43:07 +0100
Message-ID: <87jzo6vjtg.fsf@gnu.org>
User-Agent: Gnus/5.13 (Gnus v5.13)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain


Hey,

> Please do not order properties alphabetically. Instead, please read
> the new documentation on property ordering that makes explicit what
> has just been convention until now:
> https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git/tree/Documentation/devicetree/bindings/dts-coding-style.rst?h=for-next&id=83a368a3fc8ae8538bccb713dc0cae9eacc04790#n112

Thanks for the link.

I have a question though. Regarding that section:

--8<---------------cut here---------------start------------->8---
/* SD-Card */
&usdhc2 {
	pinctrl-names = "default", "state_100mhz", "state_200mhz";
	pinctrl-0 = <&pinctrl_usdhc2_default>, <&pinctrl_usdhc2_cd>;
	pinctrl-1 = <&pinctrl_usdhc2_100mhz>, <&pinctrl_usdhc2_cd>;
	pinctrl-2 = <&pinctrl_usdhc2_200mhz>, <&pinctrl_usdhc2_cd>;
	bus-width = <4>;
	cd-gpios = <&gpio3 00 GPIO_ACTIVE_LOW>;
	no-sdio;
	no-mmc;
	vmmc-supply = <&reg_usdhc2_vmmc>;
	status = "okay";
};
--8<---------------cut here---------------end--------------->8---

The documentation states:

--8<---------------cut here---------------start------------->8---
Order of Properties in Device Node
----------------------------------

The following order of properties in device nodes is preferred:

1. "compatible"
2. "reg"
3. "ranges"
4. Standard/common properties (defined by common bindings, e.g. without
   vendor-prefixes)
5. Vendor-specific properties
6. "status" (if applicable)
7. Child nodes, where each node is preceded with a blank line
--8<---------------cut here---------------end--------------->8---

All of the properties in my example are falling into the "4" category I
guess, except for "status" that should come last. Now, how am I supposed
to order those properties? I had a look to other IMX device trees and it
is hard to establish a pattern. Pinctrl first, then alphabetical order?
Anything else?

Thanks for the guidance,

Mathieu