Received: by 2002:a05:7412:ba23:b0:fa:4c10:6cad with SMTP id jp35csp363826rdb; Thu, 18 Jan 2024 06:04:19 -0800 (PST) X-Google-Smtp-Source: AGHT+IFeEnjg5MJDIsexUXQvGlt0qC6835DU4+ybt7vWrxglYPW8wIhttGkWFZbAthxMigolIUfz X-Received: by 2002:a05:6830:e88:b0:6e0:c975:5417 with SMTP id dp8-20020a0568300e8800b006e0c9755417mr751178otb.16.1705586659509; Thu, 18 Jan 2024 06:04:19 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705586659; cv=pass; d=google.com; s=arc-20160816; b=fiaJUczrDUmp5VeGXc4wdLbDMZIER0pd/TgUKSTGiH/o48te2A8IVzO+m/PCKiNRfE fQT/Dvg5hMjvCvQWdqlLCuQjZM6mRt1CVePjLRdHp5qHrQ2XoW7JKJWrol24oMfLtfKW 1nhYrDCV8PQC8dXIMZXj9znd3rDQ3vH7I1DmjFhfUIM3uqIl+GH2Kt4Y/nWFfeeOT/vK CyHMuGXiFvMK2DsjT7g9ZiX5yb8NlVPQiAk9qGLi2cXEoKah3z3I11l9w5r2xS/etBxx kVOgfJ6s6rIHvkiQTOo//zQ0bGeCwXiUjl2M1Ob7c0n6safjgEyNgGAZUhojRA3jErUX r7qQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=bsaIuhb1mZ9jgtH2EUsMZiAsdJG1CSSZIyLC32R54Q8=; fh=XOqvp/Oqr5wPZNHrHKCGwC7BL+uLeuRuknRF+7u+bgY=; b=TUnz27SWhShHCX4HuHdMThHsJ7c1vEFZOmRDUOEDou2g5jahc0jWZ7xD+Sasl83/yS d/WHykaWg9D1s6xg7QQ1K6squP7L9b51mmSc77/+YTPJfiYKu9Y3VkuCQ7bjFP1uvITr dgahwSmuFmc6tQfwiVLRC7hvd6Pq1oRghaBKP0h1m6QUKyRpkLDWBpArpH4RZ/2M5pY5 mlmTlOYByXu5raYYZtP9y4r1aJ6OQpf55E2LIcGa7dlj/IOphBZ5e+lMbPCFjcTrnhs3 pQEkqqqqgucMZj8t94/++2g+ojiFsmEkSkUkBq8iFBIoVr8j7lJa2xW5sE4c1aF58k4w 6I4w== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kMD+2c7m; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-30179-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-30179-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id h3-20020a056102208300b004696647457esi573025vsr.130.2024.01.18.06.04.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jan 2024 06:04:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-30179-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kMD+2c7m; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-30179-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-30179-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 2D7631C25B4A for ; Thu, 18 Jan 2024 14:04:19 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id CD1FA25773; Thu, 18 Jan 2024 14:04:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kMD+2c7m" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0487425756; Thu, 18 Jan 2024 14:04:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705586647; cv=none; b=sDOcOgs0HJhPgzJMFDjREJk6msnKoooQY9l47WHDMqhMx3k5Xw5sAvVPP/cfzxuXBzLcOQtw7sY0TbjrB9tZwsFbmgw9YgRh+M/SEv7S/fSCxPETDH1jrSDtB+9Z4LH7n5QNCdXtMLhMyA/xzHxBAHoDGSvDiGKwSAGmgQnNmlY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705586647; c=relaxed/simple; bh=CUg/TAW5ytfIjj6h763t+wFJWAbSx/xoyYthkV8NQsw=; h=Received:DKIM-Signature:Date:From:To:Cc:Subject:Message-ID: References:MIME-Version:Content-Type:Content-Disposition: In-Reply-To; b=o8jx6fnVxTLeJZlobmeTzrxdWJCDLg4PoDBESZP/8M5uYASHPazazBtgEpzXKXITOgKcydjenbCB0FdGKoUnaQ5QMDWzpCMzXwsiMYVfwGL80d+mzHNYXKym5xVPfE9Y72paVMt0D6SORq0f7ANxGf1x2IkgMGMTaX1i3VblYDk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kMD+2c7m; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 235EFC433C7; Thu, 18 Jan 2024 14:04:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705586646; bh=CUg/TAW5ytfIjj6h763t+wFJWAbSx/xoyYthkV8NQsw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kMD+2c7m48E+1LfIfW+gz6LyGmuyZHIcsjo4I51x0Xi4IGHP+SSSKLhhuj8pELn/e gcEr8byzzO2s9rRHsI39ryc5D/qCW8NI1KH2Nl8LX2wWHNF81V6om2WgY8Wu9fU8sU eBWzg7CWnzrbmYt7IzUWTqOJnAz9OEDpSPYDC/DDE5r56LLFxBoAgtHIc1vfClonU4 GhhkempOC9za8YIdB7a3HN/BzzaQBEIsaqPZZMy6pxp08wpvBv1543I2PuJlfsymnD bQAlyzsxkvz6cA6VzxFLSXgSbHX1e21brkbVw0GFg910JDMTY80FFPVnnk2el6rv6p j3iRVHA0xb/lw== Date: Thu, 18 Jan 2024 15:04:01 +0100 From: Christian Brauner To: Matthew Wilcox Cc: Al Viro , Baolin Wang , akpm@linux-foundation.org, jack@suse.cz, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fs: improve dump_mapping() robustness Message-ID: <20240118-etwas-anbruch-9075adb23bd2@brauner> References: <937ab1f87328516821d39be672b6bc18861d9d3e.1705391420.git.baolin.wang@linux.alibaba.com> <20240118013857.GO1674809@ZenIV> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: > Agreed that it's not enough. It does usually work, and it's very Wasn't the intent to just get somewhat further and accepting that this might crash no matter what?