Received: by 2002:a05:7412:ba23:b0:fa:4c10:6cad with SMTP id jp35csp370722rdb; Thu, 18 Jan 2024 06:13:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IFN6Eqg4E6zkhlKsfGp4EeRgFsYlWpsvVWIqGd49mP29unwR3Ntk40A4xb5zBemiuY95zgM X-Received: by 2002:a05:620a:30b:b0:781:630e:6db0 with SMTP id s11-20020a05620a030b00b00781630e6db0mr762758qkm.113.1705587183353; Thu, 18 Jan 2024 06:13:03 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705587183; cv=pass; d=google.com; s=arc-20160816; b=k86j6h2phkI2AjS9yd2V+2isuNCl5fyAzd+mjAXIE1899kWPePCPzxVDLY/3VZ6Nwr bhRBT+DWyWfsACrPtPKJSKdIGQRp9Jqmc128aq8glwNrMSrqWj0aDmU7bQi4pYrvEe+e fTzOoohQVuUihUM2kHUf7LUxkk9DSKae1UgV7MOkO91ObOljVLDoxAwHenlliC2TF48B VBqjuvbY9zHfXTxMZKpSbwEgZb/Y1cT9u/yBOb8eF2QLVRDZR7AYhgATZvTf8uNmKmN0 gFJQz2N4YAsstoROz4brKHbeykB5rMvzJ36RESOwfzrC7qeRqAlSUgeD8qlZlAYciOFE ztUg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=C6daif3Wpo6oR6mWR0a75zB3XL2N/MWmItaHsVRRCfY=; fh=UtjiNYbYZwpSkQBvFYcjoqZCLQVWRkcJXV3l/BIBQoQ=; b=s6wM07YtzX8IwPat7sq8AwUpP04jxeIfpwDCE//1qkmyosg2I0SLcHQtIiicmqBf1S zDMKRX5M1X2CKadwYXhIDi2eJHuHiVVf3RkilwxT5umYLiVufCMDcAYWbSPIL7Gm0EFw tsPromAVXOafj/f8IdYqDxGUDFnMKSYE9DvBQ0vAn6wBzj8ekr/5MsPYfaF6xvvLBc5I 7nDUrsusugzhTUX6oxAxADzvbrvmd4rRjs5GjonDyhj5RVkEXmYvePUWRfJDkjMYDlQq FP39ndN+R7jY+rD8UdQLqSm1TZPZuwghOs0AmUmJWs1gxe6VM0IhWtLgDReKTtUpxijl FObg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Sn7zFNmi; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-30186-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-30186-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id br39-20020a05620a462700b0078379c8d9e2si2180733qkb.664.2024.01.18.06.13.03 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jan 2024 06:13:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-30186-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Sn7zFNmi; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-30186-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-30186-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 0D6F91C21ED5 for ; Thu, 18 Jan 2024 14:13:03 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 83F132576D; Thu, 18 Jan 2024 14:12:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Sn7zFNmi" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64B4025549 for ; Thu, 18 Jan 2024 14:12:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705587176; cv=none; b=euKilAP1fx0A1ipYKNJXDxiRmq7rEOMR897lxmbQgoNWCuJ8Qfkm4EWSK2VrxWs4+KjvH7ohTSnCr+DthzdFyZNmcc1e1SKvAnMCtl/y5DNTxl5mTj67Sj+9J0Uw+o3TY0c3yS96qt2+RfLn8y687n+LOeIn4L9Hmph1Ka1Nq2I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705587176; c=relaxed/simple; bh=HxSLrYC+hnZMNQE8N/YqaKMukOyUuO+/CWYaAZNCBK4=; h=DKIM-Signature:Received:X-MC-Unique:Received:Received:From:To:Cc: Subject:Date:Message-ID:In-Reply-To:References:MIME-Version: Content-Type:Content-Transfer-Encoding:X-Scanned-By; b=V33NjUM7hNDkGjg1xSE2/OdGfx3ucrWV0S/ZPvOsnaJo+w7jqqerusYz1U2+IbkY21Q/2wtfM7fLL1MI8B0haYmOMdsn1pv7MTYBewPLGrm0OKCfiD3fdjzFOEEc+0nWYxTjd5bC60j1i8xXxjUJcpQTihZcROCyCIXxwQGc4v8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Sn7zFNmi; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1705587174; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=C6daif3Wpo6oR6mWR0a75zB3XL2N/MWmItaHsVRRCfY=; b=Sn7zFNmiq2o54BNmPQrkSUmhEKDo6XVfCTV7qsC3ldhwXIsWNTE4rIDuUCrmBIAzFWVJI3 JYXic4w51yKqEEnwRKWt1NZOHpGCmIDWDCSamzfEkpsnlU+U9uBFJTSPOW7kIoL1WapKYo XE5vbPFXa3ggeZnSBO3Y443WuCgiu6w= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-607-xgcAbzp2MJGxL2n8EKgOGA-1; Thu, 18 Jan 2024 09:12:49 -0500 X-MC-Unique: xgcAbzp2MJGxL2n8EKgOGA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5C60D3C2A1C2; Thu, 18 Jan 2024 14:12:49 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.39.192.155]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8D15D2166B36; Thu, 18 Jan 2024 14:12:47 +0000 (UTC) From: Jose Ignacio Tornos Martinez To: masahiroy@kernel.org Cc: dcavalca@meta.com, jtornosm@redhat.com, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, nathan@kernel.org, ndesaulniers@google.com, nicolas@fjasle.eu, stable@vger.kernel.org Subject: Re: [PATCH V5 2/2] rpm-pkg: avoid install/remove the running kernel Date: Thu, 18 Jan 2024 15:12:45 +0100 Message-ID: <20240118141246.370272-1-jtornosm@redhat.com> In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 > What is the problem with this? In my opinion, it is risky to remove the kernel that is running, that is the reason why I am trying to protect this. If you try to remove or update (and the running kernel is removed), if the kernel and modules are already preloaded in memory, it could not happen anything but some extra action could be necessary or automatically started, and even the new kernel could not boot. Fedora and others are taking this into account with upper tools and declare the running kernel as protected avoinding this action. But others (i.e. openSUSE Tumbleweed) allow this behavior. It may only be a safety measure but it can also be beneficial to avoid problems, just in case. Besides, in this way, all the tested distributions would have the same behavior. If it is ok, I will create a following version patch describing the problem better and using indentation as you suggested for the other patch. Thanks Best regards José Ignacio