Received: by 2002:a05:7412:ba23:b0:fa:4c10:6cad with SMTP id jp35csp408946rdb; Thu, 18 Jan 2024 07:11:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IHhK7Lg7zJWiDczyR6r8f5eViRq7z6kksVhsjF+PeQUge+EsqS67ikpEY8rCi/TQTkywTG+ X-Received: by 2002:a05:6a20:12cf:b0:19b:4435:7f20 with SMTP id v15-20020a056a2012cf00b0019b44357f20mr914123pzg.22.1705590672326; Thu, 18 Jan 2024 07:11:12 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705590672; cv=pass; d=google.com; s=arc-20160816; b=pe5NQkqAWkB3EiuhgeYwYb8ufyCqxMZIqZ3UELd8TkSjAXbKgezjXvxeomRXmjonQj EsaATvehIqngtK2SWqnYYpS8Y+jIxRLo7xn3k/xsLDTq1bgu6YwT7/32aqGtkOmOR5Mr S59KUf/fDVKt0fP9RPZJvfjKE8L6rsVmRnWSU+aTB0sK+DR3Teakt3/2nzBoPili6gVB hIQA9Jgfm0ouNnp3zrXzQaZ9lAtAV02W2UOCpkeukH4BzXdQ+uriPa5mv/lDfd3Q+Jjd Lt+06qazzE2RZ5oDnUeBVqIEkT52Qq13Ptfs46cQWo9NNlE7b/3+ZhtoFqQHEQcgvCWY yakA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=7X+XE/Gzv4Nomb0fLlmWLJhVAVM3P5M7gZDV8sKCsGg=; fh=vC4YUebz8VJflYEnmMTuRF6Wi6sDwBzRsWOpNyLOJGc=; b=YivWW8tNSaJGtW1CM0tKbt3SyRmgp9YqFZv/NdFcqg4/i4hFZtsH/QzbQaCG7FFYem ximzgy91+GwCweV5/lI/NpRn9Xqa/D+ZX8u3vO7SKZqABzhb8GogpAYC4fO6/wM0glkq a18GqrXNQKkiCR7/VmYv9gFXe4cq4Y99hBMQodjv58K5Q/iZ9pqT///pYBlwfQFiT/Ks 8gLtEV59g53OeP9/0PKKj73VosOdonTiSJBYpDTdgg6feYxyT0dsS4AS6/LhWNEnz+Wp 5TxurslFg/+kMHP5SjwiCoyzCfBc+2S42KhGrnAtXqe8BBHhixet1SJvf1YMWkE02x2e Rg+g== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@resnulli-us.20230601.gappssmtp.com header.s=20230601 header.b=T4Ou9e5X; arc=pass (i=1 dkim=pass dkdomain=resnulli-us.20230601.gappssmtp.com); spf=pass (google.com: domain of linux-kernel+bounces-30057-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-30057-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id k127-20020a632485000000b005ced534e1e7si1488648pgk.237.2024.01.18.07.11.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jan 2024 07:11:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-30057-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@resnulli-us.20230601.gappssmtp.com header.s=20230601 header.b=T4Ou9e5X; arc=pass (i=1 dkim=pass dkdomain=resnulli-us.20230601.gappssmtp.com); spf=pass (google.com: domain of linux-kernel+bounces-30057-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-30057-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id DB21028A653 for ; Thu, 18 Jan 2024 11:32:45 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 568D9241FC; Thu, 18 Jan 2024 11:32:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b="T4Ou9e5X" Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 77507241E2 for ; Thu, 18 Jan 2024 11:32:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705577559; cv=none; b=iZ8XvUQyipuP4c6JW0zcxZTA8LI0/F5JMVxbySqWWc92iXIp77svmzM56BdkbcSc+qNEqWfTK11ANon0ggl5UPOYcr8NNjcouOyd3i8F5217uuMR3b8phP1LdV0FGfycU9qST0jZDT+ogr9VxgVyC747KnZcaFQFRb82rD3luqY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705577559; c=relaxed/simple; bh=7X+XE/Gzv4Nomb0fLlmWLJhVAVM3P5M7gZDV8sKCsGg=; h=Received:DKIM-Signature:X-Google-DKIM-Signature: X-Gm-Message-State:X-Google-Smtp-Source:X-Received:Received:Date: From:To:Cc:Subject:Message-ID:References:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=TiXHVek7bXn0rDiUr3i/JfgQQF5Fp50PhIltEvifgbbluQ2NbIenYrmScIbkQLdwB2q7HgLqRxX4L0wMZAIaD8qNAR9/rMMpDtZrqqXLbL2MAuJm51YiIUaLYuMxbqGM8uEqgnqu/riIPWWBRzDJUzBXXOFNMaZQkouhvUrpoEU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us; spf=none smtp.mailfrom=resnulli.us; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b=T4Ou9e5X; arc=none smtp.client-ip=209.85.218.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=resnulli.us Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-a2e0be86878so119510766b.1 for ; Thu, 18 Jan 2024 03:32:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20230601.gappssmtp.com; s=20230601; t=1705577555; x=1706182355; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=7X+XE/Gzv4Nomb0fLlmWLJhVAVM3P5M7gZDV8sKCsGg=; b=T4Ou9e5XcaUDtT+hA1UhKdNYI6UMu53OFVYkKRz2RUWrVUCmigH8AR3Pf4rNMHJmmV FEarapDyo1D6OJPBxjL9nJSfPhTrPP8o+uyclYjm84fRxgUKFs5BPV43Hm8G+cYRZTgq oFAZ1UPjpbJytrEIE87qUmVXJ5bocXaP9RsBNNNM1nS4HRAQPHs2rILGIzbq3Egq393z 1a7cMDDRKwVQXKW8sYxeTYaT7NaK4thght6TZXE7aPIWmpKZdK2TfmLoqHWBQ1ndbG9U AGL1mcU++vpD3qLT43jEkDz4jFgaK/dNuGm2I4re0kiyUiO+QSu0mCdMhbq4TkGDBVVZ NTfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705577555; x=1706182355; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7X+XE/Gzv4Nomb0fLlmWLJhVAVM3P5M7gZDV8sKCsGg=; b=GXt4QTR7iRbO1SQhVM1IHdvjwJoG7l5k3lZorftLIto93T1kELWrOMjEsILEdk8Tl4 I2PnZENY5OT0NH8zDg1LPauALBExv8h5GkMDhrdhdP6DH7m6k5RKpi7VHfFE1XdTHE/Q LKSTODQKOTAKYUrMO6xLYaubhMtymeNAkpxALjJhDXq5iyY+VuQGZUiU2FJkAcflK9H2 g0VibWtFw5lZ3Lq9q8PzvMJzRRo/ChC9+HTH2XCdtqx9sBOtkqGfc7NybVfgV1uihee+ gyGFw+b1fVKtgvMLFkcxcM8zrhVaS02HYuIWhvaBx1O4NEgqoTvmyRuJaUVPVuJQ2BXP EMug== X-Gm-Message-State: AOJu0YztnD/kUwnmq63bytwcnVv+YubUscpqZxm1Gcas3aiO06MUbm0V Trx4tZdgKbzbuUMvDZzg8BitGIg+GOQYhv3+UESgqMLv6AHiVdGU/nOo/qBswUk= X-Received: by 2002:a17:906:d931:b0:a2a:212:cfe5 with SMTP id rn17-20020a170906d93100b00a2a0212cfe5mr732923ejb.12.1705577555430; Thu, 18 Jan 2024 03:32:35 -0800 (PST) Received: from localhost (host-213-179-129-39.customer.m-online.net. [213.179.129.39]) by smtp.gmail.com with ESMTPSA id g17-20020a170906c19100b00a2b1a20e662sm8934043ejz.34.2024.01.18.03.32.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jan 2024 03:32:34 -0800 (PST) Date: Thu, 18 Jan 2024 12:32:33 +0100 From: Jiri Pirko To: Arkadiusz Kubalewski Cc: netdev@vger.kernel.org, vadim.fedorenko@linux.dev, davem@davemloft.net, milena.olech@intel.com, linux-kernel@vger.kernel.org, pabeni@redhat.com, kuba@kernel.org, mschmidt@redhat.com Subject: Re: [PATCH net v5 1/4] dpll: fix broken error path in dpll_pin_alloc(..) Message-ID: References: <20240118110719.567117-1-arkadiusz.kubalewski@intel.com> <20240118110719.567117-2-arkadiusz.kubalewski@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240118110719.567117-2-arkadiusz.kubalewski@intel.com> Thu, Jan 18, 2024 at 12:07:16PM CET, arkadiusz.kubalewski@intel.com wrote: >If pin type is not expected, or dpll_pin_prop_dup(..) failed to >allocate memory, the unwind error path shall not destroy pin's xarrays, >which were not yet initialized. >Add new goto label and use it to fix broken error path. > >Fixes: 9431063ad323 ("dpll: core: Add DPLL framework base functions") >Signed-off-by: Arkadiusz Kubalewski Reviewed-by: Jiri Pirko