Received-SPF: pass (google.com: domain of linux-kernel+bounces-30297-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <23ee70d5-d6c0-4dff-aeac-08cc48b11c54@amd.com>
Date: Thu, 18 Jan 2024 09:47:07 -0600
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4] PCI: Relabel JHL6540 on Lenovo X1 Carbon 7,8
To: Mika Westerberg <mika.westerberg@linux.intel.com>,
 Esther Shimanovich <eshimanovich@chromium.org>
Cc: Lukas Wunner <lukas@wunner.de>, Bjorn Helgaas <bhelgaas@google.com>,
 linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
 Rajat Jain <rajatja@google.com>, Dmitry Torokhov <dmitry.torokhov@gmail.com>
References: <20231221-thunderbolt-pci-patch-4-v4-1-2e136e57c9bc@chromium.org>
 <20231228132517.GA12586@wunner.de>
 <20231228133949.GG2543524@black.fi.intel.com>
 <CA+Y6NJFQq39WSSwHwm37ZQV8_rwX+6k5r+0uUs_d1+UyGGLqUw@mail.gmail.com>
 <20240118060002.GV2543524@black.fi.intel.com>
Content-Language: en-US
From: Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <20240118060002.GV2543524@black.fi.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MFdoU2V6SUFPNndMUks2aG1zZmVSMGlHWVNCRFVnZ2hkSWsra0RaTlpYTkN3?=
 =?utf-8?B?REtUNWN5L1Qyc2tOd1Z1T0lQNzFSTFlSWnByR2NzTHhWZUZmb05rMzMxWi9t?=
 =?utf-8?B?NGJtYUJnKzlwWE9EVVBNdWNpRmRlTTRKM3BVQURialp2VktmVlN5WHNvb1Fy?=
 =?utf-8?B?Z2xremVkeVdpdVRxeTg5VzJuN0oySWRaMGRtc0dhK0dsT0pYbm9EdzJ5UFVt?=
 =?utf-8?B?eVN0Smh4cDBuMnlZQUNQOUlHbTdYOG9kaEM4MWlnbVUrcGhYL3NwZWZia1Bq?=
 =?utf-8?B?U1hqVnRGMHBLcVR0TGVEYStTanc1dUhQRTlJd0loMXovUEdKL0lzakwvQVVT?=
 =?utf-8?B?RUx6NUtpTWVaZ0d0VnFOaGNoaHdhWmFncGNXVERpYlNObkFOa25OeVBrZ1lo?=
 =?utf-8?B?Nzdvb2Q4U3pFV3BTZlpDbjdncjRsenZiSDliVnpub3BBa2dDUmpBRGFMcHlO?=
 =?utf-8?B?bEdPZ1ZTd2JxSkNRQ2hhSE9GVnAzdk80V1J3QnBFZmRTZVRDQnozSDBzYXlO?=
 =?utf-8?B?ampMa0paK1N2cTdHbEdZSkx6UENiQTBnMFFnemlSS3hMdTd6WExMTk1UTnZB?=
 =?utf-8?B?aE1iQXI4eGRpK2RmWUEvRzZjZzBCQXppU2szODlaTW91dVVFTVJkU1NDTkNE?=
 =?utf-8?B?OEkxMDN6L2JzcDhYZCtKUlJ2cFpsSkFCb3JTcWp4Zm5QdFBCeHV1Vzl6d2VI?=
 =?utf-8?B?bTVqOWJtYndJVzkwTFJPWUhkbkdIN053eEdBS0wvMktBeG1LT25NcUp3L1BF?=
 =?utf-8?B?SkM0MGx2OUIzVTVxSWlCd2dOQ2hEL1hJMlBTWWg1dmY4bVVPNUJlMkRtUGZ3?=
 =?utf-8?B?Q3JITUNSSGhYT0VxQWtXN3NkVzJwTUJuWEd0ZnNyN0RFZXJhQmt1R0dSY0h3?=
 =?utf-8?B?Z2ZGMVZLWGs5VTJlaGxEbm42Y2N3L2twUDV3VnpmdzYzQ1M3RGJ1ekxpQ29B?=
 =?utf-8?B?ZTF4dzZIMTJxeURGdTBrQnZ2Qk8wRzRkY005dGVpeUVQUEFvVXR2NXlacThQ?=
 =?utf-8?B?QnUxVlp1Y3RBd3RFVzM5L2RCS2VqamJ0eHIxd2kzL3BYRnpWM0Q3VzF4UG1W?=
 =?utf-8?B?cGhKUHdpc2VBRE1WZDlPUmNWQ04yRzNEeElaNVB4bzdBaktxMG40UmdKQ2Zz?=
 =?utf-8?B?U1BDVmp6NVhpcHJORENYU3lqM0lNRDhHcnRYcElMQ3gvZ3RoQWgvZld1eUJ0?=
 =?utf-8?B?Q3ZWV0xhbGtOQXBhbng2Qk9BOFZhZXQ2QjZDTTJIbHlqeG93Q1g4SEFac202?=
 =?utf-8?B?bktqNTNXcDhnOVlDSVVLb09rTlJHZnYzWUlqdTM5bnhheU54a3RnaWdTelFE?=
 =?utf-8?B?Wk1MdDVHWTVxd0hXaGQ4dkwvdEQrMGFlUk5YdE0vdkFaOUZLUnFGVnB0N1da?=
 =?utf-8?B?L2VzM3RYUUkrN1R2STdERUhReVNqMU81QVViN1UySVhoNVJua1k1aHQwdERI?=
 =?utf-8?B?aWNmdGxsbGVvejUzRm1WaHJDd2wrQ1R6KzVRSTUyWnVUNkVXQ2lUeVJGbU5T?=
 =?utf-8?B?SzFpZ3hYN2piVGdqU3NJeFlvQnN3RGl2QXFsY25RNkticTdmQ1VlNGFJUHRk?=
 =?utf-8?B?L0RSMHpIUVcyK2loRThoazdSMHVZblk0SWVMVWxOK29VbldWTFVkbHhjK0hr?=
 =?utf-8?B?STZZTGpiSC8xLzNZTS91Mjk3WTFva1gwdEY0YUFjKzkyMkM4cDd0SkhoOWNY?=
 =?utf-8?B?VEM1K2J1MUZhZnM4OXhSM2lUMjJ4WEZLK1c1NVgwK0xIN3paVUprcGQwNWhk?=
 =?utf-8?B?TVlBWnVOQ0NJTm5uMnBTTnp2VS9YMnZ2QnJqa0YwTnQ0SmxuQ21Ya0RReUYw?=
 =?utf-8?B?b3RnVE9kZlZMS3YzNDgyZFdrUmFxVDNYR0dlcFFVVWFmZjNUOUc2VVdXOW9P?=
 =?utf-8?B?d1JteUh3MkZoT2dsZzAzaWxhYWVFTDhteFdSU1VZdVVpMlJIZ1lZZVBPKzVR?=
 =?utf-8?B?RXJBNWhERWhudXM4ZFZXaldWWjlkQWJzWk5OQnZOSUxUVHpSUm45UlVvRVNh?=
 =?utf-8?B?Mzl3bmhMU3J4R1lyeHl3VE9rK1dzeEZUcXdUTlIycTBtMXYxTG1HZTFmaVdD?=
 =?utf-8?B?Tld1c2pVR3J0OGVSNmY1MENGcWxweTNhNWZxRTJOYm1FOGhXMFh4QVJJWVFk?=
 =?utf-8?Q?p7ijGOMXpvXPZO7DOF2UMZe0L?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 28a3a58b-4503-4142-5596-08dc183cbb25
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jan 2024 15:47:09.7961
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Vy/RXb1HdMcIfW2OhrXnjrv1us+p8PbM6kf5CAj5yHPw4eENic86dJLhIy25BhZRhODhOUVoDnwyETaBl1Xd0w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB5509

On 1/18/2024 00:00, Mika Westerberg wrote:
>> Before my patch, you see that the JHL6540 controller is inaccurately
>> labeled “removable”:
>> $ udevadm info -a -p /sys/bus/pci/devices/0000:05:00.0 | grep -e
>> {removable} -e {device} -e {vendor} -e looking
>>    looking at device '/devices/pci0000:00/0000:00:1d.4/0000:05:00.0':
>>      ATTR{device}=="0x15d3"
>>      ATTR{removable}=="removable"
>>      ATTR{vendor}=="0x8086"
> 
> This is actually accurate. The Thunderbolt controller is itself
> hot-removable and that BTW happens to be hot-removed when fwupd applies
> firmware upgrades to the device.

Depending on the consumers of this removable attribute I wonder if we 
need to a new ATTR of "external" instead of overloading "removable".