Received-SPF: pass (google.com: domain of linux-kernel+bounces-30296-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Thu, 18 Jan 2024 10:44:43 -0500
From: Hugo Villeneuve <hugo@hugovil.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: gregkh@linuxfoundation.org, jirislaby@kernel.org,
 cosmin.tanislav@analog.com, shc_work@mail.ru, linux-kernel@vger.kernel.org,
 linux-serial@vger.kernel.org, Hugo Villeneuve <hvilleneuve@dimonoff.com>,
 Jan =?UTF-8?B?S3VuZHLDoXQ=?= <jan.kundrat@cesnet.cz>
Message-Id: <20240118104443.7678d39eafc698a4baeb2ce7@hugovil.com>
In-Reply-To: <CAHp75Vf7j6_xPceGuDWB5Mno2eJreyyD8B4i4GyyiMyKZPiwLA@mail.gmail.com>
References: <20240118152213.2644269-1-hugo@hugovil.com>
	<20240118152213.2644269-9-hugo@hugovil.com>
	<CAHp75Vf7j6_xPceGuDWB5Mno2eJreyyD8B4i4GyyiMyKZPiwLA@mail.gmail.com>
Precedence: bulk
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [PATCH v2 08/17] serial: max310x: use separate regmap name for
 each port

On Thu, 18 Jan 2024 17:30:16 +0200
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:

> On Thu, Jan 18, 2024 at 5:22 PM Hugo Villeneuve <hugo@hugovil.com> wrote:
> >
> > From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> >
> > Use a separate regmap name for each port so they can each have their own
> > debugfs entry, allowing to access each port registers independently.
> >
> > For example, a four channels/ports device like the MAX14830 will have four
> > entries in its regmap debugfs:
> >
> > $ find /sys/kernel/debug/regmap -type d | grep spi0.0
> 
> Just a side note for the future. The above is an example of "Useless
> use of grep".
> `find` has a `-name` parameter for such, using `find ...-name
> 'spi0.0*'` makes the grep unnecessary.

Hi,
yes, I fixed a similar one in the sc16is7xx serie, but forgot to update
this one :)

Will fix it if sending V3.

Hugo Villeneuve


> 
> > /sys/kernel/debug/regmap/spi0.0-port0
> > /sys/kernel/debug/regmap/spi0.0-port1
> > /sys/kernel/debug/regmap/spi0.0-port2
> > /sys/kernel/debug/regmap/spi0.0-port3
> 
> -- 
> With Best Regards,
> Andy Shevchenko