Received-SPF: pass (google.com: domain of linux-kernel+bounces-30345-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: andy.shevchenko@gmail.com
Date: Thu, 18 Jan 2024 18:16:05 +0200
To: Charles Keepax <ckeepax@opensource.cirrus.com>
Cc: broonie@kernel.org, lee@kernel.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	linus.walleij@linaro.org, vkoul@kernel.org, lgirdwood@gmail.com,
	yung-chuan.liao@linux.intel.com, sanyog.r.kale@intel.com,
	pierre-louis.bossart@linux.intel.com, alsa-devel@alsa-project.org,
	patches@opensource.cirrus.com, devicetree@vger.kernel.org,
	linux-gpio@vger.kernel.org, linux-spi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 1/6] soundwire: bus: Allow SoundWire peripherals to
 register IRQ handlers
Message-ID: <ZalOxVZhPkOPvkJ-@surfacebook.localdomain>
References: <20230804104602.395892-1-ckeepax@opensource.cirrus.com>
 <20230804104602.395892-2-ckeepax@opensource.cirrus.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230804104602.395892-2-ckeepax@opensource.cirrus.com>

Fri, Aug 04, 2023 at 11:45:57AM +0100, Charles Keepax kirjoitti:
> From: Lucas Tanure <tanureal@opensource.cirrus.com>
> 
> Currently the in-band alerts for SoundWire peripherals can only
> be communicated to the driver through the interrupt_callback
> function. This however is slightly inconvenient for devices that wish
> to share IRQ handling code between SoundWire and I2C/SPI, the later
> would normally register an IRQ handler with the IRQ subsystem. However
> there is no reason the SoundWire in-band IRQs can not also be
> communicated as an actual IRQ to the driver.
> 
> Add support for SoundWire peripherals to register a normal IRQ
> handler to receive SoundWire in-band alerts, allowing code to be
> shared across control buses. Note that we allow users to use both the
> interrupt_callback and the IRQ handler, this is useful for devices
> which must clear additional chip specific SoundWire registers that are
> not a part of the normal IRQ flow, or the SoundWire specification.

..

> +#include <linux/irqdomain.h>

Added code doesn't use anythitg from above. 
It can be fulfilled with a forward declaration.

-- 
With Best Regards,
Andy Shevchenko