Received-SPF: pass (google.com: domain of linux-kernel+bounces-30349-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: Frank Li <Frank.Li@nxp.com>
To: Vinod Koul <vkoul@kernel.org>,
	=?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= <uwe@kleine-koenig.org>,
	Guanhua Gao <guanhua.gao@nxp.com>,
	Laurentiu Tudor <laurentiu.tudor@nxp.com>,
	Ioana Ciornei <ioana.ciornei@nxp.com>,
	Li Zetao <lizetao1@huawei.com>,
	Peng Ma <peng.ma@nxp.com>,
	dmaengine@vger.kernel.org (open list:DMA GENERIC OFFLOAD ENGINE SUBSYSTEM),
	linux-kernel@vger.kernel.org (open list)
Cc: imx@lists.linux.dev
Subject: [PATCH 1/1] dmaengine: fsl-dpaa2-qdma: Fix the size of dma pools
Date: Thu, 18 Jan 2024 11:29:16 -0500
Message-Id: <20240118162917.2951450-1-Frank.Li@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?zJqGQuHuFi1hjhGxvx3HB05v9rGa9uycrgCoe4u6DHhcmFFqeKH6sHl1eqBt?=
 =?us-ascii?Q?aMJSr8fHTT2wmmCxSGY3PzEGhKAzYA0XNZbVwEGg+aqO5VTeA8iwVMLfpN7I?=
 =?us-ascii?Q?PCEDt5T6Zp7URxvri00khrXSccyUAZKoFu9yIWJqixRpPb7xQNY10fSK3yYc?=
 =?us-ascii?Q?cDXIjLqRz+b1gEYV36YMMTf2zc3WhGi82jYTuxPJxkpZ07VTBku6AdP0YPNK?=
 =?us-ascii?Q?Aa8dtfAkQsGATX+dCMJEwIxJeahDE+zBDFBKSWQDElv2bCfeD86QhqQh0nzJ?=
 =?us-ascii?Q?qLwiRpJVEAGQmB+s0/Vv+73aMBRtwxXfd6tUcno0qx5z1/ON6qKg8ewv920w?=
 =?us-ascii?Q?R2q9jp5T9Gq1BGujCUHtxTXDuLDSWmvQZaw/d+/kkK9fsZfZ/p3FOjx9S9dV?=
 =?us-ascii?Q?9DIwKkhnSNp61aviz0mil3R455I3ZkdJjWXYc3XfxkQfHOF2dGw1GVrAt/Iz?=
 =?us-ascii?Q?z3Vkj5F/BcwkHwkSB0c+B5XqOpl1GT7NQmqMLIcyZ9Ns4UdofR4lVgSrPHPh?=
 =?us-ascii?Q?0naYyOQtrP7Kcs7r0qTUrcAjno2c/xYkQVwUKowxUAEvipDGrf/s6OttX27a?=
 =?us-ascii?Q?XdUySlSsy/7Nh1beZ8m4L8pMHSKIWWX0yUepfTYgM3mn4es/x38GNzA3W0f7?=
 =?us-ascii?Q?tn+eUT3D4HqRnccfFCQos6pz6fYQs7j0ImGbZ6oNGHtgnIC5yxi/KgnYAuxc?=
 =?us-ascii?Q?Sw+UFMH0CwYvPAYI2FxZqA+vR0aHrQSe1fVzZeJXAK8mKBRfBOuTgK7fdVjL?=
 =?us-ascii?Q?SOAnrvfAqSgX8vR2aHLu0FjvDfbYrHbMUcPMG177HbSTSG/Si7xleZORtyWW?=
 =?us-ascii?Q?2uxXtgGBhdrG0bfaqmRz9M9gaQnyqcKLlDxaCZ5gfc52hJJs3N3V8rRLorBQ?=
 =?us-ascii?Q?4EfkOQvTqq4qczknlG2IV3v1PKPaZs/0Qi2I9yhZAg0DrWUdcEG9QIvy10tb?=
 =?us-ascii?Q?AuYDMcwafTo33nEgsrn3lxZeI6kJVNqqMxpRTe1Jm4KOk05Cr+v43x5eS3J+?=
 =?us-ascii?Q?6Y7QDTTpDm0O24/uAPm+FIqKSB0G5EGhpF5P8d6r/7uRMUMhDvGcGZPvtKYp?=
 =?us-ascii?Q?JknT5xgrlvRFeNT8T1qDyEu1UyCu3CIDXTA9CMU3WldOlXRjdtW2UguTN1WO?=
 =?us-ascii?Q?Og3Yg4fs9Kp/ZqL5E5ii4/WqTatfutGAaBBLdUGlgdyxJvOa3GJM61M6LeE1?=
 =?us-ascii?Q?/hTgsCuwP+wolFDh6Ox1U3/bk/cOEh6mZZjn39GvjMeLEt07shZghgHji5OY?=
 =?us-ascii?Q?ga9f42X1z0Z0Kt802S+VdjJna3LzQjAnnNZmAL+zLD4mN9MlEBVjF9xXSTAt?=
 =?us-ascii?Q?7Tls2jSJIEPDgoJ1vy2gn4eNIOYlLEW5TgcEsBsx8mfqe7s4Vgg3Tf6SqmFk?=
 =?us-ascii?Q?VhSr7Ouib18hv4weNJUxrGZNT5lrM0V9WRR/bOkeYgxI0dcMNdmMz61QK7zl?=
 =?us-ascii?Q?EVzlwqlZrxEKVW+m0gsqQ1SuTGL0UeDihUCDSOGTXTCcPxADOR4vMBllGsUZ?=
 =?us-ascii?Q?I1crwRAUXrw9Jmah/CuEnOIlQ9V8lhLJ3COqBvnk44K2uFTBjEgu+Guko1h3?=
 =?us-ascii?Q?mIPx59mRSxghKoIl8e8=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5895efe1-4490-483a-89c8-08dc1842a7fd
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jan 2024 16:29:34.7718
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mdFVuqsvAVj1B17rtoTY+ihvH3LF66Dc+hrrezSWKBsTxLAx2ajvFooJ9GfFfDUF2jd6J2Fw7HGts6AliD9ovA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB7714

From: Guanhua Gao <guanhua.gao@nxp.com>

In case of long format of qDMA command descriptor, there are one frame
descriptor, three entries in the frame list and two data entries. So the
size of dma_pool_create for these three fields should be the same with
the total size of entries respectively, or the contents may be overwritten
by the next allocated descriptor.

Fixes: 7fdf9b05c73b ("dmaengine: fsl-dpaa2-qdma: Add NXP dpaa2 qDMA controller driver for Layerscape SoCs")
Signed-off-by: Guanhua Gao <guanhua.gao@nxp.com>
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.c b/drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.c
index 7958ac33e36ce..5a8061a307cda 100644
--- a/drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.c
+++ b/drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.c
@@ -38,15 +38,17 @@ static int dpaa2_qdma_alloc_chan_resources(struct dma_chan *chan)
 	if (!dpaa2_chan->fd_pool)
 		goto err;
 
-	dpaa2_chan->fl_pool = dma_pool_create("fl_pool", dev,
-					      sizeof(struct dpaa2_fl_entry),
-					      sizeof(struct dpaa2_fl_entry), 0);
+	dpaa2_chan->fl_pool =
+		dma_pool_create("fl_pool", dev,
+				 sizeof(struct dpaa2_fl_entry) * 3,
+				 sizeof(struct dpaa2_fl_entry), 0);
+
 	if (!dpaa2_chan->fl_pool)
 		goto err_fd;
 
 	dpaa2_chan->sdd_pool =
 		dma_pool_create("sdd_pool", dev,
-				sizeof(struct dpaa2_qdma_sd_d),
+				sizeof(struct dpaa2_qdma_sd_d) * 2,
 				sizeof(struct dpaa2_qdma_sd_d), 0);
 	if (!dpaa2_chan->sdd_pool)
 		goto err_fl;
-- 
2.34.1