Received: by 2002:a05:7412:ba23:b0:fa:4c10:6cad with SMTP id jp35csp464749rdb; Thu, 18 Jan 2024 08:38:28 -0800 (PST) X-Google-Smtp-Source: AGHT+IFTSfP3333OLBDOObD6P9IQerlgXO1JKlQpdGsqL61ICHhgoknmPoPAMEQ9dL4WF3AEEIca X-Received: by 2002:a05:6102:558a:b0:469:9048:916 with SMTP id dc10-20020a056102558a00b0046990480916mr754386vsb.30.1705595908220; Thu, 18 Jan 2024 08:38:28 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705595908; cv=pass; d=google.com; s=arc-20160816; b=MqDQRozkHz6ZTDJjzZE3LWd/T0df8QC+CJRg/1jc+owsp74UGLKe7pxzoFsp2gF+Kd bOBd5hJmP6J1xM0miZSOTrYvM/ipBF/xXQc/AR0eRJQE3S5Oz6lf0p9Z3Y+UacBlC6nB jYi0jnew1es7BSqEQ8e2RS3MDEsizdMT+fb6busdkWC2q3JON8PtP4JmBsSUjZ6euZiE Bs7UXUypscc9FOFFq4XP21jaEHLaSsFxLRbJ98fZ88xSlUas4Atl2TZS7MTtbVgqMBDg VykRnVBoJXnHrz99NsFMgaOr5ks0TYARYa8CFtqtFDGMq3a9hoOHsDySb9RJ5S36xzbD XwNQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=hR6M2lk5nSfW3G4lKAMH32rGV+kLGjLbM9lRhETJ9CM=; fh=lrN/gKTKghREd0jYomjnNO93usvEwT+Pa6wnEWsN3j0=; b=Or8TpIWwjFU7NR4X9Bj5pfpWBz04EFqh+eUcZ2B3TQKfcA5yODyBgcteY+++qi6Mad BZzfTZt+6Qlzqh/2x6IA4rVIak+3s6q3vOTGk/66reqm70/TEwtzUacILRndR2psSxQU 3qOBG6BkwUEMN/rUSsShZgGV26RkAEZPYgyZlLFVG2TmgIIYC67qX4qeZukpdGISvRj/ Uyd3HDqVNvI1Qc8kILcyM07QvtBpKcVOyUgcC9CnkekmmwAjeojHAq5sQ/GZU3mIL4Td 8HgTEquxj+Teums+mvThJn3+fzhVNisMuS48Ssq8Of/X35knA1lWY3i2g3AAE5nVFkTO xUxw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=U7TeO9Dy; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-30356-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-30356-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id q12-20020a056102100c00b00469875f7797si360455vsp.662.2024.01.18.08.38.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jan 2024 08:38:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-30356-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=U7TeO9Dy; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-30356-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-30356-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id F06731C2259E for ; Thu, 18 Jan 2024 16:38:27 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E00B92C6A4; Thu, 18 Jan 2024 16:38:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="U7TeO9Dy" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08A6928DD8; Thu, 18 Jan 2024 16:38:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705595896; cv=none; b=uTmVzUvbMvNaC0i2+hgwpLE4eP2YloLDzjUnxLmU1tcLtI8Lw3GalRsGqR2Yz6vz367RqsVZQiHK2wsT5Oeg/1FNeveerKOf1rInrtLlr41eG2s1HDOkPbAitLiccJq5MOHY2wwUUBDOgoXCUZw4pvgAwVCtM3i/iXF2J5WgDiI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705595896; c=relaxed/simple; bh=jRTphcK/e9x4FUHAULwLsMzMToQ7/evgU0hqPmIiM2w=; h=Received:DKIM-Signature:Date:From:To:Cc:Subject:Message-ID: In-Reply-To:References:MIME-Version:Content-Type: Content-Transfer-Encoding; b=HtA1QIbnHdg4jvYfKEnznCw5Z1TGW//eiQeyWPYQ87uXdtwh67xJca+jDX03HTpz2uMsBqUxYOE3G+OYMcnB4RDahJS7sXaRpAZtEO9wlez65U+84trt+mUp8+8FmfpYjgSbwilvTYIErnch6JL7Dnbs0YBUVLWPYDt1IyC//w0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=U7TeO9Dy; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id B0107C433C7; Thu, 18 Jan 2024 16:38:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705595895; bh=jRTphcK/e9x4FUHAULwLsMzMToQ7/evgU0hqPmIiM2w=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=U7TeO9DyYiaYySuxIASAJyxlq3vtKIJKKXHNz0ART1KyEBafmJLUZTt1lKUV9vN3/ yHE+oPLxoErQXKEL5PI4qnAOnrfz+gHw0LZcmbqfgIFLWUc3Nal6QrA8YxEfPhn3ON FNfTljnkrTGE3SnpBFGytjHJM5dI8/bO3pw7TUSd56nFAl32aB1qNxpSHj9IWdtDUc A9CBber0mDs2dbR8NjsFANQQQJmeIfx7MoBgvcm9hxnn0lGzK6Hz2Jm0ZMxgVE3TbL CB73O2cBxJ4KCd5UHeMWGoGhguWmEv43jQFvbhj7O0yrhom0WV0RCxiDaRGdd5062g loRGxHxsh4/Mw== Date: Thu, 18 Jan 2024 08:38:12 -0800 From: Jakub Kicinski To: Sebastian Andrzej Siewior Cc: Toke =?UTF-8?B?SMO4aWxhbmQtSsO4cmdlbnNlbg==?= , Alexei Starovoitov , LKML , Network Development , "David S. Miller" , Boqun Feng , Daniel Borkmann , Eric Dumazet , Frederic Weisbecker , Ingo Molnar , Paolo Abeni , Peter Zijlstra , Thomas Gleixner , Waiman Long , Will Deacon , Alexei Starovoitov , Andrii Nakryiko , Cong Wang , Hao Luo , Jamal Hadi Salim , Jesper Dangaard Brouer , Jiri Olsa , Jiri Pirko , John Fastabend , KP Singh , Martin KaFai Lau , Ronak Doshi , Song Liu , Stanislav Fomichev , VMware PV-Drivers Reviewers , Yonghong Song , bpf Subject: Re: [PATCH net-next 15/24] net: Use nested-BH locking for XDP redirect. Message-ID: <20240118083812.1b91ba88@kernel.org> In-Reply-To: <20240118082754.9L_QFIgU@linutronix.de> References: <20231215171020.687342-1-bigeasy@linutronix.de> <20231215171020.687342-16-bigeasy@linutronix.de> <87r0iw524h.fsf@toke.dk> <20240112174138.tMmUs11o@linutronix.de> <87ttnb6hme.fsf@toke.dk> <20240117180447.2512335b@kernel.org> <20240118082754.9L_QFIgU@linutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 18 Jan 2024 09:27:54 +0100 Sebastian Andrzej Siewior wrote: > On 2024-01-17 18:04:47 [-0800], Jakub Kicinski wrote: > > Oh, and I'm bringing it up here, because CONFIG_RT can throw > > in "need_resched()" into the napi_rx_has_budget(), obviously. > > need_resched() does not work on PREEMPT_RT the way you think. This > context (the NAPI poll callback) is preemptible and (by default) runs at > SCHED_FIFO 50 (within a threaded IRQ) so a context switch can happen at > any time by a task with higher priority. > If threadA gets preempted and owns a lock that threadB, with higher > priority, wants then threadA will get back on CPU, inherit the priority > of the threadB and continue to run until it releases the lock. > > If this is the per-CPU BH lock (which I want to remove) then it will > continue until all softirqs complete. So there's no way for a process to know on RT that someone with higher prio is waiting for it to release its locks? :(