Received-SPF: pass (google.com: domain of linux-kernel+bounces-30402-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <05db3bdc-9d54-44d2-8aae-07d66053892e@intel.com>
Date: Thu, 18 Jan 2024 09:15:46 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 4/4] selftests/resctrl: Add non-contiguous CBMs CAT
 test
Content-Language: en-US
To: =?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?= <maciej.wieczor-retman@intel.com>
CC: Fenghua Yu <fenghua.yu@intel.com>, Shuah Khan <shuah@kernel.org>,
	<ilpo.jarvinen@linux.intel.com>, <linux-kernel@vger.kernel.org>,
	<linux-kselftest@vger.kernel.org>
References: <cover.1702392177.git.maciej.wieczor-retman@intel.com>
 <10c3afd7f62c63db31a3d4af86529144a5d7bbf9.1702392177.git.maciej.wieczor-retman@intel.com>
 <fd6acf6a-2610-406b-b363-220121a45aee@intel.com>
 <6v4hgra7bd5nwubcgtbsidmoohrgxdw7no4faa4a54g4vrxo63@c6qnujvwn5ej>
 <73cea732-3757-4aec-a39c-4f0e50f6fb70@intel.com>
 <su2d6i22icynusoykmowfnzery6hlqugovaw4xcrhb7r3ymbx2@aeimvrxsc5xw>
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <su2d6i22icynusoykmowfnzery6hlqugovaw4xcrhb7r3ymbx2@aeimvrxsc5xw>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q2FCd0RrMkw0TzhYTlRGZmQyYyswQWtBcnQ1NkRBUlltSGQ4SzY4Z2VkRWJD?=
 =?utf-8?B?T005NklxMWxra3ZodXhvU3RBUzNOR2VxUlRXTnJERjQ3VDJEVjVydEY2L0hU?=
 =?utf-8?B?RUZXc3A1RlcwVjNTOU10czRDTm1HbWsrSERldlVPUzJONVkyRG5NWjluOFdl?=
 =?utf-8?B?Nm03TUhOdWlSYm43MEdNc0NYQkNtWFNMSTFUK1ZkLzJYSmtuclIxMHpmRE9q?=
 =?utf-8?B?UWNROVdIN2dxS0NYK0puTXc5Q3FJZVU0R0N1VFVhK2p4aW5PRUZjUUxPZkw0?=
 =?utf-8?B?Sy9ZR1dqWUIxZFo2c0IzZEt0MEhrM0EzQWVrcVRIM0Y0WFRXUk9mTVlvQldR?=
 =?utf-8?B?NGNQV1FNRkZLUDRTY01hWHlNMk9Kd2ZJbFFHcXFtZTUrb2V4cHRIMUtORHhs?=
 =?utf-8?B?a3JNd0E0OWVkNjZydm9Sby9Rb0dpRTdMVGNFWUZ5ZHRJb0k2dnlCcUJEdG9D?=
 =?utf-8?B?RVpyV3Y5NERGWDBQenU2Nm9ROHlqWU9NbkJ5RnNoTVdJdHFEbFNDcGNKS0d1?=
 =?utf-8?B?VW1oMSsrbks2VnJKL1JpZDRpNGYwK3Q0NDQ5S1J4N2dXQ2pOekJFOEtqaTFQ?=
 =?utf-8?B?OGltTlhtWDNzVTEvcWQzZlpISktvZGFkZXVHOHBHZG1scWJrSEdQTDVoeStS?=
 =?utf-8?B?d01EemhhOXJnTGxJaXVIaGo5Y3hzejROVXBTRjdVN216RlBvTWFoNE93dEVi?=
 =?utf-8?B?dXRyYjBNbXFCdFNXUTg2QWJiYU9pRU51VGYrK2FFOHZKdjlsTXhLNUJTRGlD?=
 =?utf-8?B?enhnYXJnTFg2bnNQbjYzckVLZFVkcmZJRHc4SkE5TWdZTjRlU1lrc3RTY2Rl?=
 =?utf-8?B?Wkh5WjhxTWtPdkZ0b1VobjM5blZhL1gvRTVWOHJwVWtTUVU0WEs5WG1IT0xH?=
 =?utf-8?B?TDJYci91MDhvU1NYYXBiNSsyS3h3aEJud2I4WVBtdDI5eGJMM2NZNmZuUnN2?=
 =?utf-8?B?UE9PaTN5cVRDMHFYbStyc1BRU3RZUzVVa3JlR3ZXQm1kb1NnL2JPQlNlSDJy?=
 =?utf-8?B?QlNBT3ZWa0tOK3RvMnhWSUFMSjdSb1hpZEplU1hLMDZTbExZeFNCVHVVVEpZ?=
 =?utf-8?B?VHYvU0NPcDhLK1pTMVJUYnFYaXRNZy9MWTd1bWl0ZVVQcGh6SGxHOVpIOEM3?=
 =?utf-8?B?d1dxVkxtSDNlZnZyaHZaK0NTc0JTeVBLUVVvajhSeVdKam9nOXQ1TEtmdlM0?=
 =?utf-8?B?TzJ1QnJPZXl4aCtIZWZmUlgySG5ENjJRVk5jaWxXY0w0WUswWTFvR2l3dW1M?=
 =?utf-8?B?aG8rWVNSLzV0TmFOTW0rR3RJYlozeEhmNDBPL2EwM2x0MnhXZVFUczAwU1Ji?=
 =?utf-8?B?YUlzdVcwNHhMTHo3R29uK3M5MnZGVFIyRXpvM1U3dDNlQVFQKzVpU0lIUVVS?=
 =?utf-8?B?Q0FTenpWMFZjRFBlWFhaTDdJaWJ3eXRtaTNFaldhVS9sc0VvNVZ0akRhUzYx?=
 =?utf-8?B?SHZpVThmcnVZcTZBUjYvWHdtSEloUUtVRExpNEd2NUFaYXZuVDNmYUU0d0Q4?=
 =?utf-8?B?dW1qbUxUa0o5TEg5UjdkUzNMa0xUNGRMQlFMZWFqQ21JTkNYSXFKM2doTUxR?=
 =?utf-8?B?MkRTZDBBT2JEVHpvc1ZhU0wyZ0pDcHRIc1JXd3ZqZXArZjZuUytVZ2pyOXkx?=
 =?utf-8?B?OCtabFFuZGFGck1NVE82RjBUK20vZG1Na0J5VUtCRVUzeTZZaHE2Q0xKY3ZS?=
 =?utf-8?B?MUFkSnVlZXFDWGdEdjdiakxDZXA3UzZqdEkzVWZFOEdIVHlFTVd5WG9QWXpw?=
 =?utf-8?B?bWFSN2ZvTDBicm05YjJhV3BWZi90Yjl1SFNZdDQybDduamhvTjN2bU5wdStC?=
 =?utf-8?B?NFhmWUVQZjZZeWMrR3U0K3N4WWZWaDlRVVRvV29uMHBQYlFOTGg3WFRTVTQw?=
 =?utf-8?B?aXhncVNSRHkzdWsxOXBTb2doU1JtUVpTUTdGRlk5K0lOZ2ZOcFVRQkVCbzN0?=
 =?utf-8?B?ZXJTY1M1Y3pqcHJMdml0UmcwbXFDSUUzWHZxeE0xOWlObzFXQlVjMW1EZXNx?=
 =?utf-8?B?UkRSS2hHVTNYUFRRZDJ2dTdpczZoN2lFNi9zd1IvSGx0Q1d0cU5yOWxMdmdJ?=
 =?utf-8?B?N3p4dTdYQ1J4eDlZSUY2YTIwSy9BT24zNXpHNkhOU2o1MzNhdTdEdDB5MFJw?=
 =?utf-8?B?YjVtUkV4SytuMXFJS2kyaXV4eElpa1RZMlRqOVo5aG8yenQ0MExkKzR0MGFq?=
 =?utf-8?B?YUE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 189e5456-38ff-4992-caee-08dc18491d08
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jan 2024 17:15:47.9930
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZB8s05D4CG7C+JW2wWJoT2mHofQyM5cxbKcziMrUEskYfMFnIMjyvdXxs/MUZ8Na4nVq0avHX/vkFE3F2QKS6rr05bIorXC/xVDoawrhRko=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB8422
X-OriginatorOrg: intel.com

Hi Maciej,

On 1/18/2024 4:02 AM, Maciej Wieczór-Retman wrote:
> On 2024-01-17 at 10:49:06 -0800, Reinette Chatre wrote:
>> On 1/17/2024 12:26 AM, Maciej Wieczór-Retman wrote:
>>> On 2024-01-08 at 14:42:11 -0800, Reinette Chatre wrote:
>>>> On 12/12/2023 6:52 AM, Maciej Wieczor-Retman wrote:

>>>>> +	bit_center = count_bits(full_cache_mask) / 2;
>>>>> +	cont_mask = full_cache_mask >> bit_center;
>>>>> +
>>>>> +	/* Contiguous mask write check. */
>>>>> +	snprintf(schemata, sizeof(schemata), "%lx", cont_mask);
>>>>> +	ret = write_schemata("", schemata, uparams->cpu, test->resource);
>>>>> +	if (ret)
>>>>> +		return ret;
>>>>
>>>> How will user know what failed? I am seeing this single test exercise a few scenarios
>>>> and it is not obvious to me if the issue will be clear if this test,
>>>> noncont_cat_run_test(), fails.
>>>
>>> write_schemata() either succeeds with '0' or errors out with a negative value. If
>>> the contiguous mask write fails, write_schemata should print out what was wrong
>>> and I believe that the test will report an error rather than failure.
>>
>> Right. I am trying to understand whether the user will be able to decipher what failed
>> in case there is an error. Seems like in this case the user is expected to look at the
>> source code of the test to understand what the test was trying to do at the time it
>> encountered the failure. In this case user may be "lucky" that this test only has
>> one write_schemata() call _not_ followed by a ksft_print_msg() so user can use that
>> reasoning to figure out which write_schemata() failed to further dig what test was
>> trying to do. 
> 
> When a write_schemata() is executed the string that is being written gets
> printed. If there are multiple calls in a single tests and one fails I'd imagine
> it would be easy for the user to figure out which one failed.

It would be easy for the user the figure out if (a) it is obvious to the user
what schema a particular write_schema() call attempted to write and (b) all the
write_schema() calls attempt to write different schema.

> On a side note I'm not sure if that's true but I'm getting a feeling that the
> harder errors (not just test failures) are more of a clue for developers working
> on the tests. Would you agree that it seems like users probably won't see
> write_schemata() fail here (if the test execution managed to get to this point
> without erroring out due to bad parameters or kernel compiled without required
> options)?

I do agree that users probably won't see such failures. I do not think these
errors are clues to developers working on the tests though, but instead clues
to resctrl developers or kernel development CI systems.

Reinette