Received: by 2002:a05:7412:ba23:b0:fa:4c10:6cad with SMTP id jp35csp494271rdb; Thu, 18 Jan 2024 09:24:31 -0800 (PST) X-Google-Smtp-Source: AGHT+IGgcZrzcR2LLkAQIRf7SHG8tUEvn1Unzx5uam39hdRyfE1Z4J95eaOAinJ5FtQMmv+oc4BW X-Received: by 2002:a05:622a:38e:b0:429:c8b0:e4fd with SMTP id j14-20020a05622a038e00b00429c8b0e4fdmr1687459qtx.64.1705598670975; Thu, 18 Jan 2024 09:24:30 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705598670; cv=pass; d=google.com; s=arc-20160816; b=llOdUh+8DyreMEnavXXC26A/4LjCwmk/0lFVAIT11s0MT6Mq8RJa8Q395dlm63iiw9 ao6VQBkOvl9v8rmtGl0Se1hDtS2x1kR/0CJsEYnZWNS5mRtCF39Ah7ixjLwixDIhl0fm Wyw93VItX/XhJg9efkcjEfzXAXi+VhYs8iscn5Vg9r39hzC4iEarC5DH7imMjnQyVY9s Ji3+fX5ODS/xKmv/wRpXCg0AKai+4QFLMj8KSGCtx0wx8nXuioEgKA+AjObWLtCCWmPL BFARC74pgOaGvXq1djkti4KSkvt2Om4kxc5TpN7vMrX7AhwCce2fv74Qwl+11Rfd8ciM EWZg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=9gD2xEAPO0p3B/qTZPn6q1g+J7naR3XBwE7W6BCww0E=; fh=gszql63kBkmd37T6LBXCcNjLEtusteQITkFl99JojaM=; b=msBb28BRwVUw/o8quyiywb9QUQx1Yw25IKJvJ+urSRywp91kVpIyG+jk5vFsHBrKCK n23iq/VzL3tv7uExxMHIatmKuY8ligdFN9t8Rezw/0yOncZWvNQTT9Rne6Y+u1ftiFT5 assOM6th9Qlk6T9zOICEOl/7RkSgfiKN34Gf9BMHFsGq80Nc23abSZVG+nINRROz/W+a XTbxXIYXB1x7LS5a6sQqNdIZqdyOx0wXirLxY1d50PaeoiF/YFV6Zbg+TOvmiAelGT1d 68tB7NPjYDciK7NI1oQNKinZp+mEvQgGV3fN/6AoW7/6iFsiO+NoY45rWTW9ndVd7Hhb OqNw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="U/wR20Ik"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-30415-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-30415-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id y20-20020ac85f54000000b004290d54ea4fsi14234190qta.715.2024.01.18.09.24.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jan 2024 09:24:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-30415-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="U/wR20Ik"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-30415-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-30415-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id B89671C2601D for ; Thu, 18 Jan 2024 17:24:30 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 45CDF2C85E; Thu, 18 Jan 2024 17:24:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="U/wR20Ik" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 645A02C84B; Thu, 18 Jan 2024 17:24:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705598663; cv=none; b=F5/4LPORlRObvk8Uc6e7vBNIjDLDrZ83tU6s7OF8Yos0N5TO8MYNo94lIBy4jAogx6nXjPWWcwc0aLNsl8ln02QXv/yNFHnvPIjQLx4y0UC272nOvnhENH57Yp5D2kXa0/pXhfJuX48OWJqpaDt4kYa5luK/C8q3GYWWf5qlMcw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705598663; c=relaxed/simple; bh=fwjbGDSFIjc8qlO4WD/Kh7B3ZcBVJBmaJHRvtZrLsQA=; h=Received:DKIM-Signature:Date:From:To:Cc:Subject:Message-ID: References:MIME-Version:Content-Type:Content-Disposition: In-Reply-To:X-Cookie; b=gkk9z1ucXBe+Mas0F35YAuOQMydXAkGVM9iGBHs6lzm/QJf6vZ7BOyA5pk2p35n7KAVuH9rFkKfzD1+HqnBQB9KvpS7t9fd6mgBDuBx/JzTTsX0L7BMC6eaOS80p2F0epht0b56EyH882Md8igzwcyB+YYSbhgIok9l/qyJcSVg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=U/wR20Ik; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 80269C433C7; Thu, 18 Jan 2024 17:24:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705598661; bh=fwjbGDSFIjc8qlO4WD/Kh7B3ZcBVJBmaJHRvtZrLsQA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=U/wR20IkdFKEa6etry0nq9xG/nHA6/iN+lCrnxbPsqLCqSxt+JloUKnAkZTwEtm2L rN0YE18lsRlwry23wNjsqN3FVeNhPGEdQomhbXJdmfZ2DCDM1cL/S5BmpdFfTr5CCw RCrPu+FA+uyaO9Bg10TPMbr3KJA0TE0l5epsNE7ar1S48lsgm3Q4KkNa6fnXO6G3og 4e+JVM7jlBBitrbR52ybBsKc6SICKubRk17Qpr0I0/vnurvxjcvEP5qCbahNA9mMtS VDbsSGBcdxYWOWNhbM64BpzRhCq9rwXmuxiAVEscG6RT8cEdhd8RbMJ2Z1K2iP73eG KZyRGikvIWLLQ== Date: Thu, 18 Jan 2024 17:24:16 +0000 From: Mark Brown To: Johan Hovold Cc: Srinivas Kandagatla , Banajit Goswami , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v3 1/5] ASoC: codecs: wsa883x: fix PA volume control Message-ID: References: <20240118165811.13672-1-johan+linaro@kernel.org> <20240118165811.13672-2-johan+linaro@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="uU07sBcsXDNnOMTd" Content-Disposition: inline In-Reply-To: <20240118165811.13672-2-johan+linaro@kernel.org> X-Cookie: FEELINGS are cascading over me!!! --uU07sBcsXDNnOMTd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 18, 2024 at 05:58:07PM +0100, Johan Hovold wrote: > The PA gain can be set in steps of 1.5 dB from -3 dB to 18 dB, that is, > in fifteen levels. >=20 > Fix the range of the PA volume control to avoid having the first > sixteen levels all map to -3 dB. >=20 > Note that level 0 (-3 dB) does not mute the PA so the mute flag should > also not be set. >=20 > Fixes: cdb09e623143 ("ASoC: codecs: wsa883x: add control, dapm widgets an= d map") > Cc: stable@vger.kernel.org # 6.0 This will mean that any configuration saved with alsactl store will change effect, it might be better to just fix the TLV description and live with the unfortunate UX... --uU07sBcsXDNnOMTd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmWpXr8ACgkQJNaLcl1U h9Dj7Qf/RUbEhZL9xGzztZhdMbhnvQx3zBa7jW2Du147E9JDgc8KtkPj7Vkk4Uf3 3FmSoDvBaUI0PGj6+Tno9DunZpJatVosXbxfSECDIKQAfq7MMO03jdQSvVM8jW9J QXu/yx8ZS1JTm3RioGwhZLfrqz2NqiidN75JdRwMHEIMOp+sMjqJMtExzCWxYs2O QDkeI1nR5sZvFmIajm+FfcvbUVRn6g43gzAodZv7T/jsqjCd/9id10UV0Z48wEzG Xt968j4d6CJ/D5YZpat/7RuGEmqde4l7ILaDXnrJyjCdvZ7vLVuLYH0T1YpfzCbD 2VmGNoDs1sLPwPR+Og3WQ+PuTozqIQ== =QGG2 -----END PGP SIGNATURE----- --uU07sBcsXDNnOMTd--