Received-SPF: pass (google.com: domain of linux-kernel+bounces-30460-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Thu, 18 Jan 2024 18:11:09 +0000
From: Mark Brown <broonie@kernel.org>
To: andy.shevchenko@gmail.com
Cc: Charles Keepax <ckeepax@opensource.cirrus.com>, lee@kernel.org,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org, linus.walleij@linaro.org, vkoul@kernel.org,
	lgirdwood@gmail.com, yung-chuan.liao@linux.intel.com,
	sanyog.r.kale@intel.com, pierre-louis.bossart@linux.intel.com,
	alsa-devel@alsa-project.org, patches@opensource.cirrus.com,
	devicetree@vger.kernel.org, linux-gpio@vger.kernel.org,
	linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 6/6] ASoC: cs42l43: Add support for the cs42l43
Message-ID: <aec96f5a-b759-48c7-a5ec-bafe3bfa5357@sirena.org.uk>
References: <20230804104602.395892-1-ckeepax@opensource.cirrus.com>
 <20230804104602.395892-7-ckeepax@opensource.cirrus.com>
 <Zali4qxdegY7H6eY@surfacebook.localdomain>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="97E1gLHhLegY+sZD"
Content-Disposition: inline
In-Reply-To: <Zali4qxdegY7H6eY@surfacebook.localdomain>


--97E1gLHhLegY+sZD
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Jan 18, 2024 at 07:41:54PM +0200, andy.shevchenko@gmail.com wrote:
> Fri, Aug 04, 2023 at 11:46:02AM +0100, Charles Keepax kirjoitti:

> > +	unsigned int hs2 = 0x2 << CS42L43_HSDET_MODE_SHIFT;

> BIT(1) ?

Given that this is writing a value into a register field called "MODE"
it seems very likely that it's an enumeration value rather than a
bitmask (and similarly for all the other places where you're making
similar comments).  Please think a bit more about the code being
commented on when making these minor stylistic comments.

> > +static const char * const cs42l43_jack_text[] = {
> > +	"None", "CTIA", "OMTP", "Headphone", "Line-Out",
> > +	"Line-In", "Microphone", "Optical",

> Better to have this by power of 2 blocks (seems it's related to the possible
> values ranges in the HW).
> If it's just a coincidence that there are 8 of them, perhaps other (logical)
> grouping is better?

This is probably well within the realm of driver author taste...

> > +	// Don't use devm as we need to get against the MFD device

> This is weird...

This is normal, the splitting into subdevices is often a purely Linux
internal thing and not represented in the firmware description so
external resources are linked to the top level.

--97E1gLHhLegY+sZD
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmWpab0ACgkQJNaLcl1U
h9C5DAf+O6KGhhljQY7I80+eSBdyZV5AJMoCpfMru36z4haLJoHDqhn+67FC1yql
1n/AnyJAp3Nl19jHZ4inj+wTpH5+NR0blMMfw0R9FL7jpzbq7b6LgSC+hqfi8vDS
nY2R6zSnnnOm3HxpKrbxFx82jDnVtZumBuJbfW1kL8tJC52DBVDLOpiY+mPpd4jh
OUNcrgsFpw3GMcX6GapLflbfqYRvP8BIZtfhYlHkjRiO/aj9THItdd31GnAOzFpK
R9hyiVdneKaNBHpvRv+XVI355y3eDqACVK6L3ERBXMHDAhXZnBP/n8J/sRJxARn4
MTeH+5L7hG1IzL3kXWLBUbTnfJl+Hg==
=mldP
-----END PGP SIGNATURE-----

--97E1gLHhLegY+sZD--