Received-SPF: pass (google.com: domain of linux-kernel+bounces-30503-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Thu, 18 Jan 2024 11:20:18 -0800
From: Dan Williams <dan.j.williams@intel.com>
To: Dionna Amalie Glaze <dionnaglaze@google.com>, <biao.lu@intel.com>
CC: <sameo@rivosinc.com>, <dan.j.williams@intel.com>,
	<linux-coco@lists.linux.dev>, <linux-kernel@vger.kernel.org>, Joerg Roedel
	<jroedel@suse.de>
Subject: Re: [RFC PATCH v1 0/4] tsm: Runtime measurement registers ABI
Message-ID: <65a979f25c180_37ad294b2@dwillia2-xfh.jf.intel.com.notmuch>
References: <20240114223532.290550-1-sameo@rivosinc.com>
 <20240118033515.2293149-1-biao.lu@intel.com>
 <CAAH4kHb9-7p0z2xgmofiCVkOUgXdkJz89qLPc1DuG0F_Wf4-Tg@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAAH4kHb9-7p0z2xgmofiCVkOUgXdkJz89qLPc1DuG0F_Wf4-Tg@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZTdDOXNReTFqU1dzdUVCc1lyR2llMmF1cVNCYklFYURNZmlrZzEzWlhrUU5o?=
 =?utf-8?B?VlFzem5DdG5VWDFKMDRVbVl3MXdOR2E5aVI5R3haVVJqdERXKzNkVGIwbFho?=
 =?utf-8?B?dmVRNWFlTVZqQ3NJRDFpWXBlR2Y2SC9HanR5dVZUWm4vU2l4VUpxOW1hdmNr?=
 =?utf-8?B?VTJ0ZW9GMk1WRmtkbTRINyt5WGI4a0xpSmxVamxFNkl3OU5UMDFLb05pREFu?=
 =?utf-8?B?MUU4VXZnZ2RieUdLbFF6SmNUTTZOb2s3WlVNMWJCM2hqZmp6TktjeWl5ck5G?=
 =?utf-8?B?SUVWdFB6RUdUSm82NER3SmxnTHFUbG1aZnp5SVJUS3FCbkZzMG9tMkJ4TThk?=
 =?utf-8?B?QnZVQ200TWMrdjB1QjdZbVJRUWdZTVdZejQxWGFrbFlId3lReXRqVkF6WUVS?=
 =?utf-8?B?dmRMYWtTWmNwSjBVMmV6UU93WkNxTzNtU0hoZEhwQTB3aDZZQUJMaDVuSjh3?=
 =?utf-8?B?UlBkRTZ2bVpqRkloVXhBd0U2Y3RqbGZ6WW1jS2s3QXpNb0FRTkV3WS9oZThE?=
 =?utf-8?B?WW1KQ2dRbGs0SEppcTgvSElKS0NEU2Yrc1JTR0pHeGJEWXRwZFp2YjZxL09X?=
 =?utf-8?B?b0RycVZOV3JxWS9yYlpON042NWNvdlU0QUNZTmJmOGhYV0Q0SThhZFFSdW15?=
 =?utf-8?B?T3ZZdG05T3lZa2J0V3pjdERQR3YxMHU3NlNFYUJ0aVI5WVFlMmxFYkV4Tmxy?=
 =?utf-8?B?QTZEeERiS3Zid3FWR1M3NXZOdTRVaCtwa1J2QWtUeW91L29EZUFJY1ladVU4?=
 =?utf-8?B?TzM4Q0lhWlZVUlRKajM2clQzcVAvZHUyaEhtUHFlSENBc2RCWE1KN1hrOFdy?=
 =?utf-8?B?RWl2NVlRVytaYmlDVTgzL20zRHpvL2RDakZobUttVmxSYm9pZkFULzl4WCto?=
 =?utf-8?B?d05QaXIvaVl1WUgwL3dON29rcUlwemROeDNxSktsY1ZMZzYwbzlEQk9OdGZV?=
 =?utf-8?B?WGpxMWtQeWhBQmJoZm1JMzNyd2s1R2FTWXY5MHIrNjNMUUVoWTYyNXQ0WU0y?=
 =?utf-8?B?OUltNkl0amVkQVpic1BDbktxVjdqMzdVR09ua0FPM0FaMFR3SUZQdDZqdXVt?=
 =?utf-8?B?eVI3Rkl3Mnh4ckZvbnhNZ2NRTFVQN2NDbW1iTi8yTnNaMUNpUlo5R29OUFRV?=
 =?utf-8?B?UG9kQjF0QS9qa1MrZEo4VWlSTGNkVjlRVm9wd1NNRm9ianh1bkwzT3l6aXJo?=
 =?utf-8?B?M3ZKYXBrQkZBSWlJOElWYVdyeGRDamsySHgrTmM3MGdDRkY5dlk4eG5teUJQ?=
 =?utf-8?B?YlRYZHI5cC95SUdsem0rQld1SVhNZEFTaHd5SmpKM2d0dEtLUFF5SzdWckFV?=
 =?utf-8?B?RWREdzQ4YXkyQXBjREF6YzNlOGRlKy84TXdoK2Fmbzc2cXpCY2VJOUVGUEhQ?=
 =?utf-8?B?MUttR2xqWU56aXVsQWpxb3RqNFIvb1d4eDdacEExRHlUM3kvaUFXcHlqTlVZ?=
 =?utf-8?B?RnQyZUxWOHEvV2Jjc1BRVzBLeXBmNWNnekN2cmtKUDRKU28vSEJRVnN4cVo0?=
 =?utf-8?B?RzhDckEwazBqczB3UlJyclFPeGtiMzRMaU95Vk5PaCttSC9kSFE3clhTaWFU?=
 =?utf-8?B?Wml1ZkJaMk1HQ3Qxajc1M2w3TFQydFhIUmx2Z3A5UE1VRGVpbnRsUmJCbXlt?=
 =?utf-8?B?YllkdWNucWd3bTFJVWllODZmaWFnMXFodm5hNUdzL1M3bDY5WmdpY1ZzdUJC?=
 =?utf-8?B?cWwzRFAreGxkMjR2dUdDSk52VjRNcXNlaTdlbDNEK2VyTU9kOEhCUERrSE1W?=
 =?utf-8?B?ZUtmQWgvUHZYS3hRdWw4S2VSbTdlSjAvL1B1c296QmpKR3dOUHowSDR2dmVm?=
 =?utf-8?B?d29jVXB6QnRrdU1WZUIwTm1ZVHhEL3FUVU9iaWRlVHlhc01Fc2lrZXY4ZlFU?=
 =?utf-8?B?bG45aUF5dkpCSmlUNmRlenZtalF4VytlNklFRmhCYXJGb2pIOFZFRDI2dzhZ?=
 =?utf-8?B?VDhBUUZXSG1UVmdaUUNhdUI4enp4cjFuTldPbW5QYUQwVEE3SGlVMzJ6MGpD?=
 =?utf-8?B?eXZpK2pQRlU0d1dIcTYwS2FhNFJ1d0U4ZDd5NitpSHE1S3JsVFpianVjMk9L?=
 =?utf-8?B?Y2tHOGZmaWtTRU55WnNjYmF5R1JyaXFSM2lHQnpkanJaa29DS2VYdXdwamdN?=
 =?utf-8?B?cy82ODN0RCtzTFpSanE0SzQ1R01hd3VyM1p2SGhsMitLNEdEUzR6N1RweG1h?=
 =?utf-8?B?MEE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 979b18ba-641a-4044-e30b-08dc185a82e5
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jan 2024 19:20:20.3238
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QtJbgLJd5mqdAd7fYhOGXJL0qpOsldMBXKtBML+LYalJXOWOSPxDUpZWZvDvBkMaLeK3fCWxWsQd4oOXxwBkIINL+A9ypfZh22qgZ4Qqqr0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB8133
X-OriginatorOrg: intel.com

Dionna Amalie Glaze wrote:
> On Wed, Jan 17, 2024 at 7:36 PM <biao.lu@intel.com> wrote:
> >
> > Samuel Ortiz wrote:
> > > Some confidential computing architectures (Intel TDX, ARM CCA, RISC-V
> > > CoVE) provide their guests with a set of measurements registers that can
> > > be extended at runtime, i.e. after the initial, host-initiated
> > > measurements of the TVM are finalized. Those runtime measurement
> > > registers (RTMR) are isolated from the host accessible ones but TSMs
> > > include them in their signed attestation reports.
> > >
> > > All architectures supporting RTMRs expose a similar interface to their
> > > TVMs: An extension command/call that takes a measurement value and an
> > > RTMR index to extend it with, and a readback command for reading an RTMR
> > > value back (taking an RTMR index as an argument as well). This patch series
> > > builds an architecture agnostic, configfs-based ABI for userspace to extend
> > > and read RTMR values back. It extends the current TSM ops structure and
> > > each confidential computing architecture can implement this extension to
> > > provide RTMR support.
> >
> > Hi, Samuel
> > The ABI does not include eventlog, but eventlog is usually used with RTMR.
> > What do you think about how to implement eventlog?
> >
> >
> 
> I had the same question and deleted my reply. The event log in TPM is
> made available in sysfs only up to the point that control transitions
> to user space. After that, all extensions to PCRs have to be logged by
> user space with whatever chosen workload event log representation. I
> imagine the same is true for RTMRs.
> 
> What this patch series doesn't take into account is how RTMRs might
> not be represented in the hardware attestation, but rather would be in
> a supervisor service whose integrity is chained from hardware
> attestation. In the configfs-tsm model, tsm/report with its single
> provider requirement will not be able to interface with the SVSM
> attestation protocol /and/ the AMD hardware protocol. That may as well
> be okay, but that's a choice folks need to be aware of. There's still
> the issue of attesting a single service vs attesting all services in
> the SVSM. I imagine single service attestation will have to be
> abandoned.
> 
> In SVSM, a vTPM is a service that an updated linux driver will be able
> to get a quote from, and the same AMD SEV-SNP attestation report TSM
> provider would still be present, but if we want a simpler RTMR
> service, then we're in a little pickle with this design.

There is a good chance I am misunderstanding the concern, but I would
say yes, the vTPM that would be layered on top of RTMRs is independent
of the SVSM vTPM effort. For an architecture without RTMRs, vTPM via
SVSM is likely the only choice, and for architectures with RTMRs an SVSM
indepdendent vTPM is possible. For the kernel it already has a
vtpm_proxy driver that could be put to use here, and that would be
independent of the eventual SVSM vTPM driver.

I am using "SVSM" above with the model of a layer providing services to
an unenlightened TVM in mind. In contrast, this RTMR model requires some
TVM enlightenment to setup vtpm_proxy on top of this cross-architecture
building block.