Received-SPF: pass (google.com: domain of linux-kernel+bounces-30515-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Thu, 18 Jan 2024 14:27:45 -0500
From: Samuel Dionne-Riel <samuel@dionne-riel.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Maxime Ripard
 <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>, David Airlie
 <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
 dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] drm: panel-orientation-quirks: Add quirk for GPD Win
 Mini
Message-ID: <20240118142745.1b52585a.samuel@dionne-riel.com>
In-Reply-To: <20231222030149.3740815-2-samuel@dionne-riel.com>
References: <20231222030149.3740815-2-samuel@dionne-riel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 21 Dec 2023 22:01:50 -0500
Samuel Dionne-Riel <samuel@dionne-riel.com> wrote:

Hi,

Can I request a small share of your attention to review, and apply this patch?

Thank you all,

> Signed-off-by: Samuel Dionne-Riel <samuel@dionne-riel.com>
> ---
> 
> Changes since v1:
> 
>  - Add 1080p right-side up panel data
>  - Use the correct panel orientation
> 
>  drivers/gpu/drm/drm_panel_orientation_quirks.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> index 3d92f66e550c3..aa93129c3397e 100644
> --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> @@ -117,6 +117,12 @@ static const struct drm_dmi_panel_orientation_data lcd1080x1920_leftside_up = {
>  	.orientation = DRM_MODE_PANEL_ORIENTATION_LEFT_UP,
>  };
>  
> +static const struct drm_dmi_panel_orientation_data lcd1080x1920_rightside_up = {
> +	.width = 1080,
> +	.height = 1920,
> +	.orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP,
> +};
> +
>  static const struct drm_dmi_panel_orientation_data lcd1200x1920_rightside_up = {
>  	.width = 1200,
>  	.height = 1920,
> @@ -279,6 +285,12 @@ static const struct dmi_system_id orientation_data[] = {
>  		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "G1618-03")
>  		},
>  		.driver_data = (void *)&lcd720x1280_rightside_up,
> +	}, {	/* GPD Win Mini */
> +		.matches = {
> +		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "GPD"),
> +		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "G1617-01")
> +		},
> +		.driver_data = (void *)&lcd1080x1920_rightside_up,
>  	}, {	/* I.T.Works TW891 */
>  		.matches = {
>  		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "To be filled by O.E.M."),