Received: by 2002:a05:7412:ba23:b0:fa:4c10:6cad with SMTP id jp35csp574162rdb; Thu, 18 Jan 2024 11:53:51 -0800 (PST) X-Google-Smtp-Source: AGHT+IEOfpGWhpd2SuPiz9F49JF0vqEVndkXd0RS0LH885NqFauZn5uicV10j1YVAaqe1hfPh/Bv X-Received: by 2002:a05:6870:d909:b0:203:e33d:be99 with SMTP id gq9-20020a056870d90900b00203e33dbe99mr1463331oab.81.1705607630685; Thu, 18 Jan 2024 11:53:50 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705607630; cv=pass; d=google.com; s=arc-20160816; b=mxUPEDK89hIvv2QdaPQA3gElphDv73rsU8+5dPpfLQZ2LKg5ZMuKYbt3zLeuPz7drL ty2GBiwUVTZLU58/HKiscqGpJOeOhlx2hLV53HK5lyA5LT6aPaI6E3FK06mUOB8/MV2e Yibc/XUWbmAsSj4+epgdcBv0FDKaJBuXnsiUD8Jf1bCpmOhKl0njx/kfAf6L9UnzZOCt DcnIW3jdf+sBWN9EPqVM8W2KadTzQy+HbKl+ztBvnZ4JEwYjCYUcAqmp+5P5DMvESnVO LCtk6fBCOmdTKT3AzeqZ6PUgbGc9K9gGoh1b2GSxTsYfT9Z50ZzLblwRLFqP2qp8KDQe OKmA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=3aPW495Dn9XKu9eq4/g3SllgOOtpizGjdMGk5c2KiHI=; fh=4k/hBd5bniHYlcfGRcGNASfaBL4ptGqyAdLkGSvHCDM=; b=kuUlytKIPj/rNwviqNwF6m3s9vpmEkAF78G66pp/Grarn8l8J7TaUECqhfqJ4yp7WY GeZss15XoyW4SrIwve11i8VvtNSRkbOzFO6goVjKC9mxKabzJemhsIXntSayiM/Xvrdw q/rq4LV0DpYemJACJ7ofqIcq+/bFE4clRfwUK+3/hCNcFuyUxxrRewKOo/ZxndWVovQ1 7L7JiydHZm3T95Hf3mI1MJngYmhrGPsEzEzcYWMvnt+L8b922NyPo53kjwqlSSbMY4CV MpKTKR0RcZTWePEOTAtVkDazhqz21CzeWg74Ea+vsjmNzoWYmwCA66A/zEG8KsQYpkMc +3Rg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=nUkXCAb4; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-30527-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-30527-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id p17-20020a05622a13d100b00429f5dd65dbsi7434598qtk.480.2024.01.18.11.53.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jan 2024 11:53:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-30527-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=nUkXCAb4; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-30527-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-30527-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 702E61C22568 for ; Thu, 18 Jan 2024 19:53:50 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B70C32E654; Thu, 18 Jan 2024 19:53:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="nUkXCAb4" Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 98EB12E652 for ; Thu, 18 Jan 2024 19:53:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705607613; cv=none; b=dqxh3E5P8VbK9UxtRbkzdTeiplZjDDuYMHUbl/XaPhrl8Iw+QSzh0kIACsWq6DHK90NO5Irr2Sa6EWfivxypH/gWJsbuRudwlyydSHkNg9sk/0Qqi4BBvGsjsbHHJONPrKOW/HsiXqtu1wQLziqsMtoEy3IN0og6lnvmV6HVnbI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705607613; c=relaxed/simple; bh=3H0/PUm19INCLpIv8lZ7mMSa24z+/2A2899KRBqjzRs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=spsCCX80VtXhtzuzvFsexiUh435TrDIljAtaQVuGE2oX0IuAMbx5aipIDJ7Vhk8M6V3tMI1wjqGiacCk+yLjIJ3frBU7LKVl1bBy3RtK+/QaUR42foWlzSVuoGKRrVRQtn3rrvgM0m3tP48PqMafSbVDFmpqRMkpeJj7tKCWcik= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=nUkXCAb4; arc=none smtp.client-ip=209.85.208.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-lj1-f176.google.com with SMTP id 38308e7fff4ca-2cd2f472665so419971fa.2 for ; Thu, 18 Jan 2024 11:53:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1705607610; x=1706212410; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=3aPW495Dn9XKu9eq4/g3SllgOOtpizGjdMGk5c2KiHI=; b=nUkXCAb4Fm5bxn7eBWh51/ApFEuauRltQor1g8kFVg83WGzquCQKb1xIx+pReuKrK6 dBr+YoZ4F1bkEYKycZKmUcbQgYq28kT+NgRwsELQSOoZmPL+pj9YfrKdc3EfBHshUcCH 1tffyZK6rqPmGnh9aUhDeh/40wumRL4wqpxJ8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705607610; x=1706212410; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3aPW495Dn9XKu9eq4/g3SllgOOtpizGjdMGk5c2KiHI=; b=XcQQ2JC8iHjfa/acCSn3+5gsKTplXNp6Q406DFN0r/Dw9pLI1lJqpNnyf2+C1WsOg+ EyRBgI+BEM/HwMKYioVjQ6Q2e2p//jr5W2JG9rDg6Wvz8uhF7meCtak5sZjs7MAvdYG1 GPX/xYNzNvwQHsg2DKtM8ayljmyGp4tZ/yIC5waYuv6Cj5REqgmgkUDP9AY66tzfv0E2 g0HWKQJElLrNAT8eDL4umTeUJzIN77RemDm9sWPrnKXcvuvpiwlBnQyQvgU6bAssUUib 77BhtKOKpp5qEGh03wD/Xkrrsfc4GfOmIm9Sz1+BxThLopdnS2ASuiCcgX3TujP8O/JQ 826w== X-Gm-Message-State: AOJu0YxzPebgMVg9PWKhVDmVbTcJvfoHX62EA5mHaKwuyh//UYPfapaR ewdCYiQ7XkrPHqefjAU2vxcw3iYk0LYUvMXlcrCad+ce+LvNR0oeuGL7tjc0Sg== X-Received: by 2002:a2e:9d9a:0:b0:2cc:db7e:aac2 with SMTP id c26-20020a2e9d9a000000b002ccdb7eaac2mr836985ljj.58.1705607609722; Thu, 18 Jan 2024 11:53:29 -0800 (PST) Received: from cracow.c.googlers.com.com (138.58.228.35.bc.googleusercontent.com. [35.228.58.138]) by smtp.gmail.com with ESMTPSA id 2-20020a05651c00c200b002ccd3e8a59esm2333345ljr.121.2024.01.18.11.53.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jan 2024 11:53:29 -0800 (PST) From: Lukasz Majczak To: Gwendal Grignou , Tzung-Bi Shih , Radoslaw Biernacki , Wim Van Sebroeck , Lee Jones , Benson Leung , Guenter Roeck , Krzysztof Kozlowski , linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev Cc: Lukasz Majczak Subject: [PATCH v2 0/3] Introduce EC-based watchdog Date: Thu, 18 Jan 2024 19:53:21 +0000 Message-ID: <20240118195325.2964918-1-lma@chromium.org> X-Mailer: git-send-email 2.43.0.429.g432eaa2c6b-goog Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Chromeos devices are equipped with the embedded controller (EC) that can be used as a watchdog. The following patches updates the structures and definitions required to communicate with EC-based watchdog and implements the driver itself. The first version of this patch was sent here: https://patchwork.kernel.org/project/linux-watchdog/patch/20240117102450.4080839-1-lma@chromium.org/ Changelog V1->V2: * Splitted into three patches * Supplement the watchdog configuration with min/max timeouts * Removed struct cros_ec_wdt_data and get aligned to watchdog framework * Simplified suspend/resume callbacks * Removed excessive log messages * Reworked cros_ec_wdt_send_hang_detect() function to be more generic * Usage of devm_* allowed to delete .remove module callback * Changed MODULE_ALIAS to MODULE_DEVICE_TABLE * Moved clearing bootstatus (on EC) to probe() and thanks to that got rid of .shutdown() module callback * Fixed/removed comments, removed unused includes and general cleanup Best regards, Lukasz Lukasz Majczak (3): platform/chrome: Update binary interface for EC-based watchdog watchdog: Add ChromeOS EC-based watchdog driver mfd: cros_ec: Register EC-based watchdog subdevice MAINTAINERS | 6 + drivers/mfd/cros_ec_dev.c | 9 + drivers/watchdog/Kconfig | 11 + drivers/watchdog/Makefile | 1 + drivers/watchdog/cros_ec_wdt.c | 202 ++++++++++++++++++ .../linux/platform_data/cros_ec_commands.h | 78 +++---- 6 files changed, 264 insertions(+), 43 deletions(-) create mode 100644 drivers/watchdog/cros_ec_wdt.c -- 2.43.0.429.g432eaa2c6b-goog