Received-SPF: pass (google.com: domain of linux-kernel+bounces-30561-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Thu, 18 Jan 2024 12:42:03 -0800
From: Dan Williams <dan.j.williams@intel.com>
To: Ira Weiny <ira.weiny@intel.com>, Davidlohr Bueso <dave@stgolabs.net>,
	Jonathan Cameron <jonathan.cameron@huawei.com>, Dave Jiang
	<dave.jiang@intel.com>, Alison Schofield <alison.schofield@intel.com>,
	"Vishal Verma" <vishal.l.verma@intel.com>, Dan Williams
	<dan.j.williams@intel.com>
CC: <linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>, Dave Larsen
	<davelarsen58@gmail.com>, Fan Ni <fan.ni@samsung.com>, Ira Weiny
	<ira.weiny@intel.com>
Subject: Re: [PATCH v2] cxl/pci: Skip irq features if MSI/MSI-X are not
 supported
Message-ID: <65a98d1bc2dcc_2d43c29495@dwillia2-mobl3.amr.corp.intel.com.notmuch>
References: <20240117-dont-fail-irq-v2-1-f33f26b0e365@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240117-dont-fail-irq-v2-1-f33f26b0e365@intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Sqt7h8Kp87rwWjPsu2+b13suGa4WzGJB18UGKuDVisTDlNwb1YqDScmivi9F?=
 =?us-ascii?Q?jUskmlQyCCSkUvyi8DeR3QsEL2hcStaRiRtdJ5mekSHnAQ/HmArolD6n+Dxo?=
 =?us-ascii?Q?e7SxcZNN1OZdH4PJG2u029I6sXZyxJ35m1rp7Z1bovCMq9mjx7cR0wqkngzG?=
 =?us-ascii?Q?Xtbc4be0nkP0AscA8mm2tZ+3FLyr8wzgxusAffiJDMfFJWQdGkVq+eOk34PP?=
 =?us-ascii?Q?fJUfwPo6FSEteBtAZ/xRvnYJc/EemWLZa/h3HTw1kq2ggvauA3dTwkbmnHW8?=
 =?us-ascii?Q?QVOiKkiKMwK8NU9CLwrQE6YWPjQzDeXwxUFLGlsz/UaqRbolu4MWCfsMAdLL?=
 =?us-ascii?Q?o56uwtq04AY/B8KdL9ZotzwaklFuTItkFJujv1aVXttcTWJe8y3flg2SlggQ?=
 =?us-ascii?Q?/GATAzsUmm9jO/gcsB/YNaon236M01L+cYX6GMhtzAt8U9wWSwRAhyf0Uvme?=
 =?us-ascii?Q?F6eUy0XUBoYDolgRPf+4cQ59ofaVNlJim+DRtRVBipjKV9Ry1srn8qgDRAVC?=
 =?us-ascii?Q?ydefcroyhQkfTCf0X2m/8B+mzSd1jWDD0Ky6L30STg4Y7webhbhA8xLLaQzQ?=
 =?us-ascii?Q?gndmNdEpqBnd46gU42lcEPCD405muCWwhf4ls71X1a4xjJXZwV0SvkDEedb4?=
 =?us-ascii?Q?pZFw5pIrdw8NeuIagVTXde2d5jPua83VQAUiUaW+SmtmSeQYZ3GodEsy+j2x?=
 =?us-ascii?Q?Jrc4pN+8gc0NpDAiLogV50aGP153oDzNz/ao0VWmvwDz6JaOPDWR3gmk5XsU?=
 =?us-ascii?Q?q0spQIt4z3bRhYD2QFwVsAsZnUVVp/sGKJFjtt6NBlqGSzeuCprmTOZVECKl?=
 =?us-ascii?Q?AKtm4u3QeMxoX4OtluvOTPGtvjaIhcGqI5HLFO9I9KosAagJrgX183avAHES?=
 =?us-ascii?Q?f0ajBeAq7kpFtT65a+RzDL8WBFme3xxlTEUTa/x9ERLrrRut7Dm2nZ/SnSmy?=
 =?us-ascii?Q?g2EkvGe2FATpZtTtOH9AMOhelBvV7Y7ot0mF4EhGHNLfy0SH4Fp2Rc1BfK4K?=
 =?us-ascii?Q?XCYHhS5Xf8WbgwYcNCS/GQAJpsUgrchQTZ1MSmqEpIsUYFSUs0GJuTZhuSLF?=
 =?us-ascii?Q?UTpHO4r+ace7sJNx5e6TP7KD3IOE3oZMtKn7DipQD8SYVWqrnF848S4etnGp?=
 =?us-ascii?Q?5EgQZvO6vjwZjnhmtZuFk6CdppeGhW0kYZeLg9tCvL3s1WnqtfwSDDXzU7rc?=
 =?us-ascii?Q?jxLSIFVr8q/gXt+Ky1tqbGYCxELy+GHRnCOwhZczvNAiDThwBVf8KJuGVjzv?=
 =?us-ascii?Q?jw/EcbZlECYqTnxt3RajbY+bQ23K9kWLJ2YtTAN1ewZIuiZUPNRNn3IDCxcl?=
 =?us-ascii?Q?AWzbFxLRTXz+QBOEpb8bfMSoDbCtq037iOcRq4KL7krhNT809/+rqsgQazMv?=
 =?us-ascii?Q?tYohl2CRikClCw7vSaLc9T7G8rdxnaOcJiY3GpWAqoMUVhffaXyPP6zVquvr?=
 =?us-ascii?Q?5KnoRMYc1e4iFsdxL99BXvO4jVJKnB05L3RClGw54mNf4Da5hs7VwcO56I75?=
 =?us-ascii?Q?pkautzJTRQE7w8Jq717hA09hvwCQxFubu1YaEyZnL+8xMRivhYvMbFCjjBLR?=
 =?us-ascii?Q?Zmk5xKl0SDloKAqc76sJfMC7vNZiUoHvuUprSdeAKapRpDo8Ru4ZipLTcehj?=
 =?us-ascii?Q?PA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: be7b2c04-1e2a-456b-2a64-08dc1865eef0
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jan 2024 20:42:06.0480
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: F2mHxxzgY+lPCum0YxbPl24VSprG3536bjjproJhVKt6ghBiAVr67XkhXDbOqvaSZSNNZGNcdjz3EWOG2WF9VMTJD/UiWP9if4AWnvY9Mio=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6057
X-OriginatorOrg: intel.com

Ira Weiny wrote:
> CXL 3.1 Section 3.1.1 states:
> 
> 	"A Function on a CXL device must not generate INTx messages if
> 	that Function participates in CXL.cache protocol or CXL.mem
> 	protocols."
> 
> The generic CXL memory driver only supports devices which use the
> CXL.mem protocol.  The current driver attempts to allocate MSI/MSI-X
> vectors in anticipation of their need for mailbox interrupts or event
> processing.  However, the above requirement does not require a device to
> support interrupts, only that they use MSI/MSI-X.  For example, a device
> may disable mailbox interrupts and either be configured for firmware
> first or skip event processing and function.
> 
> Dave Larsen reported that the following Intel / Agilex card does not
> support interrupts on function 0.
> 
> 	CXL: Intel Corporation Device 0ddb (rev 01) (prog-if 10 [CXL Memory Device (CXL 2.x)])
> 
> Rather than fail device probe if interrupts are not supported; flag that
> irqs are not enabled and avoid features which require interrupts.
> Emit messages appropriate for the situation to aid in debugging should
> device behavior be unexpected due to a failure to allocate vectors.
> 
> Note that it is possible for a device to have host based event
> processing through polling.  However, the driver does not support
> polling and it is not anticipated to be generally required.  Leave that
> functionality to a future patch if such a device comes along.
> 
> Reported-by: Dave Larsen <davelarsen58@gmail.com>
> Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> Reviewed-by: Fan Ni <fan.ni@samsung.com>
> Signed-off-by: Ira Weiny <ira.weiny@intel.com>
> ---
> Changes in v2:
> - [djbw: add reported by and info about the card.]
> - [djbw: skip error reporting in the mailbox case.]
> - [djbw: clean up event message]
> - [iweiny: pick up tags]
> - Link to v1: https://lore.kernel.org/r/20240111-dont-fail-irq-v1-1-802c22a79ecb@intel.com
> ---
>  drivers/cxl/pci.c | 26 +++++++++++++++-----------
>  1 file changed, 15 insertions(+), 11 deletions(-)

Looks good, I consider this suitable as post -rc1 material. Will get it
queued once the merge window closes.